From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>, "Guo, Jia" <jia.guo@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow FDIR enable issue
Date: Wed, 20 May 2020 07:37:29 +0000 [thread overview]
Message-ID: <BYAPR11MB3541D0EEA4F744CA8B51B2DBF7B60@BYAPR11MB3541.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR11MB139148A183D453EA8EA2FCA7B7B60@MWHPR11MB1391.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Zhao1, Wei <wei.zhao1@intel.com>
> Sent: Wednesday, May 20, 2020 1:13 PM
> To: Xing, Beilei <beilei.xing@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Guo, Jia <jia.guo@intel.com>
> Subject: RE: [PATCH] net/i40e: fix flow FDIR enable issue
>
>
>
> > -----Original Message-----
> > From: Xing, Beilei <beilei.xing@intel.com>
> > Sent: Wednesday, May 20, 2020 12:14 PM
> > To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> > Cc: stable@dpdk.org; Guo, Jia <jia.guo@intel.com>
> > Subject: RE: [PATCH] net/i40e: fix flow FDIR enable issue
> >
> >
> >
> > > -----Original Message-----
> > > From: Zhao1, Wei <wei.zhao1@intel.com>
> > > Sent: Tuesday, May 19, 2020 3:17 PM
> > > To: dev@dpdk.org
> > > Cc: stable@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Guo, Jia
> > > <jia.guo@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> > > Subject: [PATCH] net/i40e: fix flow FDIR enable issue
> > >
> > > When we flush flow FDIR, all queues are disabled for FDIR.
> > > If FDIR rule is created again, then the flow list is empty, as it is
> > > the first time to create rule after flush fdir filter, so we need to
> > > enable FDRI for all queues. And also, disable FDIR for queues should
> > > be done in function i40e_flow_flush_fdir_filter().
> > >
> > > Cc: stable@dpdk.org
> > > Fixes: 1491f63c7559 ("net/i40e: fix flush of flow director filter")
> > > Fixes: 6ae9b2b5e8c2 ("net/i40e: cache flow director enable value in
> > > Rx
> > > queue")
> > >
> > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > > ---
> > > drivers/net/i40e/i40e_flow.c | 12 +++++++++---
> > > 1 file changed, 9 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/net/i40e/i40e_flow.c
> > > b/drivers/net/i40e/i40e_flow.c index
> > > 25c77e7aa..94fc73092 100644
> > > --- a/drivers/net/i40e/i40e_flow.c
> > > +++ b/drivers/net/i40e/i40e_flow.c
> > > @@ -3462,6 +3462,12 @@ i40e_flow_parse_fdir_filter(struct
> > > rte_eth_dev *dev,
> > > }
> > > }
> > >
> > > + /* If the flow list is empty, it is the first time to create
> > > + * rule after flush fdir filter, so enable fdir.
> > > + */
> > > + if (TAILQ_EMPTY(&pf->fdir.fdir_list))
> > > + i40e_fdir_rx_proc_enable(dev, 1);
> > > +
> >
> > i40e_fdir_rx_proc_enable is called in i40e_fdir_configure, so could
> > you check if we can optimize this and if statement (pf->fdir.fdir_vsi == NULL)
> above?
>
> No, when "flow flush 0", the pf->fdir.fdir_vs is not NULL, but list pf-
> >fdir.fdir_list is empty.
Then seems i40e_fdir_rx_proc_enable(dev, 1) can be removed from i40e_fdir_configure, since i40e_fdir_rx_proc_enable(dev, 1) will always be called when the first FDIR rule is created and fdir_list is empty.
Or we can use 'else if (TAILQ_EMPTY(&pf->fdir.fdir_list))' to avoid duplicate execution of i40e_fdir_rx_proc_enable(dev, 1).
>
> >
> > > return 0;
> > > err:
> > > i40e_fdir_teardown(pf);
> > > @@ -5330,9 +5336,6 @@ i40e_flow_flush(struct rte_eth_dev *dev,
> > > struct rte_flow_error *error)
> > > return -rte_errno;
> > > }
> > >
> > > - /* Disable FDIR processing as all FDIR rules are now flushed */
> > > - i40e_fdir_rx_proc_enable(dev, 0);
> > > -
> > > return ret;
> > > }
> > >
> > > @@ -5368,6 +5371,9 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf)
> > > for (pctype = I40E_FILTER_PCTYPE_NONF_IPV4_UDP;
> > > pctype <= I40E_FILTER_PCTYPE_L2_PAYLOAD; pctype++)
> > > pf->fdir.inset_flag[pctype] = 0;
> > > +
> > > + /* Disable FDIR processing as all FDIR rules are now flushed
> */
> > > + i40e_fdir_rx_proc_enable(dev, 0);
> > > }
> > >
> > > return ret;
> > > --
> > > 2.19.1
next prev parent reply other threads:[~2020-05-20 7:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 7:16 Wei Zhao
2020-05-19 9:36 ` Cui, LunyuanX
2020-05-20 3:18 ` Jeff Guo
2020-05-20 3:22 ` Zhao1, Wei
2020-05-20 4:13 ` Xing, Beilei
2020-05-20 5:13 ` Zhao1, Wei
2020-05-20 7:37 ` Xing, Beilei [this message]
2020-05-20 7:43 ` Zhao1, Wei
2020-05-21 8:03 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2020-05-21 14:27 ` Jeff Guo
2020-05-22 0:59 ` Zhao1, Wei
2020-05-22 2:16 ` Jeff Guo
2020-05-22 9:18 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3541D0EEA4F744CA8B51B2DBF7B60@BYAPR11MB3541.namprd11.prod.outlook.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).