From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA4E8A0093; Wed, 20 May 2020 09:37:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5AB271D15A; Wed, 20 May 2020 09:37:38 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 6C8991C2E8; Wed, 20 May 2020 09:37:36 +0200 (CEST) IronPort-SDR: E5JoUbUUSsfufo8ldso1VdygLwQuV+DUX3qCgB13TyKOeVMbbLigGn4DLkjLkJEKc1AIxMK9LO h1TLx24VOHMg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2020 00:37:35 -0700 IronPort-SDR: biwvbhxhanVVVtSboZW5LJYA+ZaB5/KT3GSETS9XHU1jEEWXyYNfpBha2GKGW9+KSw33m6dtt0 n46lscihgp7Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,413,1583222400"; d="scan'208";a="466289116" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 20 May 2020 00:37:34 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 00:37:34 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 20 May 2020 00:37:33 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 20 May 2020 00:37:33 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 May 2020 00:37:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EmPzE6Fwkao+i4nWUGdVwns3PxJJa+JQRomPJcE7fEVJ+EpEPDsv1K+V4le9f1ehK/IVv3aHTaHuzR1B5lw5DIyDk76X8PxrS7G2WerhcTG6xiS1+RQbmHiZ8Gf0mTXkUXYJColoqFbGFexR2dQ4EiaY/yC/tHwk70Jffk440eI1FDFOPgaQFWO7J/opE/+tloefOrFpRxHl82goPBnJ2MN1MKmXLGO05GelvmZvrUx56OZSLyO4UU1RQcNXy+F9EBsuG6x14o5uB7LHmZWwLp40WvFmUpyfNJGg9K8Yo3tv6UbUcdxLw3cGWwao+N6oixaIPHFPOiaOetDwYlHcnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L2+rf/DREIntKtUP6JrkiiJ99sqYck0STZ3fMsU1Y3U=; b=NEtxjfSSpAkiFB98kM8MIpnJcSaqL1JG+Ubks4pQ7JVVfQkGCBC/g9Q3OB9CGkrTrc6q1QDMsExNCqTPm9dG5kIIeANBdScD+q6hOv6qALwxrEnPaUczjoJoNhA02+T9C4mw0i+0grf9RJHQsEpa7oUoaCKcfSHAh580s7gYYKVzm1wqGKCXPZvWoUTEmSKXS6pWwZQO3vwc7QXsMyn/vgThIDMYKEKcSKVYf6LGt/aX41VshWw1O4XzvaD21Bgh0uzSrr9GmiYNEX929rl0J6TG8rh/Z2rY3AJG58UsRCrB2R6WAhgxNoBjNA572y24ssyYeP+JoQvkoHPR3itBpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L2+rf/DREIntKtUP6JrkiiJ99sqYck0STZ3fMsU1Y3U=; b=tZjVdmySwbBHqDaxPft9MK0wmujfxfxsItGQD4OR9S3A1l/rA+8gabPgYPaX+tpz6KskzlAmNeJ1QvVrBLDst+3KHqKimh4QpZo35nb1Y5B59wz+vxn8tV+qu8+co+tjg/F/Q72SkSAGDTBfb9x6wZ5BmqlJ0A0YmHpPLxw9tZA= Received: from BYAPR11MB3541.namprd11.prod.outlook.com (2603:10b6:a03:f5::16) by BYAPR11MB2821.namprd11.prod.outlook.com (2603:10b6:a02:c9::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24; Wed, 20 May 2020 07:37:29 +0000 Received: from BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::9d22:d78d:bdf2:313f]) by BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::9d22:d78d:bdf2:313f%4]) with mapi id 15.20.3021.020; Wed, 20 May 2020 07:37:29 +0000 From: "Xing, Beilei" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Guo, Jia" Thread-Topic: [PATCH] net/i40e: fix flow FDIR enable issue Thread-Index: AQHWLbDSamZnNIy2T0qCuc08s00UkaiwXW5AgAAR+gCAACP0sA== Date: Wed, 20 May 2020 07:37:29 +0000 Message-ID: References: <20200519071652.26537-1-wei.zhao1@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 76ce8a86-f218-446f-0afe-08d7fc90a6bb x-ms-traffictypediagnostic: BYAPR11MB2821: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 04097B7F7F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /WCb89P7hbfzUeT1Bq97ApPeP73DlMpx6T2XEFgvCulbNUUM3lLMnCQ3la3eKxZRIHenZFROARF6dVRR6ykbVC9M4u4ZRQFYRCS4N25dQE7NzekOik+GUC6nWzdUbyzg80cX834uR0QZGKXGBVlQtLNCuz3QnN4urK+KqR+rc2uZnLUfnyxW2Ec4t+IZosZIC2ZyB59UVWbXRmxSUz2ddTCcugmODxaJ+x3lxvRPyZD085fGPh9/O5FKb3qczw92dxoc0gyE8lLJnrVwTITL2/XUHKnJ4eMwKDf13OeBbwdqhAFmmlYQQPTEzZDDaeV10marhh8J9CUkeA2HhofUxC74l6C7+S98jIW6K3uA6mf0DFstmirXhkEv0Rzt+sfmNSihgBIaIp3CfK0yLLTmHXHfD+rOfH1M3v8tYNIcsPm3SPq4nBkjmbwUxur3F5YM x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3541.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(376002)(346002)(396003)(39860400002)(366004)(136003)(2906002)(7696005)(71200400001)(316002)(8936002)(8676002)(76116006)(478600001)(26005)(186003)(86362001)(54906003)(6506007)(53546011)(110136005)(4326008)(107886003)(52536014)(5660300002)(66946007)(66556008)(9686003)(66446008)(33656002)(66476007)(64756008)(450100002)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 4Tawkg2lvSEXc4mhicZ6slfAOx14zy+idgRa28HUxqfnXW3/dRba2B8C3RrXPLo+ISyA+gbcYr2eb+urxxHRkGOkpfDOSpa+Lmrek7yBHYELqdlnsdAscOzyhOfWSKdmBrTkHEeAV5ZIzjFV8VbsXMmHlDQzPOh5nwchPQpbPwYWRCZLhDNMuEQmqijFyU2jqh05rjyXO6h4tx4CTOk7fhO4LMS1Uk4kLsJlE7uUQkwSeEX94MRc6YQZX1YMUVXIqOgxeTmpnOZg2C0o0XCWQZvOYsREoCfN+NhKUNl47g5oTn9tFOnVeu5d1e5c0eTpnucG9RgCXY+QOFJu4UuBHf+yez2bCDhFwaRtcxGLOZJlRJ0+/nmNKvjoWyetbHycHNc1kM3eZQlMQBRi7uHOMdXGmObES4wRXeqZpcTpKIbPc88vEIYwbaQiuMtOJ3WLO4v4K3nYe8LUBIMUE9xAiB7PNe4TlBaANhQkx1/Q1cauLd5+RGzasSCJ2rbifvZW Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 76ce8a86-f218-446f-0afe-08d7fc90a6bb X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2020 07:37:29.7881 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xWJOP/P06OEAfXxrScYyH0ROJhYIu8edYooCPgvWiItHn8Yspq8EzldJP2iJOO8PiTgUHQw5sQYEs12lWBqETg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2821 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow FDIR enable issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhao1, Wei > Sent: Wednesday, May 20, 2020 1:13 PM > To: Xing, Beilei ; dev@dpdk.org > Cc: stable@dpdk.org; Guo, Jia > Subject: RE: [PATCH] net/i40e: fix flow FDIR enable issue >=20 >=20 >=20 > > -----Original Message----- > > From: Xing, Beilei > > Sent: Wednesday, May 20, 2020 12:14 PM > > To: Zhao1, Wei ; dev@dpdk.org > > Cc: stable@dpdk.org; Guo, Jia > > Subject: RE: [PATCH] net/i40e: fix flow FDIR enable issue > > > > > > > > > -----Original Message----- > > > From: Zhao1, Wei > > > Sent: Tuesday, May 19, 2020 3:17 PM > > > To: dev@dpdk.org > > > Cc: stable@dpdk.org; Xing, Beilei ; Guo, Jia > > > ; Zhao1, Wei > > > Subject: [PATCH] net/i40e: fix flow FDIR enable issue > > > > > > When we flush flow FDIR, all queues are disabled for FDIR. > > > If FDIR rule is created again, then the flow list is empty, as it is > > > the first time to create rule after flush fdir filter, so we need to > > > enable FDRI for all queues. And also, disable FDIR for queues should > > > be done in function i40e_flow_flush_fdir_filter(). > > > > > > Cc: stable@dpdk.org > > > Fixes: 1491f63c7559 ("net/i40e: fix flush of flow director filter") > > > Fixes: 6ae9b2b5e8c2 ("net/i40e: cache flow director enable value in > > > Rx > > > queue") > > > > > > Signed-off-by: Wei Zhao > > > --- > > > drivers/net/i40e/i40e_flow.c | 12 +++++++++--- > > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > > b/drivers/net/i40e/i40e_flow.c index > > > 25c77e7aa..94fc73092 100644 > > > --- a/drivers/net/i40e/i40e_flow.c > > > +++ b/drivers/net/i40e/i40e_flow.c > > > @@ -3462,6 +3462,12 @@ i40e_flow_parse_fdir_filter(struct > > > rte_eth_dev *dev, > > > } > > > } > > > > > > + /* If the flow list is empty, it is the first time to create > > > + * rule after flush fdir filter, so enable fdir. > > > + */ > > > + if (TAILQ_EMPTY(&pf->fdir.fdir_list)) > > > + i40e_fdir_rx_proc_enable(dev, 1); > > > + > > > > i40e_fdir_rx_proc_enable is called in i40e_fdir_configure, so could > > you check if we can optimize this and if statement (pf->fdir.fdir_vsi = =3D=3D NULL) > above? >=20 > No, when "flow flush 0", the pf->fdir.fdir_vs is not NULL, but list pf- > >fdir.fdir_list is empty. Then seems i40e_fdir_rx_proc_enable(dev, 1) can be removed from i40e_fdir_c= onfigure, since i40e_fdir_rx_proc_enable(dev, 1) will always be called when= the first FDIR rule is created and fdir_list is empty. Or we can use 'else if (TAILQ_EMPTY(&pf->fdir.fdir_list))' to avoid duplica= te execution of i40e_fdir_rx_proc_enable(dev, 1). >=20 > > > > > return 0; > > > err: > > > i40e_fdir_teardown(pf); > > > @@ -5330,9 +5336,6 @@ i40e_flow_flush(struct rte_eth_dev *dev, > > > struct rte_flow_error *error) > > > return -rte_errno; > > > } > > > > > > - /* Disable FDIR processing as all FDIR rules are now flushed */ > > > - i40e_fdir_rx_proc_enable(dev, 0); > > > - > > > return ret; > > > } > > > > > > @@ -5368,6 +5371,9 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf) > > > for (pctype =3D I40E_FILTER_PCTYPE_NONF_IPV4_UDP; > > > pctype <=3D I40E_FILTER_PCTYPE_L2_PAYLOAD; pctype++) > > > pf->fdir.inset_flag[pctype] =3D 0; > > > + > > > + /* Disable FDIR processing as all FDIR rules are now flushed > */ > > > + i40e_fdir_rx_proc_enable(dev, 0); > > > } > > > > > > return ret; > > > -- > > > 2.19.1