From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 619E9A034F; Wed, 13 May 2020 14:45:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2735E1D58A; Wed, 13 May 2020 14:45:37 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D246B1D588 for ; Wed, 13 May 2020 14:45:34 +0200 (CEST) IronPort-SDR: cd/gPrk2/BiNl6Itoxr4ijfcjNCdr3CpZDd4sLw95thjijy422mhARKJiLHjAIMm70OKyvLxp0 zm4pu2P9Q0wg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 05:45:33 -0700 IronPort-SDR: h8jTP9aVkSPNhjyMiJHdyTU+SNH1633Kp/8qdwQVlcQV9aw2RWmT7LTsvE0cEZsLG17sWSdKDg LlYSMpYJAc/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,387,1583222400"; d="scan'208";a="251240305" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga007.jf.intel.com with ESMTP; 13 May 2020 05:45:33 -0700 Received: from orsmsx111.amr.corp.intel.com (10.22.240.12) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 05:45:33 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX111.amr.corp.intel.com (10.22.240.12) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 05:45:33 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 05:45:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=liNS1mUIDerLqPMcjWCYZKqQh9GUC5KhRpw9405a62UtaTYqAcTM8joUI8rDa3vOurfGEhJdoSOY78YO/K/EXVwxd3O2j3CyhW9Dxv5tSV3gpkpJe9og91PF8JyoMo/myV0KWEsIbeThpJiMtzqcNbcAxZBsexvGt9hcdBQu8MUqVnvEjzv5kzM6SLKbEPYC6RMfRUI5HcNyVIO8RfDILvHX99poc0wR85ugF9bmHMIGyQ7vjFERsdxwitKQMoF9XtpEc50tb81mWTW5BwONdSspZmana8XB33yf0Kq3TcGMgQRS2TRKdEq7wUwEDa84KjBE2ceDQbShAijDmFMimw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/OF4lKHQwdRExDSzMxRW4i583Fm0T1fyOO8ZCcvPa4M=; b=QX6LRlHcPzc4CSvG7sMl5YlAJlInkH7Z1YzijRKGOhFBaPEpeEfuWWE0YY8OYhT2PkWm+VYboSPF+M253zScmnS2tzEbVlWDlY010DA6X0zgbeomqQs7LnNtCJ5UrFd/eoH9YCtOB/ys4BZcKzsD78/Cx9fhrZ5fV5F8ioi9VI/hJ6+kkpbYKjtKPVYor+WxEy9XxyL3/XLakrOvi5AetvOcaZHTk70k/ZF3mqlLmb/a0l2Ka6cLJo9wzqCPu1gAIqbM8Kk+/jsTNM24h2qRSuaOEMINAp/eyUaZeuR2SVEv4UhLwhr1u1s/A5kQ6EdMb0ulZKfZXEJoEk+isUAaIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/OF4lKHQwdRExDSzMxRW4i583Fm0T1fyOO8ZCcvPa4M=; b=WEH4lsR3vSvlyP5MAEE8bu+Nx8Tj2F7ktF1FJi3vPE8yhoFJRpr8nEJ3ukL7XFEI1givw74LxmdtuSpw5Lcc4CfjAQxO67NcsB0cMHOsip9riiwK28BG+M3+ftqGf1iJ3pj83fv4lgYo8xyfShVdIYXfIFkbKIioDW5puRvjSQU= Received: from BYAPR11MB3671.namprd11.prod.outlook.com (2603:10b6:a03:b3::15) by BYAPR11MB3365.namprd11.prod.outlook.com (2603:10b6:a03:7e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Wed, 13 May 2020 12:45:32 +0000 Received: from BYAPR11MB3671.namprd11.prod.outlook.com ([fe80::8d8:1f11:6235:ee03]) by BYAPR11MB3671.namprd11.prod.outlook.com ([fe80::8d8:1f11:6235:ee03%6]) with mapi id 15.20.2979.033; Wed, 13 May 2020 12:45:31 +0000 From: "Mcnamara, John" To: "Dumitrescu, Cristian" CC: "dev@dpdk.org" , "Singh, Jasvinder" Thread-Topic: [dpdk-dev] [PATCH] net/softnic: fix resource leak Thread-Index: AQHWHJzKwEB3oj30n0K5DwTUVdWjaaimDymg Date: Wed, 13 May 2020 12:45:31 +0000 Message-ID: References: <20200427140325.83191-1-jasvinder.singh@intel.com> In-Reply-To: <20200427140325.83191-1-jasvinder.singh@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.40.58.144] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d50efcef-3199-4d7e-d695-08d7f73b8606 x-ms-traffictypediagnostic: BYAPR11MB3365: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-forefront-prvs: 0402872DA1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B85A/K7twSPknC9p3UNNBImwq0e92rMU7uOtOIHC8noe/xjt3hd2XE3dTvqyrsJcblS87J6NOn5NKDLkv9VOpVbo+qWuO1HpLHvY1Dw7mYyokGUv3i35+ZUu1ytaY8fxrIubjKWLIadXeDgvB84tOjNQOAUNE8ccMnTOBewraT94ojZbzSCvdLyvpwkRE/DbSYNZJGmlDlVkz1T+Uuap/2nF27vQrx1RzSivQPomH2UkIqqXlVejlhMM3Go2MqBXThtTJ3nBhxFKUgRFg93SYDKq3JbUyQpLZgalyVpz1ViLYxJBMVsJEsK6I6vJABqk1Xe4JiTnhnIFwVMhk/6T2feJP5nvkVO051YoGvUSijNwBj4FQYhILDNJlowIOBzAy2sHA+rWdrc8I2bVQG6Tqk5HpAY8xvsGdef56kZCoKPjRPUwPdP1sdFuNuofFXR4bTKtbbcOgpYCoeHsMDZbERdakUt7cbnNPYBZ1XtvA8MDyqD7AkCbuo1X0sxSmDfXPoyHgQNcn+G4VaFwIi0CdQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3671.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(39860400002)(376002)(366004)(346002)(136003)(33430700001)(6636002)(9686003)(7696005)(86362001)(76116006)(66556008)(66946007)(66476007)(5660300002)(64756008)(52536014)(186003)(54906003)(6862004)(8676002)(66446008)(55016002)(2906002)(4326008)(53546011)(71200400001)(4744005)(33656002)(107886003)(6506007)(478600001)(26005)(8936002)(33440700001)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: bi5FaHJO0rjYdFA7eGZyb7+bAPfpMeMdlEbtJXFa/ZRzXUEhjUt1XK/XH90O/FMD2xrnY1t1ZOIesRG60KDwACpJ6F21V/KTtrDwR5ogAqZh9Guro9YBQRGzPjDxGMYfk3xQpSA3QkFqC16gVzCFbwwJNxyXEBl87UXZjqgHBiXTUBNyMvypTKAJZbm1qDLn74hCpngTg0wEv/EBFhskcbm1f75lXZSaX3fty/QHLYsrGQCTIlEBVfYmOFBpJiBMWpsONAAu/ZNw5zrjrEeWnxww3gHnuXPJT2uTkmEWEYI3c2+jKPEejZA8rWNIdqMlhfvGelAzHucI2tJid8uottrdzcwYS1a1B6YJsAQ+cLH75Wy41gB0kVKSQmvRrBNwaO4WqeEXGhN7S4YnhXQUsYwW+KpM8pwEOVHYmgsFe/BgPpsEDBeyb+UpfrDlBQWdGQVLj5v6uM06diqRfhjMwxpJfTdOeBX4M7DKOnvA3nM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d50efcef-3199-4d7e-d695-08d7f73b8606 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 12:45:31.8571 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wXXGanYPyBVu7T8MrT+4SELNW3Wb0pGknbcA2UpCcceIYJ5DRCMtvWbrgo3LKx2Rd/DSKm05bLxxhcU3ZMKI4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3365 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/softnic: fix resource leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Jasvinder Singh > Sent: Monday, April 27, 2020 3:03 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [dpdk-dev] [PATCH] net/softnic: fix resource leak >=20 > When sending request messages to data plane pipelines, the caller must > free the memory allocated to request message on receiving error response. >=20 > Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711, > 357722, 357725, 357734, 357739, 357743, 357747,357762, 357766, 357787 >=20 > Fixes: 6d4d05402501 ("net/softnic: add command to read stats") > Fixes: 202905f3ee4d ("net/softnic: add command to create objects") > Fixes: ee19326a4b1e ("net/softnic: add command for pipeline table > entries") > Fixes: 9bc0ce0ad17c ("net/softnic: add command for meter action") > Fixes: 2505030a8383 ("net/softnic: add command for TTL action") >=20 > Signed-off-by: Jasvinder Singh Cristian, Can you merge this and other Coverity fixes. They need to be cleared for DP= DK 20.05. John