From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD583A0526; Thu, 23 Jul 2020 08:17:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9AC001BFDA; Thu, 23 Jul 2020 08:17:08 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7D1F31BFD7 for ; Thu, 23 Jul 2020 08:17:06 +0200 (CEST) IronPort-SDR: 2JkqMdM8COWjSC+3D9jJp1yDE7q7nPsn8+nzwboPoryJGew2Zpds3NN7cMJMSa5jI46swRK1sO gZ418GfdC70w== X-IronPort-AV: E=McAfee;i="6000,8403,9690"; a="150456163" X-IronPort-AV: E=Sophos;i="5.75,385,1589266800"; d="scan'208";a="150456163" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2020 23:17:05 -0700 IronPort-SDR: zb3SgtuC4dyKsK9OZPfOvgagvLuYeA5TztGJUBCyuzbpY8eNIm2atRIGqU+H4YDX+IC/fKhGZl agRLasUOr+xw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,385,1589266800"; d="scan'208";a="302197952" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 22 Jul 2020 23:17:05 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 22 Jul 2020 23:17:05 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 22 Jul 2020 23:17:05 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Jul 2020 23:17:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VGzfSeYLhCmodueHq+GkrlMRryNSwDMmaL4R9JJ/dTqu6mA7VgYLxWiTxg7N40dubXnql9uyl2TLKVxxZuocVY8TZRcBZ3xh/1nlwv41sivSnmoUh2bfCnX/Bl648kGxH0+WDXhnEOSVrPtMFKbuI8mEJYGypcG1QDicl1IFWvHL7ngjb1WIDhcY0jwWiX4MejOWJnWM6EWN/C/I8uxVwLdZM1l6dU3TVMZtxBXCZZqYhHHcYXyxEF97eo6yzfs/lThn4dYiF1TQU7N1iLVpC3ntrvK/PRwoLnTyf0XkWBVyG+ae4KHyZRFuWtHesy0mJogQ2segbjGd0M73U2bqZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xdfp87o3xHHUGY06EpHO+028Dnd1z9nnrjRz86qUbB8=; b=QIKKgUoBqbaY2xhRZ4OHPXqQlER1GvODP8B9f/YyDW9atQAzTyow3+C8W3Vg5BuWPJScuXPISWJbq/os5zngt3hqSk/9J0cLYXssa40jb1hshRQ7ed2Uyd94dhqeNusjUu0BcNj4+ojm5/57o7IeGm2LPMS2/mXN3E9afWd7QOZnCIVyjA4YW4LBWIrCIjHe6zEqJq/W0wZ4HbcU5iNjN/Y8QlP3po8myBqffgowV2SVIQqtYrdHy73jypgqjLCwe+4F5vt3ps+btiyk02YaQoQ1Jpvdl4U+xkwpzNnlxaDbPL42GYcCjYOY2g8LOhoUtJTw9joPaNZvl6/l7q+Onw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xdfp87o3xHHUGY06EpHO+028Dnd1z9nnrjRz86qUbB8=; b=dNSM+N+p3Z4ZkLfJR4bO/48OLYR3ONipdaekArkZWe2GcRxnPofymyIK+rV9ziiuljTmweI4Z0PJr8kLc9yoicsQkws9lTBL9oNd41IOY3IjfUu2m6+VJizDuzD6IO7QqhYbvNsgVDPY6CKDl9W1tMqv/lqhDNuQ0cWvqT95vcM= Received: from BYAPR11MB3735.namprd11.prod.outlook.com (2603:10b6:a03:b4::31) by BY5PR11MB3861.namprd11.prod.outlook.com (2603:10b6:a03:18d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.24; Thu, 23 Jul 2020 06:17:03 +0000 Received: from BYAPR11MB3735.namprd11.prod.outlook.com ([fe80::2571:24e3:140b:d78c]) by BYAPR11MB3735.namprd11.prod.outlook.com ([fe80::2571:24e3:140b:d78c%7]) with mapi id 15.20.3216.020; Thu, 23 Jul 2020 06:17:03 +0000 From: "Fu, Patrick" To: "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "Xia, Chenbo" Thread-Topic: [PATCH v1] vhost: fix vring disable fail in async transfer Thread-Index: AQHWYLPNHWgrkk0TO0SBKY57U6Zw7KkUr34w Date: Thu, 23 Jul 2020 06:17:03 +0000 Message-ID: References: <20200723053801.3616928-1-patrick.fu@intel.com> In-Reply-To: <20200723053801.3616928-1-patrick.fu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b3063f6-0648-4b20-80b0-08d82ed00483 x-ms-traffictypediagnostic: BY5PR11MB3861: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UM+SvTOY5iDK44VL0huOBXtvUJfzqpmHDQ20pXKQZJpzWCBXmeu7auPkG9kDRHE1dvHB2VeEz9FdR1xmHgljXTxcuI0a3l2xZSckOMeRR3giLofeYlrAM0UVKJ5TDPSGulHynrTLJ8ckq1ZZdj6OkAHJqA/Yqusl5Bcc/7+0SYVNCG6Yo/+4ftd07i8iNa96xbuM8/pVVgtgtWn59WqkcVKVLGXoezM5IqaA8uX7Tj/iMUsludb/tMKnoNZcVHIajfF/TiInjikHTxbFrobYTDzdEp4A0FlMJGHmWYZsD2o8i/IgZLNebFmtc+OVnJa1zx7KoJ8tbl5JdjK9/3P0hQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3735.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(136003)(366004)(39860400002)(396003)(52536014)(8936002)(76116006)(53546011)(186003)(5660300002)(6506007)(66946007)(2906002)(64756008)(86362001)(66556008)(66476007)(8676002)(110136005)(316002)(66446008)(6636002)(9686003)(7696005)(478600001)(83380400001)(26005)(33656002)(55016002)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: yjlHM7s6hYaMoJjbTKLECLocK6YHO7R7N1sHql7NS20lF/Tpwf95RrlogO5V87h9bkH1Cw347f/9lLgEIcIyjAqtbqqWjRW9M4udu97D7KsUMYOB906TejZw7FypwHP8KkTGNFX3gW58rpptj8UWOHO/OyXNQ0vzv2vGg+m2Lo0RqNvTaOM+7RZHNkVP/Rzd1AYb8/gGEI9hCfKS9Ak/+6RQsotVVJeWXUfBtJ5Rprgg81+GdJq8d1dFv1TEoCLTFRI9QSjKZ/tyEz2FqDE8a7rhUdQm1aCqzJpKemDiGDdSAbWmVQBQzPus5v0zXvxJ79m+T23TdMmIfY60cW/Ukt9sasnZ9addxBwHmqy9D/m13AOorXQSlIeKJ+RneBBNVXMWV/W44CNE805RNnAy9/P/u6JHAxAEZslWyWrqpLI7xmJ85WpL0+ADn3rysUw//Fs40wrHVvcT0RGSEoZ15s7ao1v2BTZFeqUPhpxFh5G3SWaOfTJUwZpLooEqh3VX Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3735.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b3063f6-0648-4b20-80b0-08d82ed00483 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2020 06:17:03.4988 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7/YjyQveijLhTFsR5oiAYw1juKa6kyZ+JvaR8vX+6Y8NnoMCEQ/0Ut40ZPeJr/ZjpjuYGDt41aVqRxD5GfyJgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3861 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] vhost: fix vring disable fail in async transfer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Sorry but I'd like to withdraw this patch as the issue could be addressed b= y applications to register a pre_msg_handler. Thanks, Patrick > -----Original Message----- > From: Fu, Patrick > Sent: Thursday, July 23, 2020 1:38 PM > To: dev@dpdk.org; maxime.coquelin@redhat.com; Xia, Chenbo > > Cc: Fu, Patrick > Subject: [PATCH v1] vhost: fix vring disable fail in async transfer >=20 > From: Patrick Fu >=20 > Async inflight packets is checked when front end virtio requests to disab= le > vring. If inflight packets exists, vring disabling will fail. > However, there is no good way for application to get notified before vrin= g is > disabled and properly complete inflight packets. This patch moves the inf= light > packets check from vring disabling time to the vring enabling time, so th= at > applications have chances to drain out pending packets. >=20 > Fixes: 78639d54563a ("vhost: introduce async enqueue registration API") >=20 > Signed-off-by: Patrick Fu > --- > lib/librte_vhost/vhost_user.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.= c > index 9ddeae362..36da1380a 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -2038,9 +2038,9 @@ vhost_user_set_vring_enable(struct virtio_net > **pdev, > "set queue enable: %d to qp idx: %d\n", > enable, index); >=20 > - if (!enable && dev->virtqueue[index]->async_registered) { > + if (enable && dev->virtqueue[index]->async_registered) { > if (dev->virtqueue[index]->async_pkts_inflight_n) { > - VHOST_LOG_CONFIG(ERR, "failed to disable vring. " > + VHOST_LOG_CONFIG(ERR, "failed to enable vring. " > "async inflight packets must be completed first\n"); > return RTE_VHOST_MSG_RESULT_ERR; > } > -- > 2.18.4