From: "Ferriter, Cian" <cian.ferriter@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/pcap: fix byte stats for drop Tx
Date: Thu, 4 Feb 2021 16:24:40 +0000 [thread overview]
Message-ID: <BYAPR11MB375171D0B9A0E6A0B7DA5D23EDB39@BYAPR11MB3751.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BYAPR11MB3751815728FB312F11BF4FC7EDB39@BYAPR11MB3751.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Ferriter, Cian
> Sent: Thursday 4 February 2021 15:48
> To: Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH] net/pcap: fix byte stats for drop Tx
>
>
>
> > -----Original Message-----
> > From: Yigit, Ferruh <ferruh.yigit@intel.com>
> > Sent: Wednesday 3 February 2021 17:30
> > To: Ferriter, Cian <cian.ferriter@intel.com>
> > Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org;
> stable@dpdk.org
> > Subject: [PATCH] net/pcap: fix byte stats for drop Tx
> >
> > Drop Tx path in pcap is Tx that just drops the packets, which is used
> > for the case only Rx from a pcap file is requested/matters.
> >
> > The byte stats was calculated using first mbuf segment, which gives
> > wrong values for multi segmented mbufs, updated to use packet length
> > instead.
> >
> > Bugzilla ID: 597
> > Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Cian Ferriter <cian.ferriter@intel.com>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
>
> Acked-by: Cian Ferriter <cian.ferriter@intel.com>
>
> Tested this with 2 large PCAPs and it works as expected:
>
> testpmd> show port stats all
>
> ######################## NIC statistics for port 0
> ########################
> RX-packets: 2 RX-missed: 0 RX-bytes: 131070
> RX-errors: 0
> RX-nombuf: 0
> TX-packets: 2 TX-errors: 0 TX-bytes: 131070
>
> Throughput (since last show)
> Rx-pps: 0 Rx-bps: 0
> Tx-pps: 0 Tx-bps: 0
>
> ##########################################################
> ##################
[Cian Ferriter]
Just to clarify, the Testpmd CMD used to get the stats I pasted above is:
dpdk-testpmd -l 1,2 -w 0:00.0 --vdev net_pcap0,rx_pcap=/root/udp_2_max_jumbo.pcap -- --no-flush-rx --i
This means that tx_drop was enabled because no tx_pcap file was passed to the PCAP PMD as an arg.
next prev parent reply other threads:[~2021-02-04 16:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 17:30 Ferruh Yigit
2021-02-04 15:47 ` Ferriter, Cian
2021-02-04 16:24 ` Ferriter, Cian [this message]
2021-02-04 16:40 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB375171D0B9A0E6A0B7DA5D23EDB39@BYAPR11MB3751.namprd11.prod.outlook.com \
--to=cian.ferriter@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).