From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 452DEA0524; Thu, 4 Feb 2021 17:24:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BCCB2406A8; Thu, 4 Feb 2021 17:24:50 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id CE87024069C; Thu, 4 Feb 2021 17:24:47 +0100 (CET) IronPort-SDR: GurcfYLJpUoGfoUiS+GFEsWKqZz8SLKDTcHLBeGyN1UBhh5khsxzYtCcL+kXcP3Qhux+0Ots90 u6dN7Wso/3VQ== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="160436998" X-IronPort-AV: E=Sophos;i="5.79,401,1602572400"; d="scan'208";a="160436998" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 08:24:46 -0800 IronPort-SDR: uMXSrogjd8gUG/eJUD8LlnLi0UuWeMnWLrn4r4DBLMga6YO/a/fQQ78SS8+mU7bVAFSU+yrp9E Yg6/n6rk6wAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,401,1602572400"; d="scan'208";a="415423938" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga002.fm.intel.com with ESMTP; 04 Feb 2021 08:24:45 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 4 Feb 2021 08:24:45 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 4 Feb 2021 08:24:44 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 4 Feb 2021 08:24:44 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 4 Feb 2021 08:24:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g5asWbYR2bBYvruRbLPF0gEtWboi0Zpn8cCeK73IRMiVPuXccFrSwYUBpMzD+rYaHqagY1M+SARk3Wu0U0ckETN2vBBOJ5xTdP7KSfnBUDtr0c6VMnTR6aqMbFLw3rjEfbXSqqDrzY74ZgWuSs3kecblObrUDHksiyVCKUKCO7YUzat+eKaClNmffiBmZqICA5yBhgPnizAviw9VMLbITHkEgyLzKqs0ZifbvWa3rQ0tsDdNhBUAdlGzjitl5K7w01U0v4PvVoASnUDnY6ZQTgoP6Yyh/ijH78urCvi13v2t1hVaMaM9pi4NnaB6u9cEIMEXdXElWqDOjlJEehr5jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1eAzNWs/3hULanP9YdVm4IB0fIqC/0sivVK19pNiZdo=; b=ZCottxHXgKMtdJnSD5Kk58S88GyV++UV8Vn5w1L8NwmGn7zZRkK6QM4+uetA++D6SM+u6OFfw6ie5DTBKnv9VZnPLwuSQJlhJL7ywUejec+L6cMo28jBEp2TGp9UGa5N+m6PGncYdYkIuuW7N8b21N0+Iph0fDhpX7RyBRSLcbMD6GpZDo2/63q62Hgy6FhPe5L4FUBH1rVIsZRNLIUdC5a4z7jdFzM6NyOjVYjl3r7uRf4CFIGe3gLZwP0ZFbAVq3kARlDtHM5QXg/CCDNooszTQRmuNEkgoQnn/PAIeExXUILFVPfEtJcN05vQNaoS5IDOovgt9JR5ioEsbxTXpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1eAzNWs/3hULanP9YdVm4IB0fIqC/0sivVK19pNiZdo=; b=oP4+AKrnQ52BxzsJjUDvJY91MfmckMgQ9EdTIJ3FV3ekVEwaNN4chhJPcKSysTDrVYxnyXF+wQNFCNqAAEKL/SH5f3Wamj+0bepFVDu3eznlZU8BcoWRHOL4zMMTJ0B3T+NLrBUU+omXi5mp1OnnZziKSkoO73BKXoHbD0EdsfY= Received: from BYAPR11MB3751.namprd11.prod.outlook.com (2603:10b6:a03:f8::31) by BY5PR11MB4337.namprd11.prod.outlook.com (2603:10b6:a03:1c1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.17; Thu, 4 Feb 2021 16:24:41 +0000 Received: from BYAPR11MB3751.namprd11.prod.outlook.com ([fe80::31bb:895e:6e93:7e9d]) by BYAPR11MB3751.namprd11.prod.outlook.com ([fe80::31bb:895e:6e93:7e9d%7]) with mapi id 15.20.3805.026; Thu, 4 Feb 2021 16:24:40 +0000 From: "Ferriter, Cian" To: "Yigit, Ferruh" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/pcap: fix byte stats for drop Tx Thread-Index: AQHW+lJYluPJvgQ8xEmotezr1v4pdapIJOjAgAAH9xA= Date: Thu, 4 Feb 2021 16:24:40 +0000 Message-ID: References: <20210203173025.2786063-1-ferruh.yigit@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [37.228.234.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 21a41f27-cabb-4f0d-f6e5-08d8c9295fbb x-ms-traffictypediagnostic: BY5PR11MB4337: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fDFt/lkVoULQPhtUAYDyj8LEGeeaVb8KOqI61petQRmiyTE8KVAsDHBKq0xUSHuDfd0bylYszKz2eKS5VAygKrMFDUWa4rp2kmao3nZnIu/Uv7OZ19PzoMAcEGEanOt2lWcqJS6H0CDQHZMOst66PaGHsoRQfH5zplbuqZZl2VdJ3Wja+W8OqWjrn+H8PqFrFwz3zB3LKJMeekLkVXClKH5co6zGIU8IpWfkOxKyyp/43Gw+URkTxrofoGpkZbicqs173HPlp+gkwGleHEOXjMO1EGZF+QfBB2g5s6dLGQZI1rRBjXcYuxfuWOR0mpubKuW7zhinBhuNaDUbYQHuHYul/SoCy+pqCfiREP+0WPshg7Pph5Q2L/c9Yb5g5X9+QG4t5FUH2HxZnzYxpx0jstZk4m6SB/5p2VCF1xAXOLBCp/B9+awQeUvMvTO2LVndut6L9R4C+PoiKwF7MSLSrZ6wRGRWF4nzNr9PuWD5KTW/8rZTuL871ESM5hw7GX4F/FWnTFaySE7rbiJlCz4vlg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3751.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(366004)(136003)(346002)(396003)(376002)(33656002)(2940100002)(52536014)(66946007)(53546011)(6506007)(86362001)(2906002)(316002)(8936002)(7696005)(26005)(6862004)(55016002)(64756008)(76116006)(5660300002)(6636002)(83380400001)(186003)(478600001)(71200400001)(9686003)(450100002)(54906003)(66446008)(8676002)(4326008)(66556008)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?rAz0PLKjZAC7PhNEWtWHF1kEqyztSySxS4TbB/MaTuMcOaJWLxIwaUZPzCT5?= =?us-ascii?Q?+0F7eH9Yt5l6PE6TvHz/fAXjg5h8koMEE6UdFDcfEuxw4amlkNBIL9/pMAPm?= =?us-ascii?Q?3dhXtXfkttOVJA0IhBCIWafkECQ+c/SctJlBGGFE1WK78Q45nMoa2jT54jjc?= =?us-ascii?Q?LYAMD+bVqqmE5hoNVV3iaGttByhTR3hZdLP7U7aAT2fSxwnA7ssgaIEawL/b?= =?us-ascii?Q?JUnY6Q+uExHJ9rKpzwp1f+WT3RJDycuvAZgJazT8LSscaOXiTrRWKigxfE0B?= =?us-ascii?Q?Fv8g+PNeA5oG0srOB5mXcOjOV9iWhzAfcI/tLNsjl/sJ/F9108ABl3pp6c6M?= =?us-ascii?Q?oJhnBcQ+lCSQk/JeO/BEsPLD8NCZIrlSISSv2FExdLrKlQqGThEasLT1I1eI?= =?us-ascii?Q?iR9TTM1LncF0FPcCBStv9T/tI7oDqQq1RFqGD6d367EvErqUzeJ8GtdJ0eJn?= =?us-ascii?Q?wap1j+mWje7L37hpc5c4x3GOwlMoe+bY8cLD3vN4DL6yP83YiKHf+8MxvZTL?= =?us-ascii?Q?OagzdHF9HoRRgi82ed7umPWl+v73FchgnZQswJr+FJrKdC3MCnn1eTjTOjI6?= =?us-ascii?Q?Imp/CugiI9jx5UpTzCT6rvvyDrqTqc2Kqbxv7j5P7+4uK2sHq3yzqargAncE?= =?us-ascii?Q?pF17rZ379TFVe+XgzaYvUFGRIFayr8jSaOjEnoOttaP0RVgiSSw++RyryLsT?= =?us-ascii?Q?f1c3ftmqcf9JDbrdpI7zgKHiPaoXdwgGGpAqeojBH69qNPQLT1DOpLUK9uHL?= =?us-ascii?Q?yAs0kc3HdfeBdrFkpIhiTIoC4DQxwBDA4DFkjBmOP5W6yeLF5JVVdSK66Eud?= =?us-ascii?Q?CrcGDQCdLxDHs/uzqd69IA7YQt08+tkNblBUQfIW0NUN8p9DaSrCcKkMvKpd?= =?us-ascii?Q?mp8hzRhKkXFQ/TeEIWGTb3Q27eCXNcwVwcndQo3DoCwbeWD4PqQ8eC5Wsitj?= =?us-ascii?Q?indeBlEdPL8dBiJxykC1XKPEvR/5QVObhnF1f5Lk/kh0eQpsCY46ATy4/MeG?= =?us-ascii?Q?+eVbw3F2wxsN7M8bmMbu2rPM+5vzVhFPfPFMI2/hNZ0cjexODmdKIbuOtML6?= =?us-ascii?Q?6XXzxdNQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3751.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21a41f27-cabb-4f0d-f6e5-08d8c9295fbb X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2021 16:24:40.8901 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WUSrza70D1MS3Aac0OlER70fAwEB13dpAH4+24GMCLGI5rbQ360SP3kn0OTegXw/xn4fzmKu1Le39H4/2Fbnhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4337 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/pcap: fix byte stats for drop Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ferriter, Cian > Sent: Thursday 4 February 2021 15:48 > To: Yigit, Ferruh > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] net/pcap: fix byte stats for drop Tx >=20 >=20 >=20 > > -----Original Message----- > > From: Yigit, Ferruh > > Sent: Wednesday 3 February 2021 17:30 > > To: Ferriter, Cian > > Cc: Yigit, Ferruh ; dev@dpdk.org; > stable@dpdk.org > > Subject: [PATCH] net/pcap: fix byte stats for drop Tx > > > > Drop Tx path in pcap is Tx that just drops the packets, which is used > > for the case only Rx from a pcap file is requested/matters. > > > > The byte stats was calculated using first mbuf segment, which gives > > wrong values for multi segmented mbufs, updated to use packet length > > instead. > > > > Bugzilla ID: 597 > > Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file") > > Cc: stable@dpdk.org > > > > Reported-by: Cian Ferriter > > Signed-off-by: Ferruh Yigit > > --- >=20 > Acked-by: Cian Ferriter >=20 > Tested this with 2 large PCAPs and it works as expected: >=20 > testpmd> show port stats all >=20 > ######################## NIC statistics for port 0 > ######################## > RX-packets: 2 RX-missed: 0 RX-bytes: 131070 > RX-errors: 0 > RX-nombuf: 0 > TX-packets: 2 TX-errors: 0 TX-bytes: 131070 >=20 > Throughput (since last show) > Rx-pps: 0 Rx-bps: 0 > Tx-pps: 0 Tx-bps: 0 >=20 > ########################################################## > ################## [Cian Ferriter]=20 Just to clarify, the Testpmd CMD used to get the stats I pasted above is: dpdk-testpmd -l 1,2 -w 0:00.0 --vdev net_pcap0,rx_pcap=3D/root/udp_2_max_ju= mbo.pcap -- --no-flush-rx --i This means that tx_drop was enabled because no tx_pcap file was passed to t= he PCAP PMD as an arg.