DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: Qiming Chen <chenqiming_huawei@163.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix mac resourece leak
Date: Wed, 1 Sep 2021 06:25:57 +0000	[thread overview]
Message-ID: <BYAPR11MB380063C9FAB8026BDA7FC086F7CD9@BYAPR11MB3800.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210831142131.9295-1-chenqiming_huawei@163.com>

> -----Original Message-----
> From: Qiming Chen <chenqiming_huawei@163.com>
> Sent: Tuesday, August 31, 2021 22:22
> To: dev@dpdk.org
> Cc: Wang, Haiyue <haiyue.wang@intel.com>; Qiming Chen <chenqiming_huawei@163.com>; stable@dpdk.org
> Subject: [PATCH v2] net/ixgbe: fix mac resourece leak
> 
> In the eth_ixgbevf_dev_init and eth_ixgbe_dev_init functions, memory is
> allocated for the MAC address, and the address is stored in the
> eth_dev->data->mac_addrs member variable. If the subsequent function is
> abnormal, you need to use the rte_free function to release the MAC
> address memory.
> 
> Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/")

Use this tag:
Fixes: af75078fece3 ("first public release")

Also, your ixgbe series fixes can be into patch set, no need to
send them one by one.

Thanks for your effort. ;-)

> Cc: stable@dpdk.org
> 
> Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
> ---
> v2:
>   Clear coding style warning.
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 7d3a821300..6a91f104e1 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -1218,6 +1218,8 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
>  		PMD_INIT_LOG(ERR,
>  			     "Failed to allocate %d bytes needed to store MAC addresses",
>  			     RTE_ETHER_ADDR_LEN * IXGBE_VMDQ_NUM_UC_MAC);
> +		rte_free(eth_dev->data->mac_addrs);
> +		eth_dev->data->mac_addrs = NULL;
>  		return -ENOMEM;
>  	}
> 
> @@ -1672,6 +1674,8 @@ eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev)
> 
>  	default:
>  		PMD_INIT_LOG(ERR, "VF Initialization Failure: %d", diag);
> +		rte_free(eth_dev->data->mac_addrs);
> +		eth_dev->data->mac_addrs = NULL;
>  		return -EIO;
>  	}
> 
> --
> 2.30.1.windows.1


  reply	other threads:[~2021-09-01  6:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 13:57 [dpdk-dev] [PATCH] " Qiming Chen
2021-08-31 14:21 ` [dpdk-dev] [PATCH v2] " Qiming Chen
2021-09-01  6:25   ` Wang, Haiyue [this message]
2021-09-01  7:26     ` Qiming Chen
2021-09-01  7:12   ` [dpdk-dev] [PATCH v3] " Qiming Chen
2021-09-06  1:25     ` Wang, Haiyue
2021-09-06  1:42       ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB380063C9FAB8026BDA7FC086F7CD9@BYAPR11MB3800.namprd11.prod.outlook.com \
    --to=haiyue.wang@intel.com \
    --cc=chenqiming_huawei@163.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).