Re: [dpdk-dev] [PATCH] app: fix testpmd dependency on jansson

[Gregory Etelson <getelson@nvidia.com>]

Hello David,

Thank you for the update.

Regards,
Gregory

> 
> ext_deps is not used in app/meson.build.
> testpmd currently can be linked because metrics
> library is pulling
> the dependency on libjansson.
> 
> Fixes: 59f3a8acbcdb ("app/testpmd: add flex
> item commands")
> 
> Signed-off-by: David Marchand
> <david.marchand@redhat.com>
> ---
>  app/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/meson.build b/app/meson.build
> index e41a2e3902..986c1a4ad4 100644
> --- a/app/meson.build
> +++ b/app/meson.build
> @@ -61,7 +61,7 @@ foreach app:apps
>              c_args: cflags,
>              link_args: ldflags,
>              link_whole: link_libs,
> -            dependencies: dep_objs,
> +            dependencies: ext_deps + dep_objs,

Reviewed-by: Gregory Etelson <getelson@nvidia.com>

>              include_directories: includes,
>              install_rpath:
> join_paths(get_option('prefix'),
> driver_install_path),
>              install: true)
> --
> 2.23.0