From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35AE9A09E4; Thu, 22 Apr 2021 12:17:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21B3F41CEA; Thu, 22 Apr 2021 12:17:31 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2044.outbound.protection.outlook.com [40.107.93.44]) by mails.dpdk.org (Postfix) with ESMTP id C0EB94003D; Thu, 22 Apr 2021 12:17:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JFyu1exuSPA8XDSJ6dCr1b7ekVTr20gCbyZoGX+Yvd/lj+HZPs/5dSBHihCdibm8Y0qehGSBKT9Nxwjnx/oDYyN7HkStjTgT2Wu//jJ8lw7CrkEkPDJW6dngpSaS9K/sMtgaZ9Y3WUSAJwH7xjBWhNErCM58Ex3JE+YYvXJJtA3DU+YBp2YmA+64liiQHUwdBlZJ3kZZwBc1EhiCN5Nj9bhFjafKR0K6x4MkqQ0QAlShX1GmLLx/xviEf3AyJrLK6VxjjZjcnHDS46nzgcjox348u0bXbeQZCqqk5t7k3K0rdcY7lUsGDzJQAA8tuHjVELCUmIYZQmjT+pwoB+yFEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Js9VvQXnx8ItQ/50BpHKRYc/4edNWU8J+8A+/1nmWAk=; b=IABq0tXbHMFPz92EPMaVnjEw1E2C6WJ6huqdeI3FotmiV4KesNbE4O0vU06KoT45NoRO36d6TwjBEmCfxF4YNUpI4GH2voqGiulMVNdLA+g5c7hFxp51zz6utfvCE7jGQfTEnT1HyFRxnq9RYu4LKldhi+b7WNNvvbnmXj36dTgr5IYv7qn+C6ykK9GM87uw+IQr5rBoGdQcF1mHPuQhAdfRr9UgMGeT6SPcQOF9kAZ+fBGHcjIY7A+iNQXdQJorKjHmMKwvbYpgSgQo9PtKIUg3V/me4FmXXBmUwprk7MHvgCka15sZHHL0Mdb7HJeaJ59946KIYnnSgWJNTkl3Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Js9VvQXnx8ItQ/50BpHKRYc/4edNWU8J+8A+/1nmWAk=; b=S0kRgHQK/wvoizDwb+WmN/MpMWo3SrWGFN2dM5oxargiUTsoyzSt5ilNp7l2f8VTuBNs9ggk8g1irJOpom6QtZxn4Uv5AjbuX4GqMj2iRFuuCSBPmVbyqiC7izc+QCTbuZp3THY7MNB4jP6IwldQpE+PR+/CNsPP5Z/5qiVxVLu4IDhwpkddnVuFjTgOGyH4glApfjjGyQA7G937tktFFF/l9J3WL+B0am9Y7UaQKck3lBYk/YSbJ0K9DDlGzzFhXrRGf9EgKWup45CD8yUIZ9nOQRCZuf9CaNB3bdp5N53GOJiubuOuTrJ6fd72LoRXwLcJQAb6nttrA7cn+eqLEg== Received: from BYAPR12MB2824.namprd12.prod.outlook.com (2603:10b6:a03:97::10) by BY5PR12MB4115.namprd12.prod.outlook.com (2603:10b6:a03:20f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.22; Thu, 22 Apr 2021 10:17:28 +0000 Received: from BYAPR12MB2824.namprd12.prod.outlook.com ([fe80::2d91:5745:468a:191d]) by BYAPR12MB2824.namprd12.prod.outlook.com ([fe80::2d91:5745:468a:191d%6]) with mapi id 15.20.4042.024; Thu, 22 Apr 2021 10:17:28 +0000 From: Odi Assli To: Tal Shnaiderman , "dev@dpdk.org" CC: NBU-Contact-Thomas Monjalon , Matan Azrad , Raslan Darawsheh , Asaf Penso , "stable@dpdk.org" Thread-Topic: [PATCH 1/3] net/mlx5: fix unsupported offloads disablement Thread-Index: AQHXNsxOadzKAcqQ9kGYg90Gv3vU/KrAU7Mw Date: Thu, 22 Apr 2021 10:17:28 +0000 Message-ID: References: <20210421163441.17240-1-talshn@nvidia.com> <20210421163441.17240-2-talshn@nvidia.com> In-Reply-To: <20210421163441.17240-2-talshn@nvidia.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [31.210.177.255] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a78a2acb-b456-4792-5d43-08d90577d534 x-ms-traffictypediagnostic: BY5PR12MB4115: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:220; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nbGvSopZRm4FoDIQoxdgjP2E2HSt69fgZCGKp95HXXN3KJoQkgLn5QQuIrGX3S9MZneMkQBE9+xXTEXOyMYd6NMXHMpDKMM6YJKKuICrSXi1Bzlx3GWJz3itD1cAYwwuJia22goswSI6KiB241unuA02AQSlcouwBXfKuxW1RRE8u1U4jUA75OCzJBJxFgLg/TGRsBPycnG6GZCK4/zNR63pPEsmPIP029CmNzo9E+CNoG/HEP1RdpfmHJr3feFwcNnf5AY7ZDhP0tj/BObSFSHFg6jJGl6bwIK7uLMf69KpFyvj3S7VTUtVOARPNE7h94WLjXdzhJ58mdfObZ5GvaE6gZEx3DKPjnC4gDJAIV68nih6oRRtlKtZ3Zb1HfHdfGsYUPf+3HUGXzRFbNouhs18SzDEG3OtA2kGuEwk4gMIijlOufAIqRclg1dzVhTUvxJhPB4078kMc+BGYOHcsI5X0hGA3WiLzFjdv/02dRfF0dkH4pBbxArYGW2FKlfP9cJvYkPSuuxvz150PCdoG7xPBrJmLgbcrKpZCDZ0M0JdxSE7Lvk+xnW2R01aQ0Wbr952mpVtb1maK5Q0CrZjNdQtqQ+ly9bCTgYWhQQr9Iw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB2824.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(39860400002)(366004)(396003)(6506007)(86362001)(186003)(66476007)(5660300002)(66446008)(64756008)(66556008)(52536014)(9686003)(7696005)(55016002)(478600001)(66946007)(26005)(76116006)(2906002)(8936002)(33656002)(38100700002)(71200400001)(54906003)(316002)(110136005)(8676002)(4326008)(122000001)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?AWK/Wcs5SZP5u+V7ZIaBuC180Q8g1ENuwW3BWueH2M74Q8+tLIomVir/llUA?= =?us-ascii?Q?Xo6R04nykTestt1N4dyPL4hwiOFK3/xvGv2EEKAYNXkRzdanZr3M3TqwAWBa?= =?us-ascii?Q?GpD5ztTwUH9NC4aP6YZEjzrbBwh9xY9md9Nix9tqQFszPNFlgev9NxjPzFvK?= =?us-ascii?Q?MPMQPZ2K6DR1fYRdk6HIZhn+ZsBW5eCZ3CFPqqz99yjWdm1Op07A/0H0K5oY?= =?us-ascii?Q?3sxw7lHI17jDFrBiEm0IYHr/DPb3Im+gnZYgjPnPDLwvbrmhdCXQt90QbOEp?= =?us-ascii?Q?3ishYIJHWgca8J055Gqo3ZIlBRuXRV3TQTQ5iuNGjcOF8CONPf7g7uxiMPLK?= =?us-ascii?Q?2DR/uQXpHGHpOvqSvPJdsCzzxUQlBHzGHqOxMEW9iAvvHmEx59/jQRm1Iq68?= =?us-ascii?Q?v1Q+F2wbPy7p71mr6FdhMYviqaySaLLOkDuJasnOuBJg6ggIS13nSAVk6tgG?= =?us-ascii?Q?EpzYLDsH63fKjmHy/oUYkwPNolM0h6cc9Ze44mTTqhtaCl+oPhdoyqX4muhF?= =?us-ascii?Q?jlwCsD6FZYMeExuVD8F2KlISoyOuUO8iabtKERP3XhSfYgpZUcfS7HhyXWDC?= =?us-ascii?Q?ew4gL694A5lpT0Xd/hEbhSxvHY+epp7M+j4kuZ5keMJLaGvcC8rDVXCSrIGl?= =?us-ascii?Q?XBePFOJAB58bHOKVzPLVHOuFVdi4Jap/oSxcThT+tvEY8fCiksAqBHNkWRqH?= =?us-ascii?Q?VANKJ2Rvu354OFD//iNS/scs8TW2YuZhdaVJdruwhVpUQ3uEjdnN48IfZIdj?= =?us-ascii?Q?Ge67LFQOFjskoQnU/reLbVnoSc3yilDZZrWIoKU+dzQo9HIUx+teQHUG2Rh6?= =?us-ascii?Q?gD9Lv+xDJP88twXQaAo2xEQwe/qmqBskcYDQx85Epvp6OOkmfhzPhP5EM9wQ?= =?us-ascii?Q?I/ufNGvrXVlK2Z3Jf5MEWYOyvF/XssXMQOVwLlIcxkwrmuvZDvuHyyxzkijL?= =?us-ascii?Q?+D+rtIlILZJG7Bf6TJHY+kG8kOFI+aULqCCWeCIrvMlTs9gj4NDPLoAVh0m8?= =?us-ascii?Q?Cj87WgDrbwmk1BWXWE9RFajIMVKnbt4f1O2ONAaSqgGb4ID0s3DWjMbe9hWw?= =?us-ascii?Q?L78C6P+4vAcHo8U48zKZwafxlrwzdlurpwmdPr9TrI+bVnQq8PEBYUPvHO7a?= =?us-ascii?Q?kApkLYIMXhHxgKpz0uiAokJXOICkxETM0fIdPD0t50X9USiYWl6wVi39CNfm?= =?us-ascii?Q?YYr3LBfq7b+yFrIXZu/1Ya9JeDy4DU7TwWVF+G16RHbN8YTEBJBY1RC579SU?= =?us-ascii?Q?1bxSjJLWMKevLtiBTjVOzu4yGwo8oa6mSzNCfd+VXKS6Yz+Rzz7HhpGIFmXq?= =?us-ascii?Q?rCqvz+9UJTjTH8A6BXrHF9x6?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2824.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a78a2acb-b456-4792-5d43-08d90577d534 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2021 10:17:28.3043 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9yZBI0j5EKozPEaU70fwcAqG7SJNsQnx+YAEVxX21qWqtIGuRf7q311L5XRzo3Lr X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4115 Subject: Re: [dpdk-dev] [PATCH 1/3] net/mlx5: fix unsupported offloads disablement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [PATCH 1/3] net/mlx5: fix unsupported offloads disablement >=20 > mlx5 offloads which are unsupported on Windows are currently disabled by > checks with IBV/DV flags which are irrelevant to Windows. >=20 > The checks are removed until they are fully available. >=20 > Fixes: 93f4ece91a1f ("net/mlx5: spawn ethdev ports on Windows") > Cc: stable@dpdk.org >=20 > Signed-off-by: Tal Shnaiderman > Acked-by: Matan Azrad > --- > drivers/net/mlx5/windows/mlx5_os.c | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) >=20 > diff --git a/drivers/net/mlx5/windows/mlx5_os.c > b/drivers/net/mlx5/windows/mlx5_os.c > index 814063b5ce..5e53042b85 100644 > --- a/drivers/net/mlx5/windows/mlx5_os.c > +++ b/drivers/net/mlx5/windows/mlx5_os.c > @@ -359,11 +359,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, > config->swp =3D 0; > config->ind_table_max_size =3D > sh->device_attr.max_rwq_indirection_table_size; > - if (RTE_CACHE_LINE_SIZE =3D=3D 128 && > - !(device_attr.flags & > MLX5DV_CONTEXT_FLAGS_CQE_128B_COMP)) > - cqe_comp =3D 0; > - else > - cqe_comp =3D 1; > + cqe_comp =3D 0; > config->cqe_comp =3D cqe_comp; > DRV_LOG(DEBUG, "tunnel offloading is not supported"); > config->tunnel_en =3D 0; > @@ -424,8 +420,6 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, > err =3D mlx5_dev_check_sibling_config(priv, config); > if (err) > goto error; > - config->hw_csum =3D !!(sh->device_attr.device_cap_flags_ex & > - IBV_DEVICE_RAW_IP_CSUM); > DRV_LOG(DEBUG, "checksum offloading is %ssupported", > (config->hw_csum ? "" : "not ")); > DRV_LOG(DEBUG, "counters are not supported"); @@ -439,19 > +433,12 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, > config->ind_table_max_size =3D ETH_RSS_RETA_SIZE_512; > DRV_LOG(DEBUG, "maximum Rx indirection table size is %u", > config->ind_table_max_size); > - config->hw_vlan_strip =3D !!(sh->device_attr.raw_packet_caps & > - > IBV_RAW_PACKET_CAP_CVLAN_STRIPPING); > DRV_LOG(DEBUG, "VLAN stripping is %ssupported", > (config->hw_vlan_strip ? "" : "not ")); > - config->hw_fcs_strip =3D !!(sh->device_attr.raw_packet_caps & > - IBV_RAW_PACKET_CAP_SCATTER_FCS); > if (config->hw_padding) { > DRV_LOG(DEBUG, "Rx end alignment padding isn't > supported"); > config->hw_padding =3D 0; > } > - config->tso =3D (sh->device_attr.max_tso > 0 && > - (sh->device_attr.tso_supported_qpts & > - (1 << IBV_QPT_RAW_PACKET))); > if (config->tso) > config->tso_max_payload_sz =3D sh->device_attr.max_tso; > DRV_LOG(DEBUG, "%sMPS is %s.", > -- > 2.16.1.windows.4 Tested-by: Odi Assli