From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CE06A0032; Wed, 17 Aug 2022 10:20:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4DD341611; Wed, 17 Aug 2022 10:20:27 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2046.outbound.protection.outlook.com [40.107.94.46]) by mails.dpdk.org (Postfix) with ESMTP id 30B3541611; Wed, 17 Aug 2022 10:20:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VHNtHRsh7leiMDPCoQMrU2IZ2ygvIBLYM1Wi2GKV3/c7P2vAXGUzc1tReVU+ScIsTAVfo8g5cqj5IjPJiaHXSQd0S7B2rdEJitjq4sJYFFDD1fDhbUwiawQSNgwAuH3OpNt0czRjH8T0Wl6iskm73VEOu5WbnBpky15voGb1xfrf/JcXJZxVPqZdOnxrPurGQfFjgjVHMQrbWZoeNlJr6qlizpTNxk07KQd7BUxUm3LsJLqdD6APaLII2PocxFiI7XOnoKxcdOk7d3NSQe/D3fL4vyu6wersArY917AWWfVxlPYiK82jdA2JmqPcs9Cik5X9cYI3EWudJrIUPq52PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aX/AnR7+yYNQle5cgf0TLnEPI5CTIpn/vUPKxsj/u00=; b=WildfX5mBqVeb9776YouzWl1VM+aNZKuHPnTGBe0j0PebU0WEJ8rAmGOeiPvgDVpOsp8KGdQJ23U5KogVqogVaRSJJsWT782LAcsmeKyTX9SJ4oi7EZaHI1HsjBDbnuhW52NbEjQRXnIVbVCVJznEPhP974CzOXKNvwN7iPubgNut6NU5vMWF6tNG1GIY8dUTcS2W5n0tzVTObQqyY00VY2YATnZkhy0Us6+uNx9UucZAzsEv1lQ45DW8W7O5yNGSXW6nBkGDXC6+40Vb9fqnHLwRhak/Kgn8tZJtY1wZ9eCEi+WxavjWllSjeEKfch0PD4POlJfuUev/yqAsYO5NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aX/AnR7+yYNQle5cgf0TLnEPI5CTIpn/vUPKxsj/u00=; b=Fi7YY1mJOgVmhm+lv53nvBYX+maPamrHkF/ALu9VgJAiJAMxYABnVajUIubq8HVyVR+MZ8s0ZlIKOsvX9x1OoPUUspXTT5Ar4/3iTTAn/GZf/Uo09r9lk706EG2uyyxJqcEiOZbvV5Y+DGzMKToNXDQ4oKqVhy0uoWTkfhpheaWUEsS9p9SUdW5KMbT5YY3Zo1+sMTPwsmDaI1WbTVxeNC80pzozcW9w+VfEyYakhzDQVV0WAl0ouua0Llgke9f58geiW3mVR5vIQCsUX9sD/tDrbndDhjeEHPuf3eXwxcmENU3YogpAkXawmC1SZi8xREs69UUWbUj5kUWPjk0Rcg== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by CH2PR12MB4181.namprd12.prod.outlook.com (2603:10b6:610:a8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.15; Wed, 17 Aug 2022 08:20:24 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::acbb:9c84:ec42:78a3]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::acbb:9c84:ec42:78a3%5]) with mapi id 15.20.5504.020; Wed, 17 Aug 2022 08:20:24 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , Matan Azrad , "stable@dpdk.org" Subject: RE: [PATCH] net/mlx5: fix check for orphan wait descriptor Thread-Topic: [PATCH] net/mlx5: fix check for orphan wait descriptor Thread-Index: AQHYrUZhdTH8xS2LXUWpXLxiec7RZK2yybfw Date: Wed, 17 Aug 2022 08:20:24 +0000 Message-ID: References: <20220811055058.29957-1-viacheslavo@nvidia.com> In-Reply-To: <20220811055058.29957-1-viacheslavo@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 49ca1ae1-3d58-4019-b8a9-08da8029557d x-ms-traffictypediagnostic: CH2PR12MB4181:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i1eKTjJKvqok5luH+MpNRr0D1S9hC0mof1o2mb/z4fg1a5jC7vadwoXSxXYIr4xLSTeCldEVjPnbJ4nNtSdfZpoArdLme6aDee5en1CYsrg1AjrSeI9OyHRSw+GRWpludWXvfZSPI4T6bnhBpiydVFQcApZHtYCCyvIPW1tlg2rLchd8cC9/Xg5U2HsVB2+N8clXNTKV9CHa4iZ21CLKwvTmkGqhX4ItPwPj3gy3z0WcKSfnmkM2P++AgfEdXym8K2qM8baHjC4hm42at41wVOEzx2NL1tTGVLEqPFxTd/5Gq1OTyiuaksOgHsbVp+9q13Hhpq/ebxdX09+mGLjJf+NLXgobpGxSuV8JmVeoxd7ns0qrqti1syuFVN3yRQfqcNMCygC+H1FeaRG/6BOvzY4ICoei+lXQOn84ZHkIrYf/YhIzcfW/7S/I/iVYP/tnW1ALucaQ1R4qtt6+FrkGyPmzEOLnIqOYVVE6366+oh+CgKY1D/D/UByCGVgpr4BEIZ3AguK+XAzXlHMujo9JD2vuRxFEF5h76OryCIZpXhlBAHPv2nqNonIYzWgc4xff0NPgrk8IPVg19Z3RHSy1pi35l1USkxhZ0pRx62TkPe4crAbau/YqqGVMueB2WD6oulcGbzZYE25mjPUezSXwNP2brxG+pFQ/HdTsz3B4HQEha9t/IEs4SYZ8RCj2fwUYSGskgi1wKXtmRCWbaRmo4JYNum9roWhPKuKXT9VT9Nrrt2Groo9HyOpAK1AJribd66bxGGQTnCXvp49ALtj8bWXfbERCIwMfmE4zUw5O7Txn3ZwBg70Q0c0BGTr3s2nm x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(366004)(346002)(136003)(396003)(376002)(55016003)(8936002)(186003)(38100700002)(6506007)(26005)(53546011)(7696005)(9686003)(66476007)(54906003)(110136005)(316002)(86362001)(76116006)(2906002)(66446008)(41300700001)(66946007)(4326008)(8676002)(66556008)(71200400001)(52536014)(122000001)(5660300002)(83380400001)(478600001)(64756008)(38070700005)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W/59JLnGILrfDJrBbOv2fkDeJAmRF1nuSjcklu4o95dVomKPvt/Bw7s6RazG?= =?us-ascii?Q?ews45v1hx6bMYTjfXRbN/5HbBVxDY0AW6fe1rcrMc8zidpHmT9ygMm0SQ7gB?= =?us-ascii?Q?2HntEd5UAoe5YqCrt7AE08rp5+bluPi4Y97i7HixMm0r1ENhHHPwAQMM3qxG?= =?us-ascii?Q?YezWWhwRWxDgvMuejYBuKTqoz5ZZjI4k/CtoQbD6lxVqBNLnM9JmDwdM8Avx?= =?us-ascii?Q?ZCtHYTC9Id+wko1YAQ/Djzx44jMmHaFFotPWcRZ5jNr7q/lWBGO1jC/LiwtE?= =?us-ascii?Q?r1kwQSknfGUwF1ZBkDzBTo3cxBc9GhksPPe98WpytsCGswpgEu1qhTd4zF96?= =?us-ascii?Q?CJGcBqbayoxFe40WKSgjF0r3O06nTi0t3701LTYp9uuwg3KPIsfmcye1NfbK?= =?us-ascii?Q?oshsPMET3GzjX3e+ihurpaOG74k5Bic5WdvB7vKQDmOSE4KW0SQb/ruKDehB?= =?us-ascii?Q?zk8dOwtV1aVaPMRcU5uqeDhfbI5jBurQwhebwgPcvBPlRRU594if7B1aZ0n4?= =?us-ascii?Q?zcSbQHYdjgYUAh8tjBYSqZPUSEYcE5gfl8+USR6UJ/dK4uqVCCLrvXJWhkMd?= =?us-ascii?Q?jz9QxU+U2RIRjv+Tp2b9qjM/+oxtJagIzaejWAiVYlAmtG5zuKv31LtD3n5B?= =?us-ascii?Q?7drZGlj/mQhtbEoPI1wcD6ztUm1dPhPesFrIZ4XSpy7pXX/XKy1VpJYtp6UM?= =?us-ascii?Q?jyIsnLwWwSDkNhFePibu7NyqXVFyJivfqSFg2Js9DPrPKltNLAOMhrUTm6EO?= =?us-ascii?Q?0DM12huyCjcxIC1wY45361uQaJMJ/CDSg6WG8Btcd9dfctPN4KTtMOkhqmjL?= =?us-ascii?Q?5y+6zdshVAYX2XLbzyhsJc/Qn3c7gnC2yVUjj8j+5/GfoK1pZVBJi/5hYwJ/?= =?us-ascii?Q?J/KfOA4AxdePcC6xVQoSzlJRK6wAlVFWQSugkiy8QX2fBwzJ0qSy4Y6JxfB3?= =?us-ascii?Q?vWwe3RWsqCA1S/pIsYnAsMhvhW8exlRZQEZ2GAboH2h8o1x0ZpjXERUuFkJn?= =?us-ascii?Q?f3NKVJc/0rHW2qdmXCt+PbyrM3zW9UZtJtejl1LCnagxIQ6BFxkTHtQTxABD?= =?us-ascii?Q?mmidv4co/tVCNT62Aoj5yzKcuJXqvm+hQw0GfnqrbTMBe6LCwSoV3aJswIFx?= =?us-ascii?Q?fLFGqJfAusj9+0LKSLN7NBo9ifTHDfyAHR8+962X6zfsyFDvOBuYkYTD2C4p?= =?us-ascii?Q?zE4lpFqQsBVJSo0F6FAJQ0NvspSqgze3HN08zWmlFjQ6m9OJkPmpCM6PoNmM?= =?us-ascii?Q?cJFqju4WlYhiRCvJUKKZP8HHWSNq/CaTSfOtruwPmzTI54QAZgJLQ0JxRjvK?= =?us-ascii?Q?MhaEn/xWB3g2bGsUAqWFB//E669wqyCRz58SL5ArnNOJW9KXy7L8iaPZgZrZ?= =?us-ascii?Q?Rq7OrgHpBYzkmHOaw91TukID0l4Ic+kFXRFM/mHw0kK0iDri0u2MMuScpNoP?= =?us-ascii?Q?x30DdHZi1lxwNTflgOxVgCfLF+LppK0/1cEeYj7Ekfkh5u1c5XcHTnen1O5F?= =?us-ascii?Q?H9QFQV9YRZqZizxy7F8i9KROQrwH4AfOOpmPWsrAY5K6mBM1mtIxpP6snGpD?= =?us-ascii?Q?4HljVNdRnWG3g3MrmIDvPf1JVLY9496T8Kqy3mST?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49ca1ae1-3d58-4019-b8a9-08da8029557d X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2022 08:20:24.2194 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jfrS4crhO196M9e3I3xSUwb9Xab6lKp6wxSCm3ckPmufaLByIVGee+5JMR9BX42OeZRMYh4+dN3Iu9/6wp0nAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4181 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Slava Ovsiienko > Sent: Thursday, August 11, 2022 8:51 AM > To: dev@dpdk.org > Cc: ferruh.yigit@intel.com; Matan Azrad ; Raslan > Darawsheh ; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix check for orphan wait descriptor >=20 > The mlx5 PMD supports send scheduling feature, it allows > to send packets at specified moment of time, to do that > PMD pushes special wait descriptor (WQE) to the hardware > queue and then pushes descriptor for packet data as usual. > If queue is close to be full or there is no enough elts > buffers to store mbufs being sent the data descriptors might > be not pushed and the orphan wait WQE (not followed by the > data) might reside in queue on tx_burst routine exit. >=20 > To avoid orphan wait WQEs there was the check for enough > free space in the queue WQE buffer and enough amount of the > free elts in queue mbuf storage. This check was incomplete > and did not cover all the cases for Enhanced Multi-Packet > Write descriptors. >=20 > Fixes: 2f827f5ea6e1 ("net/mlx5: support scheduling on send routine > template") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh