From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2D15A04A4; Wed, 2 Mar 2022 17:32:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADE8F42715; Wed, 2 Mar 2022 17:32:27 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2044.outbound.protection.outlook.com [40.107.244.44]) by mails.dpdk.org (Postfix) with ESMTP id 43CFD40141 for ; Wed, 2 Mar 2022 17:32:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IcOdsX7g1VhL+MaVEW+QvRGtSGuQgXOpl9IUmL72IYoVWEHANOTNcelfjxifd968KaiKq7NSTz+lOnwacVm0TbxnUkwk+1lZQ1+ckwh2dEzhdS4fH6YJ+dEuPOWk1azqsp8UekJu/kCThOY1JXOR6CEK5Ch/vmG1jSIxpWqV27hRi9zbwrGY5d6lquUXBqjT5yYi9ycnzTm3J5mM1cSzxNN3f1/A0AK7ATF3ApTslz2iNj2CrJoXOeCl6GbokfyUYgafrIjOGMj3YbXAFlsngTg67HNFwECYPOkXXjFJayrLFpSGAeMt/3Yi7ZCAeXxJn4E7GftptPDrN5fGyKzOTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CMSP49zHUlmbqXJL1XtanVLWRetceTj08Z/gDciQaN8=; b=Q0P84iDABkIW1OmzJDgVOplEsncZt4SjF4j1KEj0c8xb50ZhnQnP4ZcVIwFp/q2yjC6JbIcamZohaXFo+MTnj5nN6Gb0UyfpOOMyaSbj+Rdw9DuQ10EGVlwydQoB1ORlxUJHZVYHPr8whO1M5NmArmbFzlFBMMGJKWGjsXoNpFHGtpCCp1onMjVpezcunOMPdi8UriCWR/DRFhcrJ8+1xxxZsCFJBgrOzsHr8iAtxBQUQcCyrUP6tIcPblsKXv0KMgl3lm9xeWMJJP1GQNQm0GXZeWiXAJO0rw/doqrumh1Isgopko0TPwkftuiGkAb9SosV3HTSgtoXQCTBSOIMmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CMSP49zHUlmbqXJL1XtanVLWRetceTj08Z/gDciQaN8=; b=DjvLwKOE9r1HII0iCzw6bd7RVVwPsIvnPl2f3nXoS2bTOFPF96ZxuE/JHDljyO/QbqOTGzZMOYgZzTswLc8kQ4NidECeDm5izkFTpJwoa7vNPCwzUqGYhVeaZjMIQ4qnXn6aIaDx7vdY71T2vC9tlKaFJtI9B9C0oDAqH+le3TIsN3isFKdiKyUcjRYUeIcfQrUCqUR+ZCPxi75kG87cSJMtbnYf1Dhgy/tcKFdKP0X1SS9WfrscP2wHkrGgn4xZdO76m0ML2j7TQCkbIYpsEE09ImcFcapCVCd41+iie589AhgW4nC8fvm2I9wdd9FBC24sBoa1WSw9E370w3vF+Q== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by BYAPR12MB3589.namprd12.prod.outlook.com (2603:10b6:a03:df::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Wed, 2 Mar 2022 16:32:23 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::e045:deb6:35a2:49fd]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::e045:deb6:35a2:49fd%6]) with mapi id 15.20.5017.027; Wed, 2 Mar 2022 16:32:23 +0000 From: Raslan Darawsheh To: Bing Zhao , Slava Ovsiienko , Matan Azrad CC: "dev@dpdk.org" , Jack Min Subject: RE: [PATCH] net/mlx5: fix matcher priority with ICMP or ICMPv6 Thread-Topic: [PATCH] net/mlx5: fix matcher priority with ICMP or ICMPv6 Thread-Index: AQHYLJhGiFgTzfSnq0S9jQHmQpJGWKysTOVw Date: Wed, 2 Mar 2022 16:32:23 +0000 Message-ID: References: <20220228114149.493759-1-bingz@nvidia.com> In-Reply-To: <20220228114149.493759-1-bingz@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9cfc3578-85e0-4604-44b4-08d9fc6a3afc x-ms-traffictypediagnostic: BYAPR12MB3589:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8csDUBUHMIqk4pSaQxWY3nVzAflt6TnYuTGS4IcssibO6HFVqiQMdNXXCyYpnw7jRIZIFmA77zYPdaAqydiunziFdpl2O8VCi7k2Upnw2r1Rb9KMWxMPuyBjKMaFbu2PyDCVD3tygg/R0S5CShrMPy1O88foO42J4f8AFDfad1e0w0R82AWNlXyh45dQUPlYJErmj0Grr/hp9xvkoagrR3sfCG5VrWrCAHvx9sliKSpjy1BW+tBoBmIhB/3PEVce5X7Blxa4X6XtRNKFcCOBe4fgReAasyLlU8B9v/qsKAXDESgeXqon38nJJkfcZe840DNnUpe9/Y0RPfQWuSnWWxQg+93A7TLWsDnVMCQnfYkb1V58lehYtZnADculducG04HizNMTXtvCs95jNDEWxcCFfZxRhWEiAsJPKj5uVIGAmkwg7Rh2vNfmluDeMFXJImV/bHCcHdRjVfvAOrsbbalXzLEgr8SqOx0VwXKadvLT0cpQg3yQdJI6YwXvYmCs781r0MrOJerCgVBNtxjVg+qoxFsr57cjZcvZI2GUFaGgGbqGtQCCumf3boNpl+tuzPwU1jKIYQl5XflWEv5Sd1JpI+yMSxsaWAIkDI3e9SKz7fRyce/ITf3mZ0Dr12OhS5nvgAX61zc3bI2JxTezIDahUBdJNqbdr/uJMu2Z/ztShbKj1lxsG87PIu6pLfa/ac1Aq1j3ksy/dHCEP0npoQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(2906002)(38070700005)(33656002)(9686003)(107886003)(8936002)(66476007)(52536014)(86362001)(8676002)(76116006)(66946007)(64756008)(5660300002)(186003)(4326008)(26005)(38100700002)(7696005)(6506007)(316002)(66446008)(66556008)(122000001)(71200400001)(55016003)(508600001)(83380400001)(54906003)(110136005)(6636002)(53546011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MebbZQTD6JGZhuBOBe4yKsXLIUlzUukKOyijG7TPf3U2M0zAHtoAyFu4Tbbv?= =?us-ascii?Q?loIQd1p0+/2D7A76K3s6vJOHOCYZnLgC8swbLBG2JV2GiFnKJt6jQyieaP1Q?= =?us-ascii?Q?QHow4/zTZe2D2y+Z4a0whbiN4O2p4TSw1rKC+N34Hmy7sObfkN3vLS+YL7zG?= =?us-ascii?Q?cgVUQmiIcMcwYB/oshKQbL4e5qLdKdK+FwZoSnUDlux4tV5r5YKfYWVyNtss?= =?us-ascii?Q?+WLv1KLB3payGSxbE0hFfviWrn+KbSRWFBeagmZzEjCnAY0fHH3ev+20BnEQ?= =?us-ascii?Q?865bFl1zPz+8Y/2YU/uJ7mhzndqwa9F8vwuUjA7Ux9i1TgayfwJdbEno7pEl?= =?us-ascii?Q?GtLY4CtsgvVLVeEDv1m0u5Px7lpYqiQL58ywCBY08sG4uOxZOJXRpUKOvSOJ?= =?us-ascii?Q?jSYicV75FoULb0pXxdTrStqWE9GwRDc/D0PzuB+TEftyIiEQb5aQuXMTG/us?= =?us-ascii?Q?Kj0fCRtbmxhvfb9Jueo3bsCdd4HwOtV5aSPzyn+BRA61VSItgdHMGhwCYU4v?= =?us-ascii?Q?EcIbekq9gC/onWV7Zd5l9E85IVh5qPwgPAXUT6PxuVyE+D4f6cvMykpRtFwM?= =?us-ascii?Q?QfP9/FYxY0uXrmh3/iEVpxPPYrNo/NJyvVPVar9OjEd/cGMusc4b+CRzjv1g?= =?us-ascii?Q?wwo+na14MqMKjxYsWCcamn2OxQNFJl9p1RAhr+7op6Edxwp8STVokBKYZ5GX?= =?us-ascii?Q?v+4iRJFy9tBIzTx0MEy64tApb+f6Jtl6e+jtqZBrX2cTgyhD0kS/u9EdgA9t?= =?us-ascii?Q?F6cBRckJ0vpYcFQXjZW7f23/q/36aeJjkQyWU/FirktL3ahBRrKrA4aAbRpe?= =?us-ascii?Q?htyeVy91airNNAljanMs5yyUhwSDPk5kiRUZ4pL9nWwTgw1pMPzplicABJBZ?= =?us-ascii?Q?jLdxbH/8J5miCXyvetqUUue6f+j+QiKk3BDwFY/N1D/PPirI5dBlqkumgehA?= =?us-ascii?Q?X64k8szahNtuH9dEJ8a0fHUJoSXpwd0HB/PkNhkJ8weSS49BzEQ6Qyewr2ZY?= =?us-ascii?Q?D8uDlYNKS2fgccovSArsWYTtcfadlFoAXEtqkXHUoc6M1BI60aWVGSV9R/X3?= =?us-ascii?Q?UbJZOYSoe5jzlxfl3OIvyUcN8zjiC2umJOLbczccK8RLaW2GVEOt4dxrau/+?= =?us-ascii?Q?vd8l/qX8e10MIj2FRRae2nHs1amJ8/14rEr+652wLmEKlWA9FdUuLsKJ95jR?= =?us-ascii?Q?ZQsAMdg1mqf5i6ZY/QvVr/rVeqOqIHuCpQJOV3FSq159rUwq5bsJA3p6zAkc?= =?us-ascii?Q?RPDxHI8Mv1T3oYwuj8UlimK+R1Go2OIK+w9XYEmD8xyoIuH5hsv5rUgOzp31?= =?us-ascii?Q?9ZtYvufoj4aBexJE1EU9O862po+XZdcZlD+mDXxexWILFoCMAm6y6nFUnzt7?= =?us-ascii?Q?Ae5LfR3JmHhS7cFUoAE/nZSbjTFRz7OYjnRe2OPyI/RtXFJaHoDlsetBCfzF?= =?us-ascii?Q?uwdQyYUQDrmtFPVemxCzEgWt9BcVBmvHWLgHNb8GOq2GVyVK8QqDaubg8h7i?= =?us-ascii?Q?tyZW5QHQP27jGBeE4GDpUnMJtvdWC9zHBQrHJg0DzQMDibIh+zUFgVQiAgec?= =?us-ascii?Q?w//REKUyuyPZiEuf3mc1K5iTlmIJ9H6N3JZmJem19hWfuYDyJUPA4UQV5aH4?= =?us-ascii?Q?+ngFcVwmYiLb3xsU+mR4jEk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cfc3578-85e0-4604-44b4-08d9fc6a3afc X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2022 16:32:23.5355 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I1TJGggJzqOSF6dKjLlL+Dd6SZSRBZwdI1vlEu0uPfBB+bmS2ChHQiuEpERipO0dVRGMnhJyLEMHWJePs/Bpbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3589 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Bing Zhao > Sent: Monday, February 28, 2022 1:42 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; Jack Min > > Subject: [PATCH] net/mlx5: fix matcher priority with ICMP or ICMPv6 >=20 > On TCP/IP-based layered network, ICMP is considered and implemented > as part of layer 3 IP protocol. Actually, it is a user of the IP > protocol and must be encapsulated within IP packets. There is no > layer 4 protocol over ICMP. >=20 > The rule with layer 4 should be matched prior to the rule only with > layer 3 pattern when: > 1. Both rules are created in the same table > 2. Both rules could be hit > 3. The rules has the same priority >=20 > The steering result of the packet is indeterministic if there are > rules with patterns IP and IP+ICMP in the same table with the same > priority. Like TCP / UDP, a packet should hit the rule with a longer > matching criterion. >=20 > By treating the priority of ICMP/ICMPv6 as a layer 4 priority in the > PMD internally, the IP+ICMP will be hit in prior to IP only. >=20 > Fixes: d53aa89aea91 ("net/mlx5: support matching on ICMP/ICMP6") >=20 > Signed-off-by: Bing Zhao > Acked-by: Viacheslav Ovsiienko Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh