From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 458D3A0511; Sun, 17 Apr 2022 09:12:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB7FB40687; Sun, 17 Apr 2022 09:12:13 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2059.outbound.protection.outlook.com [40.107.236.59]) by mails.dpdk.org (Postfix) with ESMTP id 3CBDE40685 for ; Sun, 17 Apr 2022 09:12:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DUVM0z7VJ13xO9sG6Dg00ix5yN8VKMOFmKYXeDDoNqflgIQIJmQuU9tdHs+wIIMtLChMBTVO9UEk58CyVNtL+utxpXr1jlJfNZiAH0ojgEA/+xOrHAe/SyINT+HASkKXiM38qHKotleMwdbCmHoqJK8jq/Ji8LTuUrNViRR1DY2Fm/KgZnd1UYJNOFR3BaSILG54yb1949j8CFMbgy8ZnFQfZu3AmWpWOk8pQgJP6enGvceIPC3RGQRRXJdjwKD/wEz6HbzduNv3CYchGh6WrIZzNimNPxXIfImNiZIYisp/EWXhu6jkdQSj6lQ7cd9dud8r+huTFiZL7cLImUhSng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KM39q0Y+8Grzjc7zaH5BB0z4VhwHDU3q56U2/whXnXs=; b=I3mS/1n4akw1AL/TbpqmsuP37X6Hkh663zJW7XohYo3KkuO2z85zQpS6wJRsBUwD9P/8LXpnQ5zFzZ5GkMiiwN3YlRV4BvpgAJGIwNivVP0CmtE7l9syoEG/DqOvFo9pvSmH9cU923qPRIexioptnZc2zoCXyz6/E6CHlScZLs/jIV8dCfWI+0K+6+5YVbnBY0RZnMAiyuu8BCShNr6NGxQYKlb1nMufvyDUlby+q/CvKw0L69AXGLx9bXQV3Y2y137RjaoUtkAbwrUBlrSyE38cD03BmU4gtRYLPSyibOk69ksoXVfIcw6Y4NjM0ZfnUsmbApnUCiKxUIIKqunehg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KM39q0Y+8Grzjc7zaH5BB0z4VhwHDU3q56U2/whXnXs=; b=oXI9s3L0yvNVaPzayK5BBtevNHt3g4yJE/aQ6UoROshIwqfofZ+GhYZUySDUg2eQWomrhxW85lDeKmLkTfUK14AKcdNxwxgdUlnx4Zi/oze3cr+hmIxvV5K6TZYnEEhzY2w0DMk1hmzGaFitSkS/wxbCS1JBQvXNdLr71boDCLK5E34P/irlCWU+8h7CLisHjvFsE6Bn1CHwKQXuWIUnpu4EfQ30Wp5zlEalvsJNxEEZOWujbfNPsExN8J4aXm85sMRrRJvhUewNQK/5NDRae3rR410hvcj7kTmvoYeeRLKrBt0/tJ8BSYctHyJMAxg0K8iKy14dlUuGGqc8CL9mOw== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by DM6PR12MB2921.namprd12.prod.outlook.com (2603:10b6:5:182::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Sun, 17 Apr 2022 07:12:10 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::10e3:9c31:2a8c:2679]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::10e3:9c31:2a8c:2679%4]) with mapi id 15.20.5164.025; Sun, 17 Apr 2022 07:12:10 +0000 From: Raslan Darawsheh To: Raja Zidane , "dev@dpdk.org" CC: Matan Azrad Subject: RE: [PATCH] net/mlx5: support ESP SPI match and RSS hash Thread-Topic: [PATCH] net/mlx5: support ESP SPI match and RSS hash Thread-Index: AQHYSCSV+pU1Ejcs3E+uxoumfkAuE6zzw3LA Date: Sun, 17 Apr 2022 07:12:09 +0000 Message-ID: References: <20220404130425.8911-1-rzidane@nvidia.com> In-Reply-To: <20220404130425.8911-1-rzidane@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 641e529c-e3a6-4cca-bcac-08da204196bd x-ms-traffictypediagnostic: DM6PR12MB2921:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nuqGD2Xo5bDbmo2Mx2Ls5TvDuQQT2YHKTsNmNICal5bbDyk6Nmzp10lCWUi1mlp/RLB10emf2geHL/UseW8w9XgRrlZizSxftexyrv+kfB4zhAXxdytNAoqhO+QjuKdMinmE3cq8b+8PLZpWI6RftxCBspnmrhSmZoUUiUNgNLi/w/+y3AmIFHaJ1guZ0Elx/HxmGMFKnqDRDYe0xkQjfbVv9O2g1wVK4ki3lO1C1YYOz4oZxSjikA/dqT9t6meti5mFq+7tNCYYhl1TEJ4T9GCvmZfF3tfNifZq8Gt63Xt2fOylw0DL4lmFQQV0rpUCbqG7RFB+cg0WAoPepX4yESY8fK2pk17647MmfLIJPHvASb+HW5dzDrSd1lbdTJBRz4QWINhSSoqw3GNKmJrbijFWwP0ycuWUS21Z6IhMEY8SjoTIw5mJdzgY+6gVh3R8AyhMtxwi+zza2hbPJwGO3xRYu6y+A07tPENWd22i+yAEBdKwQaAG4BP5kQSW4WsX2INJeqC4L6LFp29VT1EhdtIQq5RL9WB8A3EWFodq/Dvgh3wlQWS+S4KNqQ09pIfhsKgKJCx9wvIAn8Oze+mYDwsC/jY6mkjSp1Dth0/EeV9TYqCWNgX7+ednEyr4tQ++o9iLkPRCblpWk8OunjNdTF7yA97nlednR4XRYD+ZOe2b3AuV8pPLJPENrAs8O+CtkiY7Aq7vOXjSr8Bu3XuX9w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(33656002)(83380400001)(6506007)(38070700005)(26005)(8936002)(5660300002)(55016003)(52536014)(8676002)(66556008)(107886003)(76116006)(66946007)(66446008)(66476007)(64756008)(4326008)(38100700002)(2906002)(186003)(86362001)(7696005)(53546011)(508600001)(110136005)(9686003)(316002)(122000001)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tyedcSs6QObKkyLgVvBZveW2KJgcRF3l6huDRvydBVENSdpBzraqJz5JeiLd?= =?us-ascii?Q?/i6DLA6t86N6uFtWMl2VXUSkpI1iCdZI/2W3zBadijGV241x8NMlxMTmkv01?= =?us-ascii?Q?/a4xEoXto3sUmvxFEJKsICiEHyCVVTG+u7Ht8AabS9cEdTdWStyaQiTjSi0r?= =?us-ascii?Q?erQMgLIRiHBoUeVLUbmXvX0A2AVv7+OmiBJsUfLMISJYwcOUcXjLQQFzs7/k?= =?us-ascii?Q?0+SnMJOQ6I98KE+UqlyyKkgnrv/GKMaLDnhMf96uYm+AwfkNnHAfl1jfWWAN?= =?us-ascii?Q?W1RrmM+3JtYfEcYTjvQbg0L8NueTdEYoaAzT+1QcgXLsbmBXUVpSEXG1RBOR?= =?us-ascii?Q?X5AQEi86g5dgrJcOy4w+6HdOYPRq5sl9crmtd44khUoYOJ1fGly406lOqhW0?= =?us-ascii?Q?ScoLaZxx3n7Og7CIkjwR2TphP43Ovd4h0qOltG3pxI4jIwzaL+q7fjxuYzS5?= =?us-ascii?Q?a+wZQbfSmYgJh/ji466UC3B6Cut/5xT+2NDZB2XmiOpOLvwfH1wbPNR7nYp8?= =?us-ascii?Q?xYttvLhBXSlapZmAISNIZ1AnI+h8td3DdafkTMPNLVlgsb3sDpEMkOA3IK2r?= =?us-ascii?Q?f4z0SZHqaBNzcI0FITQCd4oVlazQ7ramlYcxGSEo6d7Y09LvOJrvutK2Clz6?= =?us-ascii?Q?zvxehuNZKX5CJeUMhpa7OW3dbcvjCtspOd4kdx9ikDYY79FSvL+S5HsFd6bG?= =?us-ascii?Q?QiRa24Ngj6Qkf/Nqge7GD0s9NThPBPBF9xfZuP40rN3438gAzDM5ykHY6Cuy?= =?us-ascii?Q?lGY7E7k/WvLhmjWhpeGBliv7JTpYZawh9uqLQMAgOXkv2EbFJ5OBVokWivh0?= =?us-ascii?Q?BM3FRiC2VPmmO98hTu8sBpapXCsQvmM8LEiq4/6bhXj13EDDpcpOllmBvZeK?= =?us-ascii?Q?LXBCmmpYv2FQVDBy8BwFK9YVcRi0v2RHvupFNGzFjnBSAQ5n6PdvNsXRgGFz?= =?us-ascii?Q?BkRfg/vpUyGzfAA4SYbLg1eaZgYPa53gSrXarF/HD30guQVew2rHIH5pKuz1?= =?us-ascii?Q?WxonJ7TEKkKFAj9rUdRgNPYMja2D7Z7PkgazXjTVAES3taROcxUkFl773q/P?= =?us-ascii?Q?NhgsDniYm/eQO/vPnrhR2DFNG/dFvXZ/MhtQn/miaJDoUKDAJIyaQTa+V31i?= =?us-ascii?Q?T6ntYouogVYp24LivGfNiKOc5yjC9k9PxLj7JV7Wy7o7yl7ErnM6wHlmlX5S?= =?us-ascii?Q?u/+D3UwDbRF6oO3mim3gPGFTXU44TYb5ZMHv2sBCZesq7mlQlA2QmKKULDvK?= =?us-ascii?Q?ZgV3r3+YgPKZR1sub/e802b6L17dIahhrrICjtVcZdeIgwf5iqXHeFs6fuO2?= =?us-ascii?Q?1i1WjzOnewY1jHW4P8vm8KPHmesnMeBNtix+IKscvURAbfrgdKngWcfIEJiM?= =?us-ascii?Q?w8ze55WQvbAgEZXH59uasRrzW4oIDGHQFqVwumEMWRMPnPX9ov0DK0AAuSEM?= =?us-ascii?Q?LGDN682SAIPSwOItDoJoVyLcPrD/7MTBwwWURiu+gTw2scyb9OqJG2CYUwNJ?= =?us-ascii?Q?+Kc2LQBsESLWk9fYf5lPy6ibPKJHti1l4XeY5J4c/VcVDLVrNJX2wvp9woNb?= =?us-ascii?Q?ldrtDDM4TuS/tYR1L2UUJsxWJHEdIAgrV435oleIlXDazPF9l1c4TBnMvbcB?= =?us-ascii?Q?ekObq7RtStRGsUdJ5x1DsDy8vWfnCNqYOJugYwfNAa7lF1f5uE0Z4ihS0QYP?= =?us-ascii?Q?kdM/R4msztvIHi4snvx9lgOZJBWWBoT5d62Mb2hNprR5wl4GC7+eEBhFT5hH?= =?us-ascii?Q?I+FsIzSyOA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 641e529c-e3a6-4cca-bcac-08da204196bd X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2022 07:12:09.9232 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W4BOJPHPG9VTrcjBDKKiOTjHL/k90J1FV6AUkIXCAvoQZB/bvGxXogfuQdIwa/R2cJmdASyA0W+vlV8de6gnZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2921 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Raja, > -----Original Message----- > From: Raja Zidane > Sent: Monday, April 4, 2022 4:04 PM > To: dev@dpdk.org > Cc: Matan Azrad > Subject: [PATCH] net/mlx5: support ESP SPI match and RSS hash >=20 > In packets with ESP header, The Inner IP will be encrypted, and > its fields cannot be used for RSS hashing. So, ESP packets > can be hashed only by the outer IP layer. > So, when using RSS on ESP packets, hashing may not be efficient, > because the fields used by the hash functions are only the Outer IPs, > causing all traffic belonging to all tunnels between a given > pair of GWs to land on one core. > Adding the SPI hash field can extend the spreading of IPSec packets. >=20 > support matching on ESP SPI. > Support RSS on ESP header by hashing SPI field. >=20 > Signed-off-by: Raja Zidane > Acked-by: Matan Azrad > --- > drivers/common/mlx5/linux/meson.build | 2 + > drivers/common/mlx5/mlx5_prm.h | 5 +- > drivers/net/mlx5/mlx5_defs.h | 2 +- > drivers/net/mlx5/mlx5_devx.c | 4 +- > drivers/net/mlx5/mlx5_flow.c | 84 ++++++++++++++++++++++++- > drivers/net/mlx5/mlx5_flow.h | 20 ++++++ > drivers/net/mlx5/mlx5_flow_dv.c | 88 > ++++++++++++++++++++++++++- > 7 files changed, 200 insertions(+), 5 deletions(-) It seems that you missed updating two parts, 1- release notes as it's a new feature being added. 2- features list in mlx5.ini=20 devtools/check-doc-vs-code.sh rte_flow doc out of sync for mlx5 item esp Kindest regards, Raslan Darawsheh