DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@nvidia.com>
To: Bing Zhao <bingz@nvidia.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	Matan Azrad <matan@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Jack Min <jackmin@nvidia.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] net/mlx5: fix matcher priority with ICMP or ICMPv6
Date: Wed, 2 Mar 2022 16:37:31 +0000	[thread overview]
Message-ID: <BYAPR12MB30783EED68A36987B4F44536CF039@BYAPR12MB3078.namprd12.prod.outlook.com> (raw)
In-Reply-To: <BYAPR12MB30781D75FF165B8854797526CF039@BYAPR12MB3078.namprd12.prod.outlook.com>


> -----Original Message-----
> From: Raslan Darawsheh
> Sent: Wednesday, March 2, 2022 6:32 PM
> To: Bing Zhao <bingz@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org; Jack Min <jackmin@nvidia.com>
> Subject: RE: [PATCH] net/mlx5: fix matcher priority with ICMP or ICMPv6
> 
> Hi,
> 
> > -----Original Message-----
> > From: Bing Zhao <bingz@nvidia.com>
> > Sent: Monday, February 28, 2022 1:42 PM
> > To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> > <matan@nvidia.com>
> > Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Jack Min
> > <jackmin@nvidia.com>
> > Subject: [PATCH] net/mlx5: fix matcher priority with ICMP or ICMPv6
> >
> > On TCP/IP-based layered network, ICMP is considered and implemented as
> > part of layer 3 IP protocol. Actually, it is a user of the IP protocol
> > and must be encapsulated within IP packets. There is no layer 4
> > protocol over ICMP.
> >
> > The rule with layer 4 should be matched prior to the rule only with
> > layer 3 pattern when:
> >   1. Both rules are created in the same table
> >   2. Both rules could be hit
> >   3. The rules has the same priority
> >
> > The steering result of the packet is indeterministic if there are
> > rules with patterns IP and IP+ICMP in the same table with the same
> > priority. Like TCP / UDP, a packet should hit the rule with a longer
> > matching criterion.
> >
> > By treating the priority of ICMP/ICMPv6 as a layer 4 priority in the
> > PMD internally, the IP+ICMP will be hit in prior to IP only.
> >
> > Fixes: d53aa89aea91 ("net/mlx5: support matching on ICMP/ICMP6")
Added missing Cc: stable@dpdk.org
> >
> > Signed-off-by: Bing Zhao <bingz@nvidia.com>
> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> 
> Patch applied to next-net-mlx,
> 
> Kindest regards,
> Raslan Darawsheh

      reply	other threads:[~2022-03-02 16:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28 11:41 Bing Zhao
2022-03-02 16:32 ` Raslan Darawsheh
2022-03-02 16:37   ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR12MB30783EED68A36987B4F44536CF039@BYAPR12MB3078.namprd12.prod.outlook.com \
    --to=rasland@nvidia.com \
    --cc=bingz@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=jackmin@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).