From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F4A0A04A4; Wed, 2 Mar 2022 17:37:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C44AD42742; Wed, 2 Mar 2022 17:37:35 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2062.outbound.protection.outlook.com [40.107.237.62]) by mails.dpdk.org (Postfix) with ESMTP id 0F65B40141; Wed, 2 Mar 2022 17:37:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HiZDsGbltJfQZlbuRY8JDO/IKzG+Xyvcj1MUEELIvB+pTOenVS27uSYrlBHRb1FpVuYBiM6n2JHPcloNotJTCR4WdtlpNEH3yGVLDhNvciIxgdLV15EEKUf2vmihQjhwvTHjSiZMhhKgQksTYEw01McXJrSuSxzutWIiYN5EYZS8681+ugWL81McUl+5E6iTrzVnsiOtUcHE7TEeG+VYcgjmtn8Hm80gxdFJX1q1vTwUuilGvl5EVr5FDLYx7gRCsoRAfv5Pxy0njDi0F3T3udjSkiTzwkcpywAW+66jBgyhAt8aMj3LMx1aBktAN6tkBs3MxYR67BwK8BFn2Or/NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fcxaMhs/EdccsM5EHiZjebP5SfOvD/0FsF35UnIlh68=; b=INKMHz71ENzrCtQhtkM+FSV6VwqhDikIcLOtmL2afqcSnLmN6u30s0VhaEO1Wso2cEY1c/USFETuFsGwT769mG3tQqoWW5Ud3xNq5LHVvVCUVOYtpBVQVG/wcso7diiKqmzX8DfOHEp6fECYwICrR9+iY+Hx5VpKLYEUwpMsCM0Lgsd/z28X1Xhsy+IwbiEi2HWwlfeWh2xwO9Cgb+S4YoD3e8vg149gghXq9FhI4ZPQi+YaleVLq7kjOt1humM4Em5fmM1GQdnM4unNsUGVouXJKTUgBRc/VpKj0j5ki5b2C2uNBh9DzOdY5mI8uRxshrdO4BvFNbyNG4Pg928UZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fcxaMhs/EdccsM5EHiZjebP5SfOvD/0FsF35UnIlh68=; b=G15MfX8cVF5onoCbe32JVZMDbqZIqxGUvl+M6+AW598eObVsqzzNIVL0jDLPAkyKl0gxhlywqwbLQoUnaqLueYRTBfUCyK24BHccbJP9FfEdNnHApSxNdTkx5WJQll3YLxptDVi1wEvnuvhsVVyn1WyDP3NSSCw5p7jJGuzgGHWKWTXC+hAy/0l9iVXOaOrumrl3+KeiIAV83Yefyi2VY2elLCHw0lK/Yw4vfgFyqp5m+bR3Mr9tbb07U/4mmSlShkmTiAy90z7WBjkhgeJWA35FzPxzVZWEjtwUs/Ua+FLyaFC8hf/ilqL+geNWp78Vo96u2lqCZ3bE/cAQPxd1nQ== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by MN2PR12MB3726.namprd12.prod.outlook.com (2603:10b6:208:168::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Wed, 2 Mar 2022 16:37:31 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::e045:deb6:35a2:49fd]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::e045:deb6:35a2:49fd%6]) with mapi id 15.20.5017.027; Wed, 2 Mar 2022 16:37:31 +0000 From: Raslan Darawsheh To: Bing Zhao , Slava Ovsiienko , Matan Azrad CC: "dev@dpdk.org" , Jack Min , "stable@dpdk.org" Subject: RE: [PATCH] net/mlx5: fix matcher priority with ICMP or ICMPv6 Thread-Topic: [PATCH] net/mlx5: fix matcher priority with ICMP or ICMPv6 Thread-Index: AQHYLJhGiFgTzfSnq0S9jQHmQpJGWKysTOVwgAABbmA= Date: Wed, 2 Mar 2022 16:37:31 +0000 Message-ID: References: <20220228114149.493759-1-bingz@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 026169a8-3f03-455b-597d-08d9fc6af282 x-ms-traffictypediagnostic: MN2PR12MB3726:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T33uhyk1arOxgxLntSKTV67eQoVqxw0ydarNXE/f9SnevAIBQJmi+RNw3/frJtC4X2troz6J2Wy1mNDQtQDT/9ZWc0NyhjpW5rXGy+7JbKLlNNdOrTs/C08yrFjdtvjoIFx6/UxLYgS7ZKOVNm2cKUQgao4uXEU7kwqUEWTLcLY0kppB/I4LNDC1nl5kJ4NZLjLpt5E+RlcZEI6ggYQhwL1Fyj21qefDXNW95iIMwTPMwoqXrK81vm1KAD+Ecu2rMALtQkytbNyYpuSvOKHxDjK0no5DYjEIBWUdgl+JiNTIkwMjqNP1BDG2Cz7ZhwaifKoeVxhfzmDakNLHO1W79OyZOMw6eDd2uJZLVHd5Fl6EIMnQIWcGaG0cnaYfekC/IkdDD7mE3hxkVAHarspH2mL5QokKwmST/5vnh9p6eBp+CuTh6NkakytpYPZ5TJx5ZAgQUawv7MvW00ya048nweRjl4oacAd3HyX+wlyrsElSLVCx6pqCMfE2QdamkcYbIdfbot3KqpvqameUvJsrwrlRuqmqk9whnonRLXZzxxCO+Eh7GZ3oEBY27JSkLZDJ7CWq8SwFiJn54idU76UPGatrVMz+BD5ZoGpq+AdOZwZIuCbUN2ZzEq+sZ7m+3PSTmjjnUm9006sbR+Zc0mMnn15QiGZqbfRk0QQ8eFIHIlhKjZ6EgGsHEYpHIGjsvL9mai60/a6c7uDr6yDpLpI23g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(55016003)(316002)(38070700005)(76116006)(66946007)(66446008)(122000001)(64756008)(66556008)(450100002)(66476007)(86362001)(8676002)(4326008)(71200400001)(38100700002)(6636002)(54906003)(110136005)(7696005)(83380400001)(6506007)(33656002)(2940100002)(52536014)(5660300002)(2906002)(186003)(9686003)(8936002)(26005)(53546011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NEBMIFmMK4D81x/WRuvr8nAlU52wVCAFWXTAdKx2q0EL4CfbFZvO89NRseah?= =?us-ascii?Q?diAzro8BAm5YRCEu8E0Uff+umw8+RSsw/XfKVfl7cPgfZGArTFh6YIImUMtI?= =?us-ascii?Q?fbVHXTk0FH5tSFRqYZdhPZ9j00FYz5pfc+3JbRMLRTGDO/NuIay8XPebWwWN?= =?us-ascii?Q?a2roEBo2FJ5XLVFSzfsqc6I7KLHGkEvXY5gedxvsjo8e87k9+ccOkUH6VwRv?= =?us-ascii?Q?AhcLFykQYpQrGxcNtLZ2LG+clgaHw4JnF3YnWiMBVA8/XHg6I6ocz+8PmfZK?= =?us-ascii?Q?NEkuNhGfDHbNRTLi7h5fpOcuMtHCGNmJFtZXCPU8jgnZPoeBRspzlXcBq+mG?= =?us-ascii?Q?9i35UBryDLQ8bEdKvcLstP+GCnDDsT5/ZdLRe1DqW8HlCkwAwB/i9sM1EeH7?= =?us-ascii?Q?LRHDDNXu9FRAHPlHlUpnlIU1rPv3ltvn86gzA8FGG7wUVu6H3WEjiTv7xArU?= =?us-ascii?Q?vbXy2DEN+iT7/o71zxUxfyHPNr9oQLI4+XA23oBFcydPzOfVlB944Iu4fWOr?= =?us-ascii?Q?D5SOs/6NQZGP1nTYmgomMcXyA166+dyHiu3C0wyLtZ7gxu2jQED2vJO+mFqW?= =?us-ascii?Q?eqHeo1OsoU8w8dm9RbRv1NRRAp3BhI2hd08eHLzeQtteVXiCU9zJGXpUIAAQ?= =?us-ascii?Q?HRpEXk64K2r8ltHNebRXd78Y+3wOzuvBNg2+uuVsL+wjmh2a1c0C/xWcmS1p?= =?us-ascii?Q?sQmJ3HMoH+U8b08SrALuW4eu48KulINkMbYkyvYcPrMjrVO1PMI+HRsvbXso?= =?us-ascii?Q?1NVaGZAEyqcMSHDAeIjbCuBuMIcJ5pu5dRZSi53irEKsSzp/lQ2m8MBI6r1T?= =?us-ascii?Q?meZmQgGzafv6dT+bOZ+t5kzaWOmCI1j5+n6mmVta8BynfyyWj3NBYLtwH+DL?= =?us-ascii?Q?/gPdOkY7qnyE7qUMPA7F7SQ/dXtiEdxqs9E90CBPYhjqubCucX/yvxy+7It0?= =?us-ascii?Q?dMnsIaT7wHgDb6/BSNnCbASK0SZllQ2vSgXkXbdEHuv36VwZKn+eDMZjse5c?= =?us-ascii?Q?XfS+2/u//jT2B7Q/enW3P3QaTRpqaS0E3/I0GR9C0UG+GOzduHyTjgf8TRWw?= =?us-ascii?Q?rEOMCS0gzKXGZEOYODJmVs+6uA9nFtD4g5CpJWq3uJjGd8xXM8U359K00x/U?= =?us-ascii?Q?bQ2XDMIcNbd6yJ0XLC3HkseI9V/8ayHCJCxz/blY3ms6999VWS6d2YDbGyv3?= =?us-ascii?Q?cs/ehAhVEIdUavdIzOnm5Isk7exbol/e8e3fbtXnrPsMXdiFlGZAP2ZDP/xT?= =?us-ascii?Q?8Ai3U98nJDZCkXAfLLkODTYz2A4prDRgMYzkNFxGy1q3VQeGe18PAbUHpoD+?= =?us-ascii?Q?Cm/ynyoVXHdEmYIf6IHOuiGcIE7s8gR4OJzUgUIzrSfSyRXFXwibqWvrEPU3?= =?us-ascii?Q?1BXHsrrDIzpAqmgye6a/lZ/dZXAMRPM9QcBHCyfVGAu2xb2kkIqDxVYVfxTY?= =?us-ascii?Q?m+aDHD25g3zHlHbPOQ1J6pKWPwl5dzH6yL8eYIL6fbmUZzgbIZg7sgOfaR5L?= =?us-ascii?Q?hE19iTW5k+uyx85AACUDq+glQxgZFqPfHpj7efdOHrwPr4cpfV0gjsVmNXhl?= =?us-ascii?Q?UmKOhwZuLMz/lXGb+sLRcJx6b8GRaYg0MSywhzZisoXsEDA/w3y+CzjGqHQq?= =?us-ascii?Q?itbveEy+FSe6qrvulylh7yc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 026169a8-3f03-455b-597d-08d9fc6af282 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2022 16:37:31.4528 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KK7wuyFYR4B9aE9fSWeT0Bc8MHlZxStc2msXSe/zVuGOgCuPcRc+Y9CpmrSpBexpDAaoQIm30bKYNyE+OWjvEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3726 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Raslan Darawsheh > Sent: Wednesday, March 2, 2022 6:32 PM > To: Bing Zhao ; Slava Ovsiienko > ; Matan Azrad > Cc: dev@dpdk.org; Jack Min > Subject: RE: [PATCH] net/mlx5: fix matcher priority with ICMP or ICMPv6 >=20 > Hi, >=20 > > -----Original Message----- > > From: Bing Zhao > > Sent: Monday, February 28, 2022 1:42 PM > > To: Slava Ovsiienko ; Matan Azrad > > > > Cc: dev@dpdk.org; Raslan Darawsheh ; Jack Min > > > > Subject: [PATCH] net/mlx5: fix matcher priority with ICMP or ICMPv6 > > > > On TCP/IP-based layered network, ICMP is considered and implemented as > > part of layer 3 IP protocol. Actually, it is a user of the IP protocol > > and must be encapsulated within IP packets. There is no layer 4 > > protocol over ICMP. > > > > The rule with layer 4 should be matched prior to the rule only with > > layer 3 pattern when: > > 1. Both rules are created in the same table > > 2. Both rules could be hit > > 3. The rules has the same priority > > > > The steering result of the packet is indeterministic if there are > > rules with patterns IP and IP+ICMP in the same table with the same > > priority. Like TCP / UDP, a packet should hit the rule with a longer > > matching criterion. > > > > By treating the priority of ICMP/ICMPv6 as a layer 4 priority in the > > PMD internally, the IP+ICMP will be hit in prior to IP only. > > > > Fixes: d53aa89aea91 ("net/mlx5: support matching on ICMP/ICMP6") Added missing Cc: stable@dpdk.org > > > > Signed-off-by: Bing Zhao > > Acked-by: Viacheslav Ovsiienko >=20 > Patch applied to next-net-mlx, >=20 > Kindest regards, > Raslan Darawsheh