RE: [PATCH] net/mlx5: forbid direction attributes in transfer flow rules

[Raslan Darawsheh <rasland@nvidia.com>]

Hi,

> -----Original Message-----
> From: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Sent: Thursday, November 3, 2022 12:10 PM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH] net/mlx5: forbid direction attributes in transfer flow rules
> 
> Since [1] flow API forbids usage of direction attributes in transfer
> flow rules. This patch adapts mlx5 PMD to this requirement.
> 
> From this patch, flow rule validation in mxl5 PMD will reject transfer
> flow rules with any of the direction attributes set
> (i.e. 'ingress' or 'egress').
> As a result flow rule can only have one of 'ingress', 'egress' or
> 'transfer' attributes set.
> 
> This patch also changes the following:
> 
> - Control flow rules used in FDB are 'transfer' only.
> - Checks which assumed that 'transfer' can be used
>   with 'ingress' and 'egress' are reduced to just checking
>   for direction attributes, since all attributes are exclusive.
> - Flow rules for updating flow_tag are created for both ingress
>   and transfer flow rules which have MARK action.
> - Moves mlx5_flow_validate_attributes() function from generic flow
>   implementation to legacy Verbs flow engine implementation,
>   since it was used only there. Function is renamed accordingly.
>   Also removes checking if E-Switch uses DV in that
>   function, since if legacy Verbs flow engine is used,
>   then that is always not the case.
> 
> [1] commit bd2a4d4b2e3a ("ethdev: forbid direction attribute in
>                          transfer flow rules")
> 
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh