* [PATCH] net/mlx5: fix CQEs dumping for Tx
@ 2023-03-23 23:51 Alexander Kozyrev
2023-03-27 15:01 ` Matan Azrad
2023-03-28 8:38 ` Raslan Darawsheh
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Kozyrev @ 2023-03-23 23:51 UTC (permalink / raw)
To: dev; +Cc: stable, rasland, viacheslavo, matan
The regular CQE size can be 64 bytes or 128 bytes depending
on the cache line size. The error CQE is always 64 bytes long.
Only 64 bytes are dumped to the log file in case of Tx queue
recovery form the error. Use the CQE size, not the error CQE size.
Fixes: 957e45fb7b ("net/mlx5: handle Tx completion with error")
Cc: stable@dpdk.org
Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
---
drivers/net/mlx5/mlx5_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_tx.c b/drivers/net/mlx5/mlx5_tx.c
index a13c7e937c..14e1487e59 100644
--- a/drivers/net/mlx5/mlx5_tx.c
+++ b/drivers/net/mlx5/mlx5_tx.c
@@ -107,7 +107,7 @@ mlx5_tx_error_cqe_handle(struct mlx5_txq_data *__rte_restrict txq,
mlx5_dump_debug_information(name, "MLX5 Error CQ:",
(const void *)((uintptr_t)
txq->cqes),
- sizeof(*err_cqe) *
+ sizeof(struct mlx5_cqe) *
(1 << txq->cqe_n));
mlx5_dump_debug_information(name, "MLX5 Error SQ:",
(const void *)((uintptr_t)
--
2.18.2
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] net/mlx5: fix CQEs dumping for Tx
2023-03-23 23:51 [PATCH] net/mlx5: fix CQEs dumping for Tx Alexander Kozyrev
@ 2023-03-27 15:01 ` Matan Azrad
2023-03-28 8:38 ` Raslan Darawsheh
1 sibling, 0 replies; 3+ messages in thread
From: Matan Azrad @ 2023-03-27 15:01 UTC (permalink / raw)
To: Alexander Kozyrev, dev; +Cc: stable, Raslan Darawsheh, Slava Ovsiienko
From: Alexander Kozyrev
> The regular CQE size can be 64 bytes or 128 bytes depending on the cache
> line size. The error CQE is always 64 bytes long.
> Only 64 bytes are dumped to the log file in case of Tx queue recovery form
> the error. Use the CQE size, not the error CQE size.
>
> Fixes: 957e45fb7b ("net/mlx5: handle Tx completion with error")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] net/mlx5: fix CQEs dumping for Tx
2023-03-23 23:51 [PATCH] net/mlx5: fix CQEs dumping for Tx Alexander Kozyrev
2023-03-27 15:01 ` Matan Azrad
@ 2023-03-28 8:38 ` Raslan Darawsheh
1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2023-03-28 8:38 UTC (permalink / raw)
To: Alexander Kozyrev, dev; +Cc: stable, Slava Ovsiienko, Matan Azrad
Hi,
> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Friday, March 24, 2023 1:52 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Subject: [PATCH] net/mlx5: fix CQEs dumping for Tx
>
> The regular CQE size can be 64 bytes or 128 bytes depending on the cache
> line size. The error CQE is always 64 bytes long.
> Only 64 bytes are dumped to the log file in case of Tx queue recovery form
> the error. Use the CQE size, not the error CQE size.
>
> Fixes: 957e45fb7b ("net/mlx5: handle Tx completion with error")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-28 8:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23 23:51 [PATCH] net/mlx5: fix CQEs dumping for Tx Alexander Kozyrev
2023-03-27 15:01 ` Matan Azrad
2023-03-28 8:38 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).