From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA26AA034E; Mon, 21 Feb 2022 09:54:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8234A40DF6; Mon, 21 Feb 2022 09:54:33 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2084.outbound.protection.outlook.com [40.107.102.84]) by mails.dpdk.org (Postfix) with ESMTP id 5CB7B4068C for ; Mon, 21 Feb 2022 09:54:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kh9xgQ/6fxV2tRkDfgRhSqrwch9C8ZlMrinU8WWYSCcE9tqn//43wfXxtGvUoKxWtfsQjqpS49h3RzKEMJUsSMKUnrhZ+KW645Jcy4pgrBnyQOzN/rpN9Sr3ZWkBOtXzPpxXQWS8KjjW99GuH7MrDWRRduegdHlZ/1/qCOfme1CJYJKCIxNUZrVFPbPZSdTLnBZrcET0eaHTLsKVXm8hQN8M7NQqwlWwKP4BqqzfULDg0rV1QoADxiZ118hLcJCSy4WWQRIYQ1GJxZdduXOHfIDi1EV+Zg7JIXtWnQ9oMeTE11g4JwGbYfMDyNsr3+9YNMpIw6PHupWaiuM432PRVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tJgGsUPfMpalJT+zrvZcPcdoOcGzWvm62pGD2aUsbQs=; b=PHzPQW8k30cCRpizRuAXWeJjad9D6xySxTyHmhKqgqxTjSaK+G9W4uZvNQSN6abtklwQy+ha7vWQFTstY1TapoLhpv8ji1cz6m7WZPRS6C1qILAsN5fNfOL94WC8U5kBDLKV/whsmYW9tP02RdmcNzfED/KPESvt1vkC+A7jaccTTS68oV4ClcOUBf4/ApYdAj7Gq7hhjJx51SgiaEUjNT7ejFqcAXxh+an5EEk/BaEgdr1JhYEF6hj/V1GY2C1PQ14HzDdmB5yln21NolXqcudKK+Mwyh/KUwbEQjCB0Y2i0/08jNoA4NLZVwI7UEFGpLhS3/tfXvfUpkMVJfV/Sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tJgGsUPfMpalJT+zrvZcPcdoOcGzWvm62pGD2aUsbQs=; b=rbeI6BsejPO2yBqTrrvib3jcMjckch4YzKpW8IwxazxGN1djp3I2HpJFe2Mp06G53HpkyV4fP4Ami3p68YGqAjyR32yyO/6AfD8gnWYcF8jITQVLIWPTNEeU5VNhVWONiQQhTw3byBEcCSj/7WPwjR+lz+R9t2VDe0isMA6ZQBfNovsf9w1XpDEOeLxpCFhKb8XdhkgMigPUULR2ZZ/mKfjf4rTMsvilZ70kYLYVOjTuDoA3QM9b+1j1PHhL+Wkflq+9cW0Rf6v/azJUl8UwjPpkA7nMXPB7vzHwIXdLiTLGamjsM3PldJR3RqzjLgIa0yzAHXnUO6Awi/sBGl+GdQ== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by BYAPR12MB3304.namprd12.prod.outlook.com (2603:10b6:a03:139::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.22; Mon, 21 Feb 2022 08:54:30 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::c8a5:fe91:7c8d:5e84]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::c8a5:fe91:7c8d:5e84%5]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022 08:54:30 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko Subject: RE: [PATCH v2 00/20] mlx5: refactor devargs management Thread-Topic: [PATCH v2 00/20] mlx5: refactor devargs management Thread-Index: AQHYIYY38qy6gA2aZEWzIcgiuMc8aaydvfzQ Date: Mon, 21 Feb 2022 08:54:30 +0000 Message-ID: References: <20220127153950.812953-1-michaelba@nvidia.com> <20220214093511.1592698-1-michaelba@nvidia.com> In-Reply-To: <20220214093511.1592698-1-michaelba@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 645ab787-15ba-432f-af4d-08d9f517c640 x-ms-traffictypediagnostic: BYAPR12MB3304:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jr9KANP3s8/GBSW0VfB4lUhdMfGZpSQJlvwYXjk8xs/onEA32s+Zff90LqiK/EctG2qtWJURYj/9TRefb022G98Z4o21g6oT1bIEk2NJk/2+3Gh+OiZir8JXieL7b4Gsexg8dR6BSSQo85Log3TewHoJKhusTV/U0kPROVB+Nr/7AQIkX5VB0Nu/65JUiYnYerGjaFugtxFx+fxXcnwOeYcS6VHYJwWRpyK0sPGCW9I/rmHdy8tlQeZQEgJOrYG6IR6vb7OTXnrMXS0Ym4BDRkmB8IP7dggZ9e+trHXxxuQTjVocaRnf1VNBc74Murcw7bma6ULG+3AS8cDsl+K43M9EcT/nEpE+KXRZqwYPZ/vbvrLnI8FaFxK62gKM8M1SpNb0ENXgPQgPubH93WEXiJ5+5XTtV4cTSx08TR9yEFsyBFNymhk6XrmHa1SNFPePt9vkdlpTFDEvJiPzPTfqGfD6wfpN1VZQkv6fVL16jzDY0dDMWSIg4pNkGKffHZHF/RjoQrC4IIzdw3t5fB7gRMg9DGXynK4KhCw1Tte/xoj1v/dXWZLKziqaxz1HK2FeqtDH8+y59SMq59jYkJp7NyRpaenTlse6Qe1qMVhhwDqwlS43+gaq2m0UtI31ye1A/sCF6TvNmkA8iT1Nv3gSIgn3Q18eO72KyfKoecjjmU+I9Ttd2IvHmrDWVIed1tTezyWDbeUCVNGRc96vda0sxA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(66476007)(6506007)(52536014)(66556008)(107886003)(9686003)(66946007)(2906002)(66446008)(86362001)(26005)(186003)(4326008)(8676002)(5660300002)(122000001)(508600001)(38100700002)(7696005)(64756008)(53546011)(8936002)(71200400001)(76116006)(83380400001)(33656002)(38070700005)(316002)(55016003)(54906003)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BNu8rIrQLFE/qNYUyOJicBzBRmTsYNSKNQak5FJTRRwmA8CjZW+YUe7EpgH7?= =?us-ascii?Q?NBu9V2YmC4k+FhoOev7AV8rrxsMlpreeiE2IEz/xHhzi39lSR8uYWYyOAN7c?= =?us-ascii?Q?ptWPaYSrWj6nnjucT8jLtDPnARPn64Ek1sxMsGh07TCEAgZDQq8DdK7PBGj8?= =?us-ascii?Q?0SV5p7N7kjzgQKtnRQgCoHzbtDFDbnpLlZaEiEi2FyhnW9qzwFce38xXKYL/?= =?us-ascii?Q?JDZK+trAGDxITZEMd7RiHO/nbcAZoogCpKeT5ddwPl2PzjMMBN5BYIPpv/6E?= =?us-ascii?Q?xEjdj5PdRFxetjdd6xpHyii2whQnh0mBuVow4UEHV6J/KQIUcv5pBe7EzkqF?= =?us-ascii?Q?q50IuXGvBLDMXp9be1qZkorCdvBqBkw6VO9JX26qk6BXm5+Pqk7cnSVJ8ZpN?= =?us-ascii?Q?ZVHHmtg2JBVeaOetw1urIaoPIsz1pd4l2IFsNlGBDSWzQoCNzWlGlM1xN3Wa?= =?us-ascii?Q?qytD+QbfH5XWXXFp8v1ait7/L5/AnQP97gsw3K8w8piz+xWbb3zP3qncTQn3?= =?us-ascii?Q?yw21tOCnYpgft0RLqFx21s9PYIZclFC5eB1ZlG+U+0SZum0DzfK6Sr2KwSe3?= =?us-ascii?Q?tU2phpuk4crbMU2bZcLd4rrXyJvyuqleWI7vircXxMgzfUtTSguI+knre9PK?= =?us-ascii?Q?ztYSH/CIm8sdOlK1acDp3luQlD9A653lX1RO9/kQWy8G8zwMP9cVVia/Fcip?= =?us-ascii?Q?bTLHExu6ukTVNXNu3GWdNVOan8jmeOiO+k4T7QAMML4NZpBgM9nTleRqXAeg?= =?us-ascii?Q?GqpTdXyjpJ9dnxxd8F6MmcrtaZ9eAoZZ9NRih/AVFNLDpmbnpfqx6MmGvoK+?= =?us-ascii?Q?9Lv07A3pYz4OD9BF7n7OC4ox0i8CrbGPxSczxSjy1s8sfHd3ZXnrvpOp3HVE?= =?us-ascii?Q?7QJKbuN+Z81nypaVGEdOci2hMZ61dmJgwnagKCCEAs9+qhW/dglGQ2gTnum7?= =?us-ascii?Q?G53Am8zCwWIH5QJ/9+prkVUil+KVCYFC2mSa5Q78RjQTO7xAvy2fPHm3iSJ6?= =?us-ascii?Q?A4y5xuT4cMxTE+XKG64kaHm02xrjiQcoX33yjf7xMFtUfD783geVsfTHzP5v?= =?us-ascii?Q?F4+HsQS/Kx1ZDF1aA9sAU4pU94UkGQxh7wjm/JYIR+e7v427Ki3ALDYR91rR?= =?us-ascii?Q?6z0xOgmj+kY4ibLqupe6faj83jgAf8rwuC2HDFBBtyWn8Ji2Lp9lxhQrOQRK?= =?us-ascii?Q?Z8HepZ/2tYzqRPx6iwB+/XbE6DFJGI6qeGi4IYEz6Mw21q+0iUMn0I16xmSY?= =?us-ascii?Q?tUwFvgpePwTmsA1yuzW94b2kFqrsRGLVxNXDNfja0h03Ba29CGhlaCEyFvS8?= =?us-ascii?Q?H0ZXuRMsT8+FXIlNNS+mpdRVkjUdqd+sa6LwsY8mojyrkLQSF7wg5TO85cgB?= =?us-ascii?Q?qNBtErcW+i2c/4K2PEB4pskTtEA7izVlKoMek6v3YmR+AgUL7tJRfZcyJhXZ?= =?us-ascii?Q?6BuRrIbJhc56eO/H2QQhCD/buigwreacAENdxE56TuBRR8nnD9LN5sn85eI9?= =?us-ascii?Q?C/HoZACqe2VPBcnxmMeYronjKfZ6vu8H5z7JGsw+qyT+xUEuSAwmPQJ2KTRI?= =?us-ascii?Q?eMajqUkuPcwSa5S92gMcrhrWaFI5qQAad6PcFDxSbCD3rqaS2YkeGNhu7Mkp?= =?us-ascii?Q?UOQxPm76QwCE9k3zO1mcpJo=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 645ab787-15ba-432f-af4d-08d9f517c640 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2022 08:54:30.8035 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qZh9w+nZH+MCOFVDx2plATVtIKDGVkj3IN6X2cwWCBVIf+CMo6YlAkzATy1TX7nyJ8ruXXb8ALHPTbJw1qIw0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3304 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Michael Baum > Sent: Monday, February 14, 2022 11:35 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH v2 00/20] mlx5: refactor devargs management >=20 > v2: rebase + fix coverity issue. >=20 > These patches rearrange the management of the devargs on two different > levels. >=20 > The first splits the net driver's devargs into two categories, > device-dependent devargs and port-dependent devargs. > Arguments that depend on the device are updated once in the creation of > the shared device context structure, and do not change even if the user > has sent new devargs in the probe again. In contrast, the arguments that > depend on the port are updated separately for each port. >=20 > The second layer deals with the parsing of devargs in the common driver. > The common driver once parses the devargs into a dictionary, then sends > it to all the drivers that will use it during the their probing. Each > driver updates within dictionary which keys it has used, then the common > driver checks the updated dictionary and reports about unknown devargs. >=20 > Michael Baum (20): > net/mlx5: fix wrong check sibling device config mismatch > net/mlx5: fix ineffective metadata argument adjustment > net/mlx5: fix wrong place of ASO CT object release > net/mlx5: fix inconsistency errno update in SH creation > net/mlx5: remove declaration duplications > net/mlx5: remove checking devargs duplication > net/mlx5: remove HCA attr structure duplication > net/mlx5: remove DevX flag duplication > net/mlx5: remove Verbs query device duplication > common/mlx5: share VF checking function > net/mlx5: share realtime timestamp configure > net/mlx5: share counter config function > net/mlx5: add E-switch mode flag > net/mlx5: rearrange device attribute structure > net/mlx5: concentrate all device configurations > net/mlx5: add share device context config structure > net/mlx5: using function to detect operation by DevX > net/mlx5: separate per port configuration > common/mlx5: add check for common devargs in probing again > common/mlx5: refactor devargs management >=20 > drivers/common/mlx5/mlx5_common.c | 345 +++++++-- > drivers/common/mlx5/mlx5_common.h | 51 +- > drivers/common/mlx5/mlx5_common_pci.c | 18 + > drivers/common/mlx5/version.map | 3 + > drivers/compress/mlx5/mlx5_compress.c | 38 +- > drivers/crypto/mlx5/mlx5_crypto.c | 39 +- > drivers/net/mlx5/linux/mlx5_flow_os.c | 3 +- > drivers/net/mlx5/linux/mlx5_os.c | 887 +++++++++--------------- > drivers/net/mlx5/linux/mlx5_verbs.c | 9 +- > drivers/net/mlx5/linux/mlx5_vlan_os.c | 3 +- > drivers/net/mlx5/mlx5.c | 872 +++++++++++++++++------ > drivers/net/mlx5/mlx5.h | 216 +++--- > drivers/net/mlx5/mlx5_devx.c | 19 +- > drivers/net/mlx5/mlx5_ethdev.c | 31 +- > drivers/net/mlx5/mlx5_flow.c | 50 +- > drivers/net/mlx5/mlx5_flow.h | 2 +- > drivers/net/mlx5/mlx5_flow_dv.c | 93 ++- > drivers/net/mlx5/mlx5_flow_flex.c | 4 +- > drivers/net/mlx5/mlx5_flow_meter.c | 14 +- > drivers/net/mlx5/mlx5_rxmode.c | 8 +- > drivers/net/mlx5/mlx5_rxq.c | 49 +- > drivers/net/mlx5/mlx5_trigger.c | 35 +- > drivers/net/mlx5/mlx5_tx.c | 2 +- > drivers/net/mlx5/mlx5_txpp.c | 14 +- > drivers/net/mlx5/mlx5_txq.c | 62 +- > drivers/net/mlx5/mlx5_vlan.c | 4 +- > drivers/net/mlx5/windows/mlx5_flow_os.c | 2 +- > drivers/net/mlx5/windows/mlx5_os.c | 342 +++------ > drivers/regex/mlx5/mlx5_regex.c | 3 +- > drivers/vdpa/mlx5/mlx5_vdpa.c | 32 +- > 30 files changed, 1842 insertions(+), 1408 deletions(-) >=20 > -- > 2.25.1 Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh