From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E827A034C; Thu, 24 Feb 2022 14:14:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FAF141155; Thu, 24 Feb 2022 14:14:54 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2071.outbound.protection.outlook.com [40.107.236.71]) by mails.dpdk.org (Postfix) with ESMTP id 226524114D for ; Thu, 24 Feb 2022 14:14:53 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l2xI9/++jv1IUXyCt/Gxk+vDlcmR9DaYXvVXHGSwi1n0louJpZc86AUwTO4RbpCTJwuyYwll1ubMc45ma6t9kn3mAYXF+SOJ3vCkTGrLLZsGN3AYchOikokS007McpKmHye28df+QFO+U5RHmlKc/uAShjK0rnS/SdnkBUCTPq8bg5lV6r2V1ua1mPhzt+tSY06OOzLNl8n7jg5lpsJ0KHqy+2ByrDlAhFgHxl3Xz6vCDECJmc8F65TqCzsloAFJ1dOXRdW02BPbf2SBDukwG9LOjGfOG90YnSoZli5GJbu6h/ohIDyqpWfY13tLlJyxSlXmCXiEDLKFV2QmnaVgFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=afmRderhEpEkMHIgwJSdQPGhQD4J2fbldvJGbklbDLA=; b=cuPFDbLJuHr0JZY7YVkVfX4UhPTGlTThYonOlzR/FH/MNHkkcmHMd7qONz0K7zjd8awvVfzMK7+3Q5bMlz/g855FK0CTtlHyJyUl1n09ettojOxDIk1tRb20yEImK4gxVk6H3pUfu26BvAbP8QUiXFP8ZjF+KIDAvYPTvzsV4NLECPzF2yv1zCj6MZm3KCrVjexNI8QZqyv7KSHd4m7WyoAqLA42rC1L+U7sXMJX14La9PVOcqBjiuKPIbOMG3hYfgZIL4ElFH7O4h9cnbXs02OIsP+ixNwYCSMaxgBi191afBauXkn6P6DpAWBCFgvvNXHQSMWqmo5M/5DGHPPjZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=afmRderhEpEkMHIgwJSdQPGhQD4J2fbldvJGbklbDLA=; b=PvA8ieqo+drRixZS7cGVxI9Gi6GVOVdGODVjsvAAVX0WBca5lrSEvI/Z55SzRnRmdDDcgEfKBq15uKdHI+vg4z4cpaVj0XOP7TcDMf4mIos+2PF7HsNCFV+r8d5CmIWxTooEiJdw25Kv3HgFY5pHfrNITWvuHVb4W0hg/B/IYFKxRTU6m999HrWh8Dx6k1/M9C9hHbtKow5srW3i4w+4QjnQhV9ywzXsCXs1i9vo4AmMN3vBnHAEx2jWfJV5ikCpsnMWsLh9oA5bfmef97VRc+i/KQ5nVqYwQ6dwAYO+CUxjyTteeMb1CK0EkgvOniSA7hmcOTJl/mK2idCdJQ0grg== Received: from SN6PR12MB2784.namprd12.prod.outlook.com (2603:10b6:805:68::33) by DM6PR12MB2908.namprd12.prod.outlook.com (2603:10b6:5:185::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Thu, 24 Feb 2022 13:14:51 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by SN6PR12MB2784.namprd12.prod.outlook.com (2603:10b6:805:68::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Thu, 24 Feb 2022 13:14:49 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::c8a5:fe91:7c8d:5e84]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::c8a5:fe91:7c8d:5e84%5]) with mapi id 15.20.4995.027; Thu, 24 Feb 2022 13:14:48 +0000 From: Raslan Darawsheh To: Ferruh Yigit , Alexander Kozyrev , "dev@dpdk.org" CC: Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "ivan.malov@oktetlabs.ru" , "andrew.rybchenko@oktetlabs.ru" , "mohammad.abdul.awal@intel.com" , "qi.z.zhang@intel.com" , "jerinj@marvell.com" , "ajit.khaparde@broadcom.com" , "bruce.richardson@intel.com" Subject: RE: [PATCH v10 00/11] ethdev: datapath-focused flow rules management Thread-Topic: [PATCH v10 00/11] ethdev: datapath-focused flow rules management Thread-Index: AQHYKGHlZ4M7JzC6H0CxYjMgdYScoKyirjeAgAABnQCAAABA0A== Date: Thu, 24 Feb 2022 13:14:48 +0000 Message-ID: References: <20220221230240.2409665-1-akozyrev@nvidia.com> <20220223030240.2506513-1-akozyrev@nvidia.com> <855041b1-a6f6-6a48-8785-70e1c758b175@intel.com> <9a95ec1a-e21d-77c9-e6e3-0a8163998b9b@intel.com> In-Reply-To: <9a95ec1a-e21d-77c9-e6e3-0a8163998b9b@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d184c051-79fa-4053-2b68-08d9f797a297 x-ms-traffictypediagnostic: SN6PR12MB2784:EE_|DM6PR12MB2908:EE_ x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: t+s9KWFySSSryqBc7JKshXrB2JAHzeCZ4hivIr26jgTTByJLd7YaMvK62gabq2koKMfwaEbOI9y2dRSwQ7pXHMm1Rv23cz/xBHOvpLffZ81qWtlH79C8F8uTQscA+tk7HLY0zNFhKW1gYtN8GTpU9iFJ9Amu6BD4/q6WQQnS1zj0qjWjreUHJfXupPWPAzIcip4RpKH0Uc9WQxGgmiJ4Un0S4PqXBPLH4bLITkI7X1UNw0bzK3tRde4AomiwslFTEIOD4ag4oz/l2AS/E8EfLndloH4I1aWYE3pYM3c52PV0KydlL76/XNsUtcxR+1cor6TdwbQcowhgs3WDFTa1l0uTobWCVDS3fWoHGzbhHKZLrQxDCD+nIFHDSAvGZA2tH1vgCWkjmKaWZM0qwKymAVn5X/QSq5KejEZjCJ2WguuM4/l5pNTbFCBc7WGPd3jgLYQaxv7YbQ6HkUzf8+pGs0CQJ8PfYwXuu9famIaBhkgZN96/ZQviFylWq4KKuqCFq/i9ZtbPTXFtG1iVJk6RWk6EBkjc/P537OtwSgGBfGIaZuy58kDgGFR9ezWHIc9ZANyhIZKQeQmIryc4+RF1+viP3/D7b0UE4v08vylDGqEZyob+aaQ5oiE05KfjGzN8sqctqyaMQAGO+jkXcMmHS5weeNF6g1M+fNsF0idadByFXHaNIpeI4ZjG99EYwzb6QAezj6Vv8kt5PhSDmHiDnA2iAWxpdT/zVE08T66EUYIVOdLii0Rgd+P80uzj3MMP6q1pikNqGpNr0vb/rUixcnY0IfEnRQXkjAGxyxLayR8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR12MB2784.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(316002)(8676002)(4326008)(54906003)(83380400001)(33656002)(110136005)(53546011)(38100700002)(2906002)(7696005)(6506007)(52536014)(8936002)(66946007)(55016003)(66556008)(26005)(66446008)(64756008)(186003)(76116006)(66476007)(5660300002)(9686003)(86362001)(508600001)(38070700005)(7416002)(71200400001)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?NCPUf8NPDdkk9i9buIXpsGR9TnmZrCdz5k0UbdI9FBkWbhKqEo8lt/PqVg?= =?iso-8859-1?Q?yr+vSCa82CksIlotBhsq4iKItrCYBiNpPQtK0AN5YD34tmTxi65xV39fkf?= =?iso-8859-1?Q?JRVXlcELlve9bOtdX+86UKp7eMp9iY/9LH/HmIg/Ja+D69IbVoXzULo5Hu?= =?iso-8859-1?Q?l5X5KGNm/tPlbALVp82nXILN4khJIN8A0m+/WU5a7PLqv8YhRAA1b6ImSC?= =?iso-8859-1?Q?s1jTul8lMhpWHy+KkDr3BSWpYhj9uYqUtgovp3BIIpTL0bg1GKQ6lc3isf?= =?iso-8859-1?Q?M/DDP3GCfu+zUndWxefqAHeBGFI6z/At4nT1mpVthE/HUMKbJXm4FCDbLQ?= =?iso-8859-1?Q?WHkr+Y7lgqLfE8sB28zXoo8kdi2oIU8IdJ7uDqLTPHfUlRvegDD801KDJy?= =?iso-8859-1?Q?lE9AFw4+pjEtGFANrqAWnPEa0KGqy8fVlzzgApoI7lqfSbHhfRKJwsVpLW?= =?iso-8859-1?Q?I7MJtNH7/XcfyGZUHUde0AtOZrXawlCBkC0gXb/v7Srn/OGQN7tUeXU7HM?= =?iso-8859-1?Q?oHlodJ6sDdRO3tVF9YFhUj0hP/uoGYniuKQvGB4LIgRcA1DeHSZfBBEe4I?= =?iso-8859-1?Q?w/oJDOP5IeRn8EjUKjO+Ge/l8jVCMY0HEgbJc+Tyy/kP5dZohtNKAFWKa3?= =?iso-8859-1?Q?tDhdgbyq2EdXEGihFJfjRY2pA4SWleci7ccnONAoVpI04UTuOGKCge3Y/1?= =?iso-8859-1?Q?Ub7PHYjIBOPSs21DSAQu34BYnzVWT0FlOXGnFcUEVzIZm94NYvAXMpiNsv?= =?iso-8859-1?Q?/+vvgJKu2AP7ZZkCfFKEyrvKfkISABViA2p153ho5x9MrrmtfD9hVcO2ob?= =?iso-8859-1?Q?X4AXKKkXVqCXPhKzJItiE604JvDA1IWopF5lUdbrMtz7f89LheMUhMur8+?= =?iso-8859-1?Q?qTdkeOr8/tReZbWfAmpDSPosL4dr9uhhMJF5twg3Owcwk9f0FLaZIDcT2u?= =?iso-8859-1?Q?LXhy6sujIEAlWWRVKw/+zumi3k3BhYQsul7PtBo7+MLerGJldAmRScuUZM?= =?iso-8859-1?Q?N956eYJNE9rphHv0K2mPCuc4guLd0C8gV/H71RXB5DGPciEJBv8LgV4YGW?= =?iso-8859-1?Q?qlwQwjsn5vyfbSAVDy+mYX0aqMS6awmniS5SQ59g/pGiRvpZp3qSK4ZWka?= =?iso-8859-1?Q?V2SIQlo3L9pfgNwNtFI0TL0QJS6SL1GMHHwSVKUcXHNYK4CZmOIP0r1tSj?= =?iso-8859-1?Q?452Sb5VtsKCLaWb9kcNpT18NJmi/EPxoXjOpGzRzUxNZwR75Gl4Zn6RBUi?= =?iso-8859-1?Q?LwfuwxdN8dXNRd/Hd6epRZvCkSoN0cyl1GOmUZ3RiVVExQs6QCVoCmEb3l?= =?iso-8859-1?Q?JtZ3USfMaGS+UC2iOQE8zp7CrnGS0N6zU+05BPIhv9nUQkyIBrEfOkMndc?= =?iso-8859-1?Q?icrJK1JRsXdxP+nBi0eKU11szePvVr/6Hu8D5okQ4s7d/OsmTUIWhjN7PO?= =?iso-8859-1?Q?3WUAAYvDo0uqkmaY2z2rm+BQ/q/i2OXFrBqqO3u3UrfmduKGiv3UGAeo3T?= =?iso-8859-1?Q?tfFFwIKp1y50OJQajaZWgQuoPuRZNEp2lzh/U2EVwOGdfhnfg4CBGQLG4b?= =?iso-8859-1?Q?DLHyWkZsMLrL87tD9HcrOQFHGw575PSVkDDJ6WIMMnFDz1decFc+QbJSO4?= =?iso-8859-1?Q?eQrpvqKBgmhOV4NpOJdFWzO20Er8a9DY4U3DqiyUV/mIr0FaahLR53Ny9J?= =?iso-8859-1?Q?RE7dW7FwbO0FuPeXcCM=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d184c051-79fa-4053-2b68-08d9f797a297 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 13:14:48.8636 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oCmDYOgEpbEjChIxPHYl+pP4a3pWA43sjOJZBgs1+nJhx1GYZL762PVhVm9tvmzLxJcD7haOmZc8GWEBBXvnRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2908 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ferruh Yigit > Sent: Thursday, February 24, 2022 3:13 PM > To: Alexander Kozyrev ; dev@dpdk.org; Raslan > Darawsheh > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon > (EXTERNAL) ; ivan.malov@oktetlabs.ru; > andrew.rybchenko@oktetlabs.ru; mohammad.abdul.awal@intel.com; > qi.z.zhang@intel.com; jerinj@marvell.com; ajit.khaparde@broadcom.com; > bruce.richardson@intel.com > Subject: Re: [PATCH v10 00/11] ethdev: datapath-focused flow rules > management >=20 > On 2/24/2022 1:07 PM, Ferruh Yigit wrote: > > On 2/23/2022 3:02 AM, Alexander Kozyrev wrote: > >> Three major changes to a generic RTE Flow API were implemented in > >> order to speed up flow rule insertion/destruction and adapt the API > >> to the needs of a datapath-focused flow rules management applications: > >> > >> 1. Pre-configuration hints. > >> Application may give us some hints on what type of resources are > needed. > >> Introduce the configuration routine to prepare all the needed > >> resources inside a PMD/HW before any flow rules are created at the ini= t > stage. > >> > >> 2. Flow grouping using templates. > >> Use the knowledge about which flow rules are to be used in an > >> application and prepare item and action templates for them in > >> advance. Group flow rules with common patterns and actions together > for better resource management. > >> > >> 3. Queue-based flow management. > >> Perform flow rule insertion/destruction asynchronously to spare the > >> datapath from blocking on RTE Flow API and allow it to continue with > packet processing. > >> Enqueue flow rules operations and poll for the results later. > >> > >> testpmd examples are part of the patch series. PMD changes will follow= . > >> > >> > RFC:https://patchwork.dpdk.org/project/dpdk/cover/20211006044835.3936 > >> 226-1-akozyrev@nvidia.com/ > >> > >> Signed-off-by: Alexander Kozyrev > >> Acked-by: Ori Kam > >> Acked-by: Ajit Khaparde > >> > >> --- > >> v10: removed missed check in async API > >> > >> v9: > >> - changed sanity checks order > >> - added reconfiguration explanation > >> - added remarks on mandatory direction > >> - renamed operation attributes > >> - removed all checks in async API > >> - removed all errno descriptions > >> > >> v8: fixed documentation indentation > >> > >> v7: > >> - added sanity checks and device state validation > >> - added flow engine state validation > >> - added ingress/egress/transfer attibutes to templates > >> - moved user_data to a parameter list > >> - renamed asynchronous functions from "_q_" to"_async_" > >> - created a separate commit for indirect actions > >> > >> v6: addressed more review comments > >> - fixed typos > >> - rewrote code snippets > >> - add a way to get queue size > >> - renamed port/queue attibutes parameters > >> > >> v5: changed titles for testpmd commits > >> > >> v4: > >> - removed structures versioning > >> - introduced new rte_flow_port_info structure for rte_flow_info_get > >> API > >> - renamed rte_flow_table_create to rte_flow_template_table_create > >> > >> v3: addressed review comments and updated documentation > >> - added API to get info about pre-configurable resources > >> - renamed rte_flow_item_template to rte_flow_pattern_template > >> - renamed drain operation attribute to postpone > >> - renamed rte_flow_q_drain to rte_flow_q_push > >> - renamed rte_flow_q_dequeue to rte_flow_q_pull > >> > >> v2: fixed patch series thread > >> > >> Alexander Kozyrev (11): > >> =A0=A0 ethdev: introduce flow engine configuration > >> =A0=A0 ethdev: add flow item/action templates > >> =A0=A0 ethdev: bring in async queue-based flow rules operations > >> =A0=A0 ethdev: bring in async indirect actions operations > >> =A0=A0 app/testpmd: add flow engine configuration > >> =A0=A0 app/testpmd: add flow template management > >> =A0=A0 app/testpmd: add flow table management > >> =A0=A0 app/testpmd: add async flow create/destroy operations > >> =A0=A0 app/testpmd: add flow queue push operation > >> =A0=A0 app/testpmd: add flow queue pull operation > >> =A0=A0 app/testpmd: add async indirect actions operations > > > > Series applied to dpdk-next-net/main, thanks. >=20 > +Raslan, >=20 > As ethdev patches merged, can proceed with driver ones. Thanks for the update, I'll move forward with merging the driver patches on= ce testing for them is complete.=20 Kindest regards, Raslan Darawsheh