From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D0B7A00C5; Mon, 15 Aug 2022 09:29:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC46240143; Mon, 15 Aug 2022 09:29:40 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2064.outbound.protection.outlook.com [40.107.223.64]) by mails.dpdk.org (Postfix) with ESMTP id BBA27400EF; Mon, 15 Aug 2022 09:29:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XUgjk0Y1j59UNZ36sP3SZKkM/QAHKHlBWKUI8Z8gIVKhKZBXPHVgY+ykk33o+sB8l62NeyjsniaFMHQ9Gmja+zxVijZ2WiuwJvbLdq8ish6donFlolEjPMwiXbWyE5+QB4wTOgoZsCWJh19Qj9zG4OJJrczRLOo79/ukYcz184QIZvvx5z5tJXQVuY7dxBx4RNlaNbMfOnYSakCqP/l985tCFRKfhyqyLpQfivjLq2gVbknEEa/hLwLtvq7uERt5sCa4lR9Y0KvTlCaMEVNlodZySyrTt/F+5M+VFwUpVGP5F8TNwEqkhceOFrHbSqgTTJenuEKUdyyrxnCzMIXGFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gT8EkP3AFjdxN+q5zFZa7NqTqRpi9fazdvV/R9LkQuo=; b=ocGu7vpVgk2ifHBl0VMNrmlA6vfgB6SaQeUaPiJVcmnVjAnKfViEHXmiV0tEcAcEGmMc+y/94F5DiqPcU1EOspnEkqHXZaU86UiSk43eaYMF317N81ZP2O1nVprATpAciB8TTAqVIayONUtdiv9Ibfa/+Ijcb4HzvJTxldUZPRdGXvHNenBzEUnl8l4YZash4BZCdj6rEtP3Tq7OdZVGgHcctGkEMquTYdwFyzG2AEqBpuns7WIAlhebRXwSfloHWJh1BjXuOfm/yDI1FKMBCPLBN8DS4l7k3YQTkE+QXpf+3UGPki7qZJFgfcr6O2N9YFpZsYpNex/izBnEajEOXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gT8EkP3AFjdxN+q5zFZa7NqTqRpi9fazdvV/R9LkQuo=; b=BYqE92XtBKa+sazUYRXF6PwHWBy5aeJYYakITueu5uYmp+V5k99fNyOAWb729oy/Lk+QuwEExI/HPeLfRTuQnpUfgFmv3JvPOZ1OoZJUZpIsSfN88USMF3t4/FBfMfoghMCasUHZwdI2LPhe5s7WCXXqWirg9KRID4xaKejPctR5qxrb3Hgyp3pRIoZxfWrW/etloXkVcY/3e2tTo7naxmHt9byYRIWuACa01MTWko0mutj7TwL92+B/aXO2qW6ZcKNY4hsD7sBKc9XN7706kByFJ55h33VL6Ts2G8FLXusoqTCzJ6qqHt49/mGTVw5HaVZyt3uYZZ/yUjugZSsUJQ== Received: from BYAPR12MB3078.namprd12.prod.outlook.com (2603:10b6:a03:a8::31) by SJ0PR12MB6966.namprd12.prod.outlook.com (2603:10b6:a03:449::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Mon, 15 Aug 2022 07:29:36 +0000 Received: from BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::acbb:9c84:ec42:78a3]) by BYAPR12MB3078.namprd12.prod.outlook.com ([fe80::acbb:9c84:ec42:78a3%5]) with mapi id 15.20.5504.020; Mon, 15 Aug 2022 07:29:35 +0000 From: Raslan Darawsheh To: Michael Baum , "dev@dpdk.org" CC: Matan Azrad , Slava Ovsiienko , "stable@dpdk.org" , Gal Shalom Subject: RE: [PATCH] net/mlx5: fix detection of LRO support Thread-Topic: [PATCH] net/mlx5: fix detection of LRO support Thread-Index: AQHYobPPbDsgP5MGq0ml7X2Wtmr+RK2vrgqg Date: Mon, 15 Aug 2022 07:29:35 +0000 Message-ID: References: <20220727122406.1609242-1-michaelba@nvidia.com> In-Reply-To: <20220727122406.1609242-1-michaelba@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a831f06b-d710-4899-b061-08da7e8fe78f x-ms-traffictypediagnostic: SJ0PR12MB6966:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jHI8szTzwm9S5TqSQXWSBIIbkjAFlHMQA/KgmCrvet3yUA41xPyHA1so189KtmAKFf/SurRHlmvvWoqhPhnugxFIOIMgmPTFCzuXRcS7m+Ih++MCaedoR9kPzO0a3GQ69YckOyt9NRuutVBX/Php+BnAKZqURWVd71LIc2DYNk/QHb4OWYGa00ahRJvj0Esc36gl8pBOZEoIrNfJJoHsW09RLch8vNQ06vhJdw4wg4tNDBA0x0iD5VV5xY5J3723TlRzWU31XDuYdrnXlTBU67csMLr4NA2IfeHUarucPqjTYwZI4ejns7XhaXOKs5uHpwasQbJYGkldsN2yMPM7vcRmwVismpMwxGR1bBZ4xuRmbgRuWeqPYccJsY166GZvYyT8OAJ0gL4+a+wBM9keQXnTaZYu6hzuj9abbMnzAcXHF52qMuxZXfnKCIhnWkpVVygBIhzMX5Zum6EPG8wuc1eEpbTsdnhlStGd2b6LJ/DA6G2M9Bfif/t8uzqZecGalwTo7ScZ3bfKslgpCShVMzRpGGIbfp33KQTUgGyqlKbouwiZIBzPWrSIEGLOlv2V3NtN22hsnAU/0W6As0lDEzCqzJMuTYTciaUfOSpIxGiOvq72cZhTarUGJ2Y1gbpWX9gLRbpdHsNtqFGLuHgUx0WIS52dsxN9So4R+ZRp6omgmj30gNtfXTmNi9R1XB+Pe4gBqTOkx+mEU9HFFfVZIlYK3lr+ffAncv1li4LhuCnSyJu+ihoyiFLFlVjtaE1YtxGJXZ9g2aGcph0MtIoVv1xYebInsvyvuR2yO4PiOHWwmpgFvk1fIjZeogNq9MI0 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB3078.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(346002)(396003)(136003)(376002)(366004)(2906002)(38070700005)(8936002)(83380400001)(122000001)(38100700002)(110136005)(450100002)(55016003)(4744005)(8676002)(66446008)(107886003)(478600001)(76116006)(54906003)(66946007)(186003)(86362001)(52536014)(6506007)(64756008)(9686003)(66476007)(7696005)(41300700001)(26005)(5660300002)(66556008)(33656002)(53546011)(316002)(4326008)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kqdT3bJJGwZop7xhdPuwiF0VcdKcW92F0ahq+Y2bikllkBrMIFFsQIQW8Pcz?= =?us-ascii?Q?Nb3OXw8Lv9AEAFTsDl4DX6jLHoE44kaV6XltX/L/PQRPGQGgF+q/qbIsjS+L?= =?us-ascii?Q?WC5A3H9jEgGRI9KCEMb7b5COfEf1vCtpz880pp8VjnT9jkWMqWelP/U0VGRg?= =?us-ascii?Q?jIu+03ZCzOYIcq7wJpwk2S6/w0znWuoYkFQNUX+/fg6jplajtJ0R8bpliMdX?= =?us-ascii?Q?zwPrfYwHalv0TvXTDmoM3hVbJ8mynlIP9BDd1q0sCsjTNRxmv/AVfzhmXgbk?= =?us-ascii?Q?jK11c8lvvmiVmlUSBqKApCt9a8ES45tNwDWjpP7xJBelA5AwSgbSvz9XX1pg?= =?us-ascii?Q?BeYR8YrQgN0V8C7gcsiMkseuwz5kA5blVIB7/aF+sRqoIGMOuupIEd2EY3YF?= =?us-ascii?Q?CTFMz6H5OknA11IH70sIuEBqGr+JtmYiCyGz0HReGm0QIDfznlM72CnPDaoV?= =?us-ascii?Q?qAx5r2q/3UC6BID4WF8NSFV0E7AbndgYMd7Gzal/yDB0+FU1LwFxrUPZZurD?= =?us-ascii?Q?D73qn4r+4NkytyrvfGlJBOMiOO9zGDxnP/JFchHch8YlZRYqlxCUNWnXTb2l?= =?us-ascii?Q?DopIbk/NfFUy+P/Ae9DsAZMWLqz3pt7Dp95jJg727HJsFfwfcIMaIRMJL5fq?= =?us-ascii?Q?HdeDQxBe41zpKB/aYoegULSXvuGhSrIbQp5NIL8kyFKPD07SeShJlAUwsbA5?= =?us-ascii?Q?wcZ1t5VNzpbf4i1s56CQvDMmSs47v59cisCP2DCjpZdCK+25NKWEVp/wHLDS?= =?us-ascii?Q?LymTBYegV87b3dOuv33JCTv+YjfMY5Hm26WbG3pwNIQ+Ex5c08oAvV49wmsD?= =?us-ascii?Q?+oUWrMiBHJhYMvNE0yT1QvaQo6n+cRNvN7A+RNtCMZT2UzbPoAQpoVsmyOPW?= =?us-ascii?Q?WwN7HZ85JSjZXPW5BO/IeExtL6NpBTpFWjbRzr7IlGQ07bE3HMiqkLzLlzst?= =?us-ascii?Q?drM7gtiiq4PN3Rq4FYkXhFoW5cGrSOYSRKAPOvD57IUdRlckX/4t8k8NOvdA?= =?us-ascii?Q?+ShLzZ833BDQFbuNGRhtiSBTm7JREyuSWhaipj6WY24bqwegyjNr+Z/sVETO?= =?us-ascii?Q?jbju9v9HGUravzbMMT2UlS9uxDQT95jKmhGdFIrvCihXvOAyS1oEMq0OCBHa?= =?us-ascii?Q?JeSORzfrdk0onpOW+n1/HxpllPj193tagfqHsZluS/3QNDGFgloibs0Fi31z?= =?us-ascii?Q?7o7Mqkd6NReIWVDElXKVi9iOKopxHjgUaGgwSAWM2phQx7IKQJdBalqhhOVt?= =?us-ascii?Q?PIYHw3BlsEnUP5rujaLUVGFjVrTWVzPGG6Li6hoQJINrK0PVcC58pYDQW1ui?= =?us-ascii?Q?Kn7U1tZddzIACStIhoO4y0/i4DGnpKfEq+6F+9E1/FaMaQNcObhrAW8xmJ+b?= =?us-ascii?Q?mC1hZKrMbzyIyfkgO/IwMCF9dkOLhbCghREAFw/KLnyMsIjKDf0dJh7Y9Poa?= =?us-ascii?Q?Er/K2H0oNkdkAsEMcArChdGx6EZ7wPjChCHTpSCt/p0n0W9dHd+Sj+zLH87E?= =?us-ascii?Q?HsvL0dsh8jl1c0reoH6DoZ9XLzO/wXB/BjYBrQM8rTcS9WAvNd8AbcMdXLfV?= =?us-ascii?Q?CoI6mTtIBVXJpay5MKMxFlVhdVPsZ07grRLTcfuh?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3078.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a831f06b-d710-4899-b061-08da7e8fe78f X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2022 07:29:35.6410 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jtxV7IlfBJRYqBBS2PsCBT/i9ZUq2G41rJibBEpI2Js9Vkj1MulSn4JMGft0Pcu8gZeK8SG+yMy1wZbKf3h3hQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6966 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Michael Baum > Sent: Wednesday, July 27, 2022 3:24 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; Michael > Baum ; stable@dpdk.org; Gal Shalom > > Subject: [PATCH] net/mlx5: fix detection of LRO support >=20 > One of the conditions to allow LRO offload is the DV configuration. >=20 > The function incorrectly checks the DV configuration before initializing = it by > the user devarg; hence, LRO cannot be allowed. >=20 > This patch moves this check to mlx5_shared_dev_ctx_args_config, where DV > configuration is initialized. >=20 > Fixes: c4b862013598 ("net/mlx5: refactor to detect operation by DevX") > Cc: michaelba@nvidia.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Michael Baum > Reported-by: Gal Shalom > Acked-by: Matan Azrad Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh