From: Tal Shnaiderman <talshn@nvidia.com>
To: John Alexander <John.Alexander@datapath.co.uk>,
"dev@dpdk.org" <dev@dpdk.org>,
Harini Ramakrishnan <Harini.Ramakrishnan@microsoft.com>
Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
"pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>,
"ranjit.menon@intel.com" <ranjit.menon@intel.com>,
"navasile@linux.microsoft.com" <navasile@linux.microsoft.com>,
"dmitrym@microsoft.com" <dmitrym@microsoft.com>,
Ophir Munk <ophirmu@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v2] eal/windows: export all built functions for clang
Date: Wed, 7 Oct 2020 14:14:07 +0000 [thread overview]
Message-ID: <BYAPR12MB3285D4DE7582BA9E793E3C8CA40A0@BYAPR12MB3285.namprd12.prod.outlook.com> (raw)
In-Reply-To: <DB6PR0902MB2072E97207AD7F35C636D1CEB40A0@DB6PR0902MB2072.eurprd09.prod.outlook.com>
>> Subject: [dpdk-dev] [PATCH v2] eal/windows: export all built functions for
>> clang
>>
>> CAUTION: This email originated from outside of the organization. Do not click
>> links or open attachments unless you recognize the sender and know the
>> content is safe.
>>
>> export for clang build all the functions currently built on Windows and listed
>> in rte_eal_version.map by adding them to rte_eal_exports.def.
>>
>> Signed-off-by: Tal Shnaiderman <mailto:talshn@nvidia.com>
>> Acked-by: Ranjit Menon <mailto:ranjit.menon@intel.com>
>> ---
>> v2: rebase to master
>> ---
>> ---
>> lib/librte_eal/rte_eal_exports.def | 156
>> +++++++++++++++++++++++++++++++++++--
>> 1 file changed, 151 insertions(+), 5 deletions(-)
>>
> Are we close to being able to drop the custom .def file for the Windows EAL and use the one generated from the .map file as with the other RTE libraries? How many functions are undefined now in the Windows EAL?
Hi John,
We're missing 77 additional functions exported in the map file for Linux, many I assume are related to the missing interrupts implementation, however some are unneeded by Windows (e.g. all the rte_vfio_* exports).
Regarding dropping the .def file completely, Harini, do you have an estimation when this task will be completed?
next prev parent reply other threads:[~2020-10-07 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 19:18 [dpdk-dev] [PATCH] " Tal Shnaiderman
2020-10-02 21:07 ` Ranjit Menon
2020-10-02 23:22 ` Tal Shnaiderman
2020-10-06 8:00 ` Tal Shnaiderman
2020-10-06 18:57 ` Ranjit Menon
2020-10-06 20:47 ` Dmitry Kozlyuk
2020-10-07 7:19 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman
2020-10-07 11:32 ` John Alexander
2020-10-07 14:14 ` Tal Shnaiderman [this message]
2020-10-14 9:35 ` Dmitry Kozlyuk
2020-10-14 9:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB3285D4DE7582BA9E793E3C8CA40A0@BYAPR12MB3285.namprd12.prod.outlook.com \
--to=talshn@nvidia.com \
--cc=Harini.Ramakrishnan@microsoft.com \
--cc=John.Alexander@datapath.co.uk \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=ophirmu@nvidia.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).