From: Ori Kam <orika@nvidia.com>
To: Gregory Etelson <getelson@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
"Bernard Iremonger" <bernard.iremonger@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix flow tunnel commands
Date: Thu, 19 Nov 2020 16:50:42 +0000 [thread overview]
Message-ID: <BYAPR12MB4983A224E074ABCB3B638771D6E00@BYAPR12MB4983.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201119111024.7989-1-getelson@nvidia.com>
Hi Gregory,
> -----Original Message-----
> From: Gregory Etelson <getelson@nvidia.com>
> Sent: Thursday, November 19, 2020 1:10 PM
> Subject: [PATCH v2] app/testpmd: fix flow tunnel commands
>
> testpmd provides commands to test tunnel offload rte_flow
> capabilities. Testpmd tunnel commands allow to configure new ofloaded
> tunnel types, list existing offloaded tunnels and destroy existing
> offloaded tunnels.
> Tunnel offload commands allowed parameters repetition. For example,
> the following commands were accepted:
> testpmd> flow tunnel create 0 create 1 type vxlan
> or
> testpmd> flow tunnel list 0 list 1
>
> Current patch fixed that fault. Correct tunnel commands syntax is:
> testpmd> flow tunnel create <port> type <tunnel type>
> testpmd> flow tunnel list <port>
> testpmd> flow tunnel destroy <port> id <tunnel id>
>
> Fixes: 1b9f274623b8 ("app/testpmd: add commands for tunnel offload")
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> ---
> app/test-pmd/cmdline_flow.c | 32 +++++++-------------------------
> 1 file changed, 7 insertions(+), 25 deletions(-)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 457f74078d..585cab98b4 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -812,26 +812,6 @@ static const enum index next_vc_attr[] = {
> ZERO,
> };
>
> -static const enum index tunnel_create_attr[] = {
> - TUNNEL_CREATE,
> - TUNNEL_CREATE_TYPE,
> - END,
> - ZERO,
> -};
> -
> -static const enum index tunnel_destroy_attr[] = {
> - TUNNEL_DESTROY,
> - TUNNEL_DESTROY_ID,
> - END,
> - ZERO,
> -};
> -
> -static const enum index tunnel_list_attr[] = {
> - TUNNEL_LIST,
> - END,
> - ZERO,
> -};
> -
> static const enum index next_destroy_attr[] = {
> DESTROY_RULE,
> END,
> @@ -2009,35 +1989,37 @@ static const struct token token_list[] = {
> [TUNNEL_CREATE] = {
> .name = "create",
> .help = "create new tunnel object",
> - .next = NEXT(tunnel_create_attr, NEXT_ENTRY(PORT_ID)),
> + .next = NEXT(NEXT_ENTRY(TUNNEL_CREATE_TYPE),
> + NEXT_ENTRY(PORT_ID)),
> .args = ARGS(ARGS_ENTRY(struct buffer, port)),
> .call = parse_tunnel,
> },
> [TUNNEL_CREATE_TYPE] = {
> .name = "type",
> .help = "create new tunnel",
> - .next = NEXT(tunnel_create_attr, NEXT_ENTRY(FILE_PATH)),
> + .next = NEXT(NEXT_ENTRY(FILE_PATH)),
> .args = ARGS(ARGS_ENTRY(struct tunnel_ops, type)),
> .call = parse_tunnel,
> },
> [TUNNEL_DESTROY] = {
> .name = "destroy",
> .help = "destroy tunel",
> - .next = NEXT(tunnel_destroy_attr, NEXT_ENTRY(PORT_ID)),
> + .next = NEXT(NEXT_ENTRY(TUNNEL_DESTROY_ID),
> + NEXT_ENTRY(PORT_ID)),
> .args = ARGS(ARGS_ENTRY(struct buffer, port)),
> .call = parse_tunnel,
> },
> [TUNNEL_DESTROY_ID] = {
> .name = "id",
> .help = "tunnel identifier to testroy",
> - .next = NEXT(tunnel_destroy_attr, NEXT_ENTRY(UNSIGNED)),
> + .next = NEXT(NEXT_ENTRY(UNSIGNED)),
> .args = ARGS(ARGS_ENTRY(struct tunnel_ops, id)),
> .call = parse_tunnel,
> },
> [TUNNEL_LIST] = {
> .name = "list",
> .help = "list existing tunnels",
> - .next = NEXT(tunnel_list_attr, NEXT_ENTRY(PORT_ID)),
> + .next = NEXT(NEXT_ENTRY(PORT_ID)),
> .args = ARGS(ARGS_ENTRY(struct buffer, port)),
> .call = parse_tunnel,
> },
> --
> 2.29.2
Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori
next prev parent reply other threads:[~2020-11-19 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 11:23 [dpdk-dev] [PATCH] app/testpmd: fix flow tunnel create command Gregory Etelson
2020-11-17 12:51 ` Ferruh Yigit
2020-11-17 13:46 ` Gregory Etelson
2020-11-19 11:10 ` [dpdk-dev] [PATCH v2] app/testpmd: fix flow tunnel commands Gregory Etelson
2020-11-19 16:50 ` Ori Kam [this message]
2020-11-19 17:29 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR12MB4983A224E074ABCB3B638771D6E00@BYAPR12MB4983.namprd12.prod.outlook.com \
--to=orika@nvidia.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).