From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29804A3168 for ; Wed, 16 Oct 2019 05:15:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C2391E4EC; Wed, 16 Oct 2019 05:15:02 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 299AC1DFEA for ; Wed, 16 Oct 2019 05:14:59 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x9G3EvS4020117; Tue, 15 Oct 2019 20:14:57 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=TkgZXdMxSHM+MOX8MZ0haHNU5AEDnBPLuVRCyr9huQw=; b=FaoK+ezaZKUMQnfUjD2+rCBOWog/yHedipd7T2Vs3XvaQATGyzDsYvhE5lgK5MIiuOOf zYqo9D1kgWtGUp+3QwcGgjjIEkUy2zdUnTymajVaDUONs69apxB1lWQOVxECAh1bfGrO Lcn5F6cIozTxWM2LElQJAb5oX+apxx2Q95yiMxx7BZIjsngqqs15OiN3a62tHhJIWKP7 38WrikizIGIjMq2SBygq9inz8jCpS/biBaxeSFZk9BlDICDfRuTwNWXju2TYHDAUjavZ qTPsOWvDnwNw6KrVh+XU/4lOEKNFU5XQsQ3+KECd+QMYYPfstJkMQ+n4+M6A6uOZY139 7Q== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2vnpmbgyhg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2019 20:14:57 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 15 Oct 2019 20:14:49 -0700 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.56) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 15 Oct 2019 20:14:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sv0031EUyW6wAlUg4j0KK1AR2CFn9tITaxjE0mKRllEamIe2+L8HQGFdTdlVmEUm7waGMknV54GOemmJINwuSwuB2k3ZcBX39lul6ymxGHR99NtQhTj/DJhbdOHeO6cCPHlx+hNGjjSo89P+o7ryhoND+y8NfQAYPdrHcVx98j89QFV91gWDpUDS4SAtToQBQ3i+7goVlQU5zo+2SBtfQ3DPlfZmVGdK0OtNW0PbnEqMdnCm0LmG8BjeThDPx/vsT2SUaBUZwfYfVnz5A8V0FAfIEFB8Qxj0qQbAOsJGv46h448Ozw430ag8Wm0p6aXobtytkr8F2zSwJdeXXqrM/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TkgZXdMxSHM+MOX8MZ0haHNU5AEDnBPLuVRCyr9huQw=; b=JPzTJ9l+ufz4IZN1t1xBLKunqtV8jnCYO/RdN2wF+Jfj74to5F6hh2SYEUoxnzxqqe9/l5eOf+KkZJQQWqk9BoXxecSIY4B+4Pvh8D+Rg8mDWGPPkZkm0M9psNWw8lMPoj9OpRrfF/B4szbLJLsIa+15165YU4W+PDEexDE62yvdCht52M0wrHB6MTlQBG8VUUQyAUwgChIr7tx0xcottCmJde72Z722hOV/h8TMpv9nBESbkHlMoVHCPO4vwwPOllZqBbbHnlWKMkkFXHQXMSKdUFzWMxlvbVSAR76yHhcJSS5Ehu2KarVSr4ozkNE/PDAPpBXjXu3WVbpadeRsCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TkgZXdMxSHM+MOX8MZ0haHNU5AEDnBPLuVRCyr9huQw=; b=RxokeNFL+Ca1H2qH9HrGM6OU4GOXVopeAs/4xci88I8zHktrm/wOJTgPOzek8vTHq1KO6VmtRWZqhJNZMr2AFZTxy1qFeK8te50WC6/9SaKX8p8vdkV7rwJuoPzayhH5pDoCIf1Ej2uN+L4E54BaPdOkY3uloN65xCQRgOXpUqM= Received: from BYAPR18MB2392.namprd18.prod.outlook.com (20.179.93.30) by BYAPR18MB2951.namprd18.prod.outlook.com (20.179.58.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Wed, 16 Oct 2019 03:14:48 +0000 Received: from BYAPR18MB2392.namprd18.prod.outlook.com ([fe80::1074:3a85:1b57:8953]) by BYAPR18MB2392.namprd18.prod.outlook.com ([fe80::1074:3a85:1b57:8953%3]) with mapi id 15.20.2347.023; Wed, 16 Oct 2019 03:14:48 +0000 From: Kiran Kumar Kokkilagadda To: Stephen Hemminger CC: Adrien Mazarguil , John McNamara , Marko Kovacevic , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , "ajit.khaparde@broadcom.com" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH] ethdev: add HIGIG2 key field to flow API Thread-Index: AQHVg3g9PWQqqb+oIUW+ny3Ow/FI8KdcmLXw Date: Wed, 16 Oct 2019 03:14:48 +0000 Message-ID: References: <20191014042956.18616-1-kirankumark@marvell.com> <20191015094717.052d0993@hermes.lan> In-Reply-To: <20191015094717.052d0993@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9e454e20-6b11-49ad-fa48-08d751e700a9 x-ms-traffictypediagnostic: BYAPR18MB2951: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-forefront-prvs: 0192E812EC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(366004)(346002)(136003)(376002)(396003)(13464003)(189003)(199004)(186003)(305945005)(6436002)(11346002)(7736002)(71200400001)(6916009)(26005)(446003)(33656002)(55236004)(9686003)(71190400001)(53546011)(6506007)(102836004)(6246003)(2906002)(8936002)(14454004)(55016002)(86362001)(66946007)(7696005)(66446008)(64756008)(66556008)(66476007)(478600001)(66066001)(76116006)(486006)(4326008)(99286004)(6116002)(52536014)(256004)(76176011)(81156014)(74316002)(81166006)(8676002)(476003)(229853002)(3846002)(54906003)(316002)(5660300002)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2951; H:BYAPR18MB2392.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I2/OLKi0IA3/1TYt9QhVXQGeY6QVy++BRbaiXb/IfMw8LlCIMQWmEL9Tsv0NBu3/kFjvKnOwFwIrOrZm54J10J5sMMQgpYgty+wvfr3tYBtGZRlgM486TxAGKquNzUYmCdg2K/p4orbWikX+KPTu7jKAhzdRjP3fvlN6sRC0svR1Ar21PZTOJewIeXZu2Nsq2Acaiz9dKHwv/ehDtXq89EzNQiaghUkEtPltezf/9CvxGlz6cUJH7zjV2BXxsSpgi7iNQ0JNrldolBdqziPv0BQadbekEBI2do7WnRR0tu2EUx+rsZk4+akgewrdrTqOnV2pByrEa5Rc7vg0ebdtnBQxWUCfvMLVK2Wvv9rwhrwdpWyRYhH0ITrpNnTusEfcJjy4imbqi2gDsDGRKk0fbwsJYlN+mmQDnMp4aVW7MpY= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9e454e20-6b11-49ad-fa48-08d751e700a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2019 03:14:48.5420 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h5sTMIcqHD+lYjXB6jYvmIcwX3zBsI+QLbYBnZJJ6WhqbUPl2PL5qKpHpJrjVcXPoRKze1OB3j5W9bCE9IRRoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2951 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-15_08:2019-10-15,2019-10-15 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: add HIGIG2 key field to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, October 15, 2019 10:17 PM > To: Kiran Kumar Kokkilagadda > Cc: Adrien Mazarguil ; John McNamara > ; Marko Kovacevic ; > Thomas Monjalon ; Ferruh Yigit > ; Andrew Rybchenko ; > dev@dpdk.org; ajit.khaparde@broadcom.com > Subject: [EXT] Re: [dpdk-dev] [PATCH] ethdev: add HIGIG2 key field to flo= w API >=20 > External Email >=20 > ---------------------------------------------------------------------- > On Mon, 14 Oct 2019 09:59:56 +0530 > wrote: >=20 > > +/** > > + * RTE_FLOW_ITEM_TYPE_HIGIG2 > > + * Matches higig2 header. > > + */ > > +struct rte_higig2_frc { > > + uint32_t ksop:8; > > + uint32_t resv:3; > > + uint32_t mcst:1; > > + uint32_t tc:4; > > + uint32_t dst_modid:8; > > + uint32_t dst_pid:8; > > + uint32_t src_modid:8; > > + uint32_t src_pid:8; > > + uint32_t lbid:8; > > + uint32_t dp:2; > > + uint32_t resv1:3; > > + uint32_t ppd_type:3; > > +} __attribute__((packed)); > > + > > +struct rte_higig2_ppt_type0 { > > + uint32_t dst_t:1; > > + uint32_t dst_tgid:3; > > + uint32_t ingress_tagged:1; > > + uint32_t mirror_only:1; > > + uint32_t mirror_done:1; > > + uint32_t mirror:1; > > + uint32_t res:2; > > + uint32_t l3:1; > > + uint32_t label_present:1; > > + uint32_t vc_label2:4; > > + uint32_t vc_label1:8; > > + uint32_t vc_label0:8; > > + uint32_t vid_high:8; > > + uint32_t vid_low:8; > > + uint32_t pfm:2; > > + uint32_t src_t:1; > > + uint32_t res1:2; > > + uint32_t opcode:3; > > + uint32_t hdr_ext_len:3; > > + uint32_t res2:5; > > +} __attribute__((packed)); > > + > > +struct rte_higig2_ppt_type1 { > > + uint32_t classification:16; > > + uint32_t resv:16; > > + uint32_t vid:16; > > + uint32_t pfm:2; > > + uint32_t src_t:1; > > + uint32_t resv1:2; > > + uint32_t opcode:3; > > + uint32_t hdr_ext_len:3; > > + uint32_t resv2:5; > > +} __attribute__((packed)); > > + > > +RTE_STD_C11 > > +struct rte_flow_item_higig2_hdr { > > + struct rte_higig2_frc fcr; > > + union { > > + struct rte_higig2_ppt_type0 ppt0; > > + struct rte_higig2_ppt_type1 ppt1; > > + }; > > +} __attribute__((packed)); > > + > > +/** Default mask for RTE_FLOW_ITEM_TYPE_HIGIG2. */ #ifndef > > +__cplusplus static const struct rte_flow_item_higig2_hdr > > +rte_flow_item_higig2_hdr_mask =3D { > > + .ppt1.classification =3D 0xffff, > > + .ppt1.vid =3D 0xfff, > > +}; > > +#endif > > + >=20 > Why do all these structures have to be packed. They are all uint32. Will fix in V4.