From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C2222A05D3 for ; Wed, 22 May 2019 05:05:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D8782C39; Wed, 22 May 2019 05:05:59 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 3206814EC; Wed, 22 May 2019 05:05:58 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4M2xoAC004144; Tue, 21 May 2019 20:05:56 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=ilawpQOjIKecJ5vOSiydOLHVOxynKnIfIvQ7OP6aSI0=; b=jmCEz0GN97zCr/6mzrPE3LBJ3ByHg0tcA5Bqq1mEvF65TNFfMYHVp6gfJCzp20zyvq+I c599NkIXFmfWaJh7BTIZ/UpH476P+WHzC3qzV+DjyY2ssvD5jdc05ig1+P+uDIeOajUQ gdgcuUZ2pirQpSE6d8J+MpaBM1plhtO8YRFuH55hj1PkTp+mHC0zSeiDAhcGXV08FdDM RHorYo547DLhasvZvsZ2h6Gk1gPjLl6RoV0O5Or6I9KOI1neX+wtOycpS08NAehoLMwN Xu2CTWw2ifwGzsvxC0YhCRpSZe7UfcQ01DGPk4liTSY9HYqHPSRiIA7n59p17y6GJFWo qQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2smnrqac8k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 21 May 2019 20:05:56 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 21 May 2019 20:05:55 -0700 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (104.47.34.52) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 21 May 2019 20:05:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ilawpQOjIKecJ5vOSiydOLHVOxynKnIfIvQ7OP6aSI0=; b=u9ypuFUOlBkv/DXu51yF+JPd/v/IEaOehlFM0tKI2uqb+8uQCHCWCauLt/DnvRNC6mEoIV1dbZAhNXcZ4w2xGij8DMxf5670wnewF6yHlBiXSmbjPbfU0E+kCp74gyEmLq+/E67VVCYfrWM4QnI83W275dcCEH2uCCMlEd+d7p8= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2534.namprd18.prod.outlook.com (20.179.93.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1922.16; Wed, 22 May 2019 03:05:54 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c%7]) with mapi id 15.20.1900.020; Wed, 22 May 2019 03:05:54 +0000 From: Jerin Jacob Kollanukkaran To: Neil Horman CC: "dev@dpdk.org" , "thomas@monjalon.net" , "stable@dpdk.org" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers Thread-Index: AQHVEA952PljWhFxsE2Eo8Rt+ffcIaZ2BvsAgABstjA= Date: Wed, 22 May 2019 03:05:54 +0000 Message-ID: References: <20190521195628.16355-1-jerinj@marvell.com> <20190521202704.GA12605@hmswarspite.think-freely.org> In-Reply-To: <20190521202704.GA12605@hmswarspite.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.201.57.97] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 838797ed-7f46-444f-a387-08d6de626797 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2534; x-ms-traffictypediagnostic: BYAPR18MB2534: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0045236D47 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(346002)(366004)(376002)(13464003)(199004)(189003)(6916009)(76116006)(71200400001)(66946007)(73956011)(66476007)(66556008)(64756008)(478600001)(476003)(7696005)(316002)(5660300002)(14454004)(76176011)(71190400001)(99286004)(66446008)(8936002)(81156014)(81166006)(55016002)(186003)(486006)(68736007)(66066001)(2906002)(256004)(14444005)(54906003)(229853002)(26005)(53936002)(9686003)(6506007)(25786009)(86362001)(53546011)(3846002)(52536014)(6116002)(11346002)(7736002)(4326008)(6436002)(8676002)(305945005)(55236004)(102836004)(74316002)(446003)(6246003)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2534; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: VJiajKtCGVq81+jMwXVoO7dwMwhyVK3nmuephljEP+PfbY3e1ofSlT8mZd+MCI+H1v5VqG3lqshkYvhuKKOSkNcg9riNeE5P5EuFLuKolukeH+TlMQnKnwXg16lluh1Ri+5DThbt3JVTy1g46uK0fPQjWmwq8XE7pJ9cmfI7DqxYtdSXWVmJ0PwjXPPzz0lbwmIRVjYLrgcxerJGi3TpaOT/yDlpVdZ0p922Yp3z2UluNIfpZlB5aezFkiVRmQGP9/8nuEsHGUodIdczkoAIRdqFu3uRJtEvjWe8eOamPO+ttPjmWQpSa5rmoxyuoqVrKAlmzTb21X1mDAA6ZXyviuySMFnUSz3LErX2D3by6MeixnSPma88GiL/I+HHGrnyjn2LEi2KKztI6lpa3sROCyS2P8EZO6wTxoAtmfoQ+EQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 838797ed-7f46-444f-a387-08d6de626797 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2019 03:05:54.3997 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2534 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-22_02:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] devtools: skip the symbol check when map file under drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Neil Horman > Sent: Wednesday, May 22, 2019 1:57 AM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; thomas@monjalon.net; stable@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [PATCH] devtools: skip the symbol check whe= n > map file under drivers >=20 > On Wed, May 22, 2019 at 01:26:28AM +0530, jerinj@marvell.com wrote: > > From: Jerin Jacob > > > > Drivers do not have ABI. > > Skip the symbol check if map file under drivers directory. > > > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > > > > Cc: stable@dpdk.org > > Cc: Neil Horman > > > Sorry, but I'm not ok with this, because many of our DPDK PMDs have funct= ions > that get exported which are meant to be called by applications directly. = The OK. Just to update my knowledge, Should those API needs to go through ABI/A= PI depreciation process? Actually, I am concerned about the APIs, which is called between drviers no= t the application. For example, drivers/common/dpaax/rte_common_dpaax_version.map it is not interface to application rather it is for intra driver case. I think, I can change my logic to Skip the symbols which NOT starting with = rte_. Agree? Context: I am adding a new driver/common/octeontx2 directory and it has some API whi= ch Needs to shared between drivers not to the application. For me, it does not= make sense to go through any ABI process in such case. > dpaa2 driver is a good example, the cryptodev scheduler is another. Take= a look > at their version.map files to see what I mean. >=20 > Unless we are willing to make drivers opaque objects that are only access= ible > from the [eth|crypto|etc]dev apis in the DPDK core, we have the potential= for > exported symbols, which means we have an ABI that has to be maintained, o= r at > least recognized and reviewed for consistency >=20 > Nacked-by: Neil Horman >=20 >=20 > > Signed-off-by: Jerin Jacob > > --- > > devtools/check-symbol-change.sh | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/devtools/check-symbol-change.sh > > b/devtools/check-symbol-change.sh index c5434f3bb..444beddad 100755 > > --- a/devtools/check-symbol-change.sh > > +++ b/devtools/check-symbol-change.sh > > @@ -93,6 +93,14 @@ check_for_rule_violations() > > if [ "$ar" =3D "add" ] > > then > > > > + directory=3D`echo $mname | cut -d / -f 2` > > + if [ "$directory" =3D "drivers" ] > > + then > > + # Drivers do not have ABI. Skip further > > + # processing if the map file is under > > + # drivers directory > > + continue > > + fi > > if [ "$secname" =3D "unknown" ] > > then > > # Just inform the user of this occurrence, but > > -- > > 2.21.0 > > > >