From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD1A6A0471 for ; Thu, 18 Jul 2019 10:05:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E0BA11D9E; Thu, 18 Jul 2019 10:05:01 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 6FCD3DE3 for ; Thu, 18 Jul 2019 10:05:00 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6I80jkY016650; Thu, 18 Jul 2019 01:04:57 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=GvzHVPTy/ZQ0WNRWO1SeKPRfJC648Lw4NCd6zHQpdXA=; b=mfNyqOl5GDtbmE1q1pCifyVMUbg/7ULPPmlSKQvaLssz82otxRVBZHvCBiK27sJBda4v jGntMCKGKgpN9Hxm/XXptivoXvGv2TGbLLMPXEghvqAeWXiY6BAcAtnsPATNz53SkxtN J3IOK46tkRwhq3vvzLb6ReaxOUlfyyGub4kFgFiFLlDlkbBdM+Fv0vMpr9HVf4mMko0V FRtloeO3fXlhY4YAIw7NqoXvbWHAEh5nX/QPXhjidEsVqecHqkK7CngvUWB9ClJ16mDj hpErWQhHTgD8fBRVs4ti/PHFEHIPuvYoAEWKQTDCZzNi73diHbpMSYuHO2qMQPIupEci 0w== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2ts07vktw4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 18 Jul 2019 01:04:54 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 18 Jul 2019 01:04:53 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.59) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 18 Jul 2019 01:04:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lSnZBz60/czwrkmk7XLuU4Vsbr7fg8V8wpDGWHJdJnOBZNH4lLZs3PwXoxZssb7JP8USAR5agxDfsNRl4EP6rlvaXep8IhJe0ZzyQuhzuG3mJ7ZRoVVjve0W4pdrc0Hjxmlqe/IbQ8I63ZO96i0aJts4cwISytVwFh0LgTKQphPRZu4RX6hfQv8ZiQmFLqlywOimU2nOT15NU4iYECUFVh27zhCV8NjCJEVOH+dYZYzi0K+28us+0M12243+6sjAAZs0HXSJQiypqBFZ40kLmARNhZnWXjQk1jbXnFdlkMMQUB7C4rD1vM2vhcVYOtO//HhiRvRniirnTXoly6GS4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GvzHVPTy/ZQ0WNRWO1SeKPRfJC648Lw4NCd6zHQpdXA=; b=EXduhQTU2C2Lp2Xki3Vmt8zeimq05NDGVBGByX9uJbtVaTvmNsOB/qMT73LaQMj3QWAdM8fb1zZ9heh+sH5N/dutATE+xfrkZ8ucz/4EcIHtQHG2NV+N8Tl251efXIuP8Vj8i9cyYenowYdjnExljlI4VTvSZMHj/wMKFw9ljptiQL3AWmQWMTk/KOaZoKisT8JvwKUz+nvc7f9+tUJi5jJXxPv9qt/OMkpy6pLSdh46O7IXEyctXI4YhmcYsqGEPJMu5svWulNPRIzTHbRRFzefdMkgaZAOWjJPpMPE8TtJnPuGEOzaeK3EypyVOE6s/V0b3YYMxh4HIvLfvflUhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GvzHVPTy/ZQ0WNRWO1SeKPRfJC648Lw4NCd6zHQpdXA=; b=VQY4RNTlh23HXUJd6Bj2KNF46x5er/EBjd/ZNgUwL5AOtE5M1CvwqtSN2mIwKEkT/Qqzjm7EW80sltoyCTis3ef7lICmXQMro6LO8B9fOv+r6ooIC92yYpmEtoLFSrItzVoEmxO+Z8KFlLz4hxj+JsStIXtW3RgpXtsnClHaATc= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2437.namprd18.prod.outlook.com (20.179.91.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Thu, 18 Jul 2019 08:04:51 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2073.012; Thu, 18 Jul 2019 08:04:51 +0000 From: Jerin Jacob Kollanukkaran To: Pavan Nikhilesh Bhagavatula , "Nithin Kumar Dabilpuram" , Vamsi Krishna Attunuru CC: "dev@dpdk.org" , Pavan Nikhilesh Bhagavatula , "thomas@monjalon.net" Thread-Topic: [dpdk-dev][PATCH v2] mempool/octeontx2: fix possible ABI break with force inline Thread-Index: AQHVPTU4/Z9gCGNEY0CfKs1aZy+oaKbQBFSQ Date: Thu, 18 Jul 2019 08:04:51 +0000 Message-ID: References: <20190717184013.1072-1-pbhagavatula@marvell.com> <20190718065111.1766-1-pbhagavatula@marvell.com> In-Reply-To: <20190718065111.1766-1-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.200.248.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a57a8425-6443-443f-5d62-08d70b569c7b x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2437; x-ms-traffictypediagnostic: BYAPR18MB2437: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-forefront-prvs: 01026E1310 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(366004)(39860400002)(376002)(136003)(189003)(199004)(13464003)(446003)(6246003)(76176011)(5660300002)(74316002)(4744005)(7696005)(86362001)(6636002)(305945005)(81156014)(68736007)(11346002)(53936002)(99286004)(25786009)(71200400001)(81166006)(186003)(14454004)(71190400001)(66446008)(64756008)(8936002)(66476007)(66946007)(14444005)(478600001)(52536014)(7736002)(76116006)(316002)(53546011)(6436002)(66066001)(110136005)(55016002)(9686003)(476003)(33656002)(2906002)(6116002)(3846002)(8676002)(26005)(6506007)(54906003)(4326008)(256004)(229853002)(66556008)(102836004)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2437; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: FlDbUVSnIQxR3Z9+Msygtg37tJ4tgOzTRZGnPo0Kg8AL8XpEBaajkTenkhjJ6pkKxaHheDVSthOegb1+4O3DZnstH+zCprXOtvWqT5MUAWxrDzfA6WWIOedJDMo0OyRnLEFAuZY4Rwh59OKVwXFjhlSqVY/vvPhU6FuKy4ABlENi1l3IwqxSdO7asm8ydYhmVMsQvjD2qK3dpaAz6osWydw1bjfcLgC5i2cLZMA9uDEwQ3aqTdpRhza8wK6iXwRrAjxFzdtGILRCFOC03McChs7mwSPVHR9DDs0Q7f+q0w28IT24dz0CS5tbfLoDBzdRMa2tD7WzgGyImAfwhCMXXMmzK3aOKjco1yzruXxe0Qf5Gix3RELRlY+B0/r1KQyeRFgERLAeKAETfXlswynhz0bvPtyLulfM5EFoOz6tcDo= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a57a8425-6443-443f-5d62-08d70b569c7b X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2019 08:04:51.5268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2437 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-18_04:2019-07-18,2019-07-18 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2] mempool/octeontx2: fix possible ABI break with force inline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: pbhagavatula@marvell.com > Sent: Thursday, July 18, 2019 12:21 PM > To: Jerin Jacob Kollanukkaran ; Nithin Kumar > Dabilpuram ; Vamsi Krishna Attunuru > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev][PATCH v2] mempool/octeontx2: fix possible ABI break > with force inline >=20 > From: Pavan Nikhilesh >=20 > Since direct register access is used in npa_lf_aura_op_alloc_bulk() use > __rte_noinline instead of __rte_always_inline to preserve ABI. > Based on the compiler npa_lf_aura_op_alloc_bulk might be inlined > differently which may lead to undefined behaviour due to handcoded asm. >=20 > Fixes: 29893042c29d ("mempool/octeontx2: fix clang build for arm64") > Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob