From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F517A0471 for ; Fri, 19 Jul 2019 06:18:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9F51E2BE5; Fri, 19 Jul 2019 06:18:29 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id C9F582082 for ; Fri, 19 Jul 2019 06:18:28 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6J4EfCG013642; Thu, 18 Jul 2019 21:18:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=GzNtVfiq8EoWGzK3o+bMe9uDkWTbrebUgL56cjHR6C8=; b=NRfeYXmyn57AOdojAWfH/lQAaliMt7QoqllKFcKmS94znO8gxoXHi6hcniBDi/q3IUOd AykbQRzMOHCTSYgLwUAbZFjWxrtV4QEENg6AKnBsFWytIc2E3wx+ZDDeU7105sXQo+do 9pq79yiZ6EEvkfBCVPgVuFnuKO05UGNK/Y9keLifCIF3EsM9uGaupLYOZBdXQbDS4f6r 7SynioA45Zi63WdzL1dzDFqAwKZACpijvvtr1OuwB5zNfGf3/zW59pMeomDIWag7XCzO Ol/l5HchnNaexpEEvQX+pF1rKymBIcb+o4X82rJh207XbUP1LiFmaBcXFKEbU2ieJBP1 cQ== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2ts0a2f267-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 18 Jul 2019 21:18:25 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 18 Jul 2019 21:18:23 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.56) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 18 Jul 2019 21:18:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MGKZMfIqz6+m8pd89UxPGoB4nI53GEspPjwizRIkKe3Pc2GvfqfSYKTpMPOpgjy6aWYBhR2BX2PN3+hAZvj4/6+p0HkLJ1wLP4vRI4vPeEgmgUpGfRSUtTK8I6jCK/KqdfEVOCTShHJsTnCoBSxuFQe2nXvO5qJ4b/RQAw34cbqBii/M9BLHrXXhEbdgBdRQjhkIr/RJHWJbIKPO2iKLeKjAD94ddUdFRjPD5TLrkmJycKk7MeoATOIHeYsjzGyq4cfv549O6gw7qXPR/fzXd8K32bx/Shj4EhBdNcOB2HuTjqDmCUInGNi4sKdxmm60hzDIiIrz3aqCS2skidNWQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GzNtVfiq8EoWGzK3o+bMe9uDkWTbrebUgL56cjHR6C8=; b=iEMRqKBxXfqbY5ncn9+0aR2Wlgc+gL4b/VE+YmqyrAM/eUElUpOEf9jkGXsFtY4DFeGI2H6nti8qk6TwP/ltZJPDGlfTmpgQymCjwdcAc5AZ6NbpFQvogVDU9DA4u9Aesp2HdMJn6ESzQtLR3EWElixEWrAFJiXHI2oZemGBGU8PMjAXmkj0ZBXKbVRAv5VG3BMaU5yhpdD1Teuz8qpMDo4w7jEZ8USF+dyZllc78SFcpzeiYk27aEhTo6nxmFv/mbxCV9u8pguKWJZgMkFKS5nbDXyjMOmSXGi4gLvC9sCHU+HYwmSzfHe0m668zh4pClvqRbCB400u3hKEKbcX0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GzNtVfiq8EoWGzK3o+bMe9uDkWTbrebUgL56cjHR6C8=; b=ZNld9vFjfIia7TR+oK1JqxIwszz+PGPlqNTo3d6oOwbkd1pqWNndgFnOslDU3hxMNsVHuY7jyq/YFyMx5ZK1oyogRdN3rog6IlV/YIeo+DmDzbp8kzuFXtWMVVvBmALLvL+S1miiDVWvNQnsXyHidFyfbViZ43V5OQpb8LQm2iY= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2581.namprd18.prod.outlook.com (20.179.93.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Fri, 19 Jul 2019 04:18:21 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2073.012; Fri, 19 Jul 2019 04:18:21 +0000 From: Jerin Jacob Kollanukkaran To: Phil Yang , "dev@dpdk.org" CC: "thomas@monjalon.net" , "hemant.agrawal@nxp.com" , "Honnappa.Nagarahalli@arm.com" , "gavin.hu@arm.com" , "nd@arm.com" , "gage.eads@intel.com" Thread-Topic: [EXT] [PATCH v3 3/3] eal/stack: enable lock-free stack for aarch64 Thread-Index: AQHVLYk9rZbDQ4qg70+TRqBpyBPMi6bRddNg Date: Fri, 19 Jul 2019 04:18:21 +0000 Message-ID: References: <1561257671-10316-1-git-send-email-phil.yang@arm.com> <1561709503-11665-1-git-send-email-phil.yang@arm.com> <1561709503-11665-3-git-send-email-phil.yang@arm.com> In-Reply-To: <1561709503-11665-3-git-send-email-phil.yang@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ff23cbda-0f4f-4501-7e23-08d70c0022b1 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2581; x-ms-traffictypediagnostic: BYAPR18MB2581: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 01039C93E4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(39860400002)(136003)(346002)(396003)(376002)(199004)(189003)(13464003)(81166006)(81156014)(9686003)(74316002)(7736002)(2501003)(476003)(25786009)(76116006)(66946007)(66446008)(66556008)(64756008)(66476007)(54906003)(68736007)(316002)(8676002)(110136005)(8936002)(76176011)(6436002)(7696005)(55016002)(478600001)(256004)(6116002)(3846002)(4326008)(14444005)(86362001)(52536014)(33656002)(66066001)(5660300002)(99286004)(14454004)(55236004)(486006)(71190400001)(305945005)(2906002)(71200400001)(229853002)(186003)(26005)(6246003)(53546011)(102836004)(11346002)(446003)(53936002)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2581; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: nszFZUQMmnXqga+X3pu/MARRXsCey8x2GbV3t8cui5KCFu6yHel+H3gF7hJd/xLSM37FeIWNJKg8j+EqVkzPK2IUG1o/R7VHfrFPXJqE6RwWEvZA+umSTrC58udYi5G7mB3OgaYC4qYXA2klePOJJdL+GlGQgro+sFRbKshvw3ydabV1fJ+SwBdYNRggEeHq+5HsucFYJRRX44X4Lu1K0qW4gAe43oZvVvdImL0YkDbpQZ2PoKTAKfp0cWOPvP3EB9cniH7ab2tgZXm/sfhIFETcX/q9IuZ3714+gENpwUyXBetJTz4aY7LycdPHqOJgHoCAzkTEVGYCXNlNy0dMfWipQgWx5ZcqWeybDP8DvMiijz3WKGdE3PPVs38nlNQRGkp+j4VGZoN8fY3fk0i92ARd4NztoVXcH/LcJGMAzPA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ff23cbda-0f4f-4501-7e23-08d70c0022b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2019 04:18:21.5966 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2581 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-19_03:2019-07-19,2019-07-19 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 3/3] eal/stack: enable lock-free stack for aarch64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Phil Yang > Sent: Friday, June 28, 2019 1:42 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; Jerin Jacob Kollanukkaran ; > hemant.agrawal@nxp.com; Honnappa.Nagarahalli@arm.com; > gavin.hu@arm.com; nd@arm.com; gage.eads@intel.com > Subject: [EXT] [PATCH v3 3/3] eal/stack: enable lock-free stack for aarch= 64 > Enable both c11 atomic and non c11 atomic lock-free stack for aarch64. >=20 > Signed-off-by: Phil Yang > Reviewed-by: Honnappa Nagarahalli > Tested-by: Honnappa Nagarahalli >=20 > Removed Items > ------------- > diff --git a/lib/librte_stack/rte_stack_lf_c11.h > b/lib/librte_stack/rte_stack_lf_c11.h > index 3d677ae..67c21fd 100644 > --- a/lib/librte_stack/rte_stack_lf_c11.h > +++ b/lib/librte_stack/rte_stack_lf_c11.h > @@ -36,7 +36,7 @@ __rte_stack_lf_push_elems(struct rte_stack_lf_list > *list, > struct rte_stack_lf_elem *last, > unsigned int num) > { > -#ifndef RTE_ARCH_X86_64 > +#if !defined(RTE_ARCH_X86_64) && !defined(RTE_ARCH_ARM64) > RTE_SET_USED(first); > RTE_SET_USED(last); > RTE_SET_USED(list); > @@ -88,7 +88,7 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list= , > void **obj_table, > struct rte_stack_lf_elem **last) > { > -#ifndef RTE_ARCH_X86_64 > +#if !defined(RTE_ARCH_X86_64) && !defined(RTE_ARCH_ARM64) > RTE_SET_USED(obj_table); > RTE_SET_USED(last); > RTE_SET_USED(list); > diff --git a/lib/librte_stack/rte_stack_lf_generic.h > b/lib/librte_stack/rte_stack_lf_generic.h > index 3182151..488fd9f 100644 > --- a/lib/librte_stack/rte_stack_lf_generic.h > +++ b/lib/librte_stack/rte_stack_lf_generic.h > @@ -36,7 +36,7 @@ __rte_stack_lf_push_elems(struct rte_stack_lf_list > *list, > struct rte_stack_lf_elem *last, > unsigned int num) > { > -#ifndef RTE_ARCH_X86_64 > +#if !defined(RTE_ARCH_X86_64) && !defined(RTE_ARCH_ARM64) > RTE_SET_USED(first); > RTE_SET_USED(last); > RTE_SET_USED(list); > @@ -84,7 +84,7 @@ __rte_stack_lf_pop_elems(struct rte_stack_lf_list *list= , > void **obj_table, > struct rte_stack_lf_elem **last) > { > -#ifndef RTE_ARCH_X86_64 > +#if !defined(RTE_ARCH_X86_64) && !defined(RTE_ARCH_ARM64) > RTE_SET_USED(obj_table); > RTE_SET_USED(last); > RTE_SET_USED(list); Can we remove this all #ifdef clutter by adding the following $ git diff diff --git a/lib/librte_stack/rte_stack_lf.h b/lib/librte_stack/rte_stack_l= f.h index f5581f0c2..46af08b83 100644 --- a/lib/librte_stack/rte_stack_lf.h +++ b/lib/librte_stack/rte_stack_lf.h @@ -5,7 +5,7 @@ #ifndef _RTE_STACK_LF_H_ #define _RTE_STACK_LF_H_ -#ifdef RTE_USE_C11_MEM_MODEL +#if defined (RTE_USE_C11_MEM_MODEL) && defined(RTE_ARCH_X86_64) && defined= (RTE_ARCH_ARM64) #include "rte_stack_lf_c11.h" #else #include "rte_stack_lf_generic.h"