From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4C14A0487 for ; Tue, 2 Jul 2019 16:26:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A13165B34; Tue, 2 Jul 2019 16:26:39 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 0CE65A3; Tue, 2 Jul 2019 16:26:37 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x62EPafA016039; Tue, 2 Jul 2019 07:26:37 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=lbUZI4YkQOkrBIlX81w8DGU2/FIYNvBb7E0aKM/D+U8=; b=H6kd1t5ymHHwXv+j4of26I3Xe+oTyNPTrBXvN9qGrAbkQhFlUY53mLLHARcMp7zhmPdy +oFKAe6HEXkW0m9qppj9vhqwEgCsQcHV9++PGAUxnWA22Vnr35ko4r1fW2+Ur1YkTget ceHv6P9QiP9Na5MWNBDdIIc18eyUGxrGpUxBG2bpqvygHNL23iE2uDJBf68ySKS6jB1X kIPewdwAtJxwSj1Mofb2IQN9pKl+ZQMcwvHWWqtQpz4jRU2s7tCBLi4eGgK2NouUKmF9 TQaLo0ZXn3/ifLqzeXvUGYk6Me3fJ+7EuEEhOImlOsCO5MWgcfHgXQWAAM9WI5PHIk5o 2Q== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2tg4jrsbxj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 02 Jul 2019 07:26:36 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 2 Jul 2019 07:26:35 -0700 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (104.47.34.54) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 2 Jul 2019 07:26:35 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lbUZI4YkQOkrBIlX81w8DGU2/FIYNvBb7E0aKM/D+U8=; b=AbgljfDL9ST2+dLBVT+rAnw/4N22wEX/yDoxVIpZm8kRSJagUAKrwTv5sqhA0c3d3kNkOhHkmwibRdaD7oDZnQD+G9TgXZMQS0yUxcZGQ7tiGli1fXBhgWYX1xHeoPfvUNxzlKuV5JPSfn0JDy0Ogz9GxSAOIjB9mLHLWgXnjB8= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2487.namprd18.prod.outlook.com (20.179.92.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Tue, 2 Jul 2019 14:26:34 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2032.019; Tue, 2 Jul 2019 14:26:34 +0000 From: Jerin Jacob Kollanukkaran To: Anoob Joseph , Thomas Monjalon CC: "dev@dpdk.org" , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , Nikhil Rao , "Erik Gabriel Carrillo" , Abhinandan Gujjar , Bruce Richardson , Pablo de Lara , Narayana Prasad Raju Athreya , Lukas Bartosik , "Pavan Nikhilesh Bhagavatula" , Hemant Agrawal , Nipun Gupta , Harry van Haaren , Liang Ma , "techboard@dpdk.org" Thread-Topic: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library Thread-Index: AQHVMODge3B8IezHZUy8K0yHluEDD6a3YQHw Date: Tue, 2 Jul 2019 14:26:34 +0000 Message-ID: References: <2775383.qy1u6QUkDx@xps> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.200.248.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 86696b54-6575-43b5-7c91-08d6fef9490d x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2487; x-ms-traffictypediagnostic: BYAPR18MB2487: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 008663486A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(39860400002)(396003)(136003)(346002)(366004)(199004)(189003)(13464003)(68736007)(561944003)(7696005)(186003)(25786009)(99286004)(9686003)(26005)(102836004)(6436002)(14454004)(6246003)(33656002)(3846002)(6116002)(76176011)(53936002)(4326008)(66066001)(14444005)(256004)(76116006)(7416002)(5660300002)(73956011)(6506007)(110136005)(446003)(11346002)(53546011)(66946007)(8936002)(66556008)(66476007)(316002)(54906003)(486006)(478600001)(66574012)(71200400001)(71190400001)(64756008)(8676002)(81166006)(74316002)(52536014)(81156014)(476003)(2906002)(86362001)(66446008)(229853002)(305945005)(55016002)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2487; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: AiXg4DgQ1wveH/+gP5mUndsGPH5CGpcPvXzWwizVLHm5D0zh/ibtozUV1ip6BRf0V5fFbXRgthJuZWTNh99F4U4ya4nTZEN5Od1cjkb5HIyklq+QXjpO9Fum5cbfvXd7ewSSwxaiyyCK/ACVXbZZ848QNWH5Ab+vSHDVqn8r27zTmk6VDLuuQ3p0Q301MKZQiCK//8BrZNaCxpnmsYrXsRQ8AAmTA7hbxHwC9V2/M4YQTowJb7TUnIpCpsU//IXcIjTxmOmYIojmruD1hD9Qe/WrU8Joz5FuGKRGcjqNYVw2nkh3aKccUNYmFClFTVVOo1XnFVLwxNBZCkAQCpxWixRLsMcgW4P4RPle0ir1RYkovgQ92CVtf9ERcyOijxWpEifF+bJ6274wprgkDZrpSZNm6WXQtCyvDT8BcLEFkgE= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 86696b54-6575-43b5-7c91-08d6fef9490d X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2019 14:26:34.3277 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2487 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-02_07:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Anoob Joseph > Sent: Tuesday, July 2, 2019 7:47 PM > To: Thomas Monjalon ; Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org; Mattias R=F6nnblom ; > Nikhil Rao ; Erik Gabriel Carrillo > ; Abhinandan Gujjar ; > Bruce Richardson ; Pablo de Lara > ; Narayana Prasad Raju Athreya > ; Lukas Bartosik ; Pavan > Nikhilesh Bhagavatula ; Hemant Agrawal > ; Nipun Gupta ; Harry van > Haaren ; Liang Ma ; > techboard@dpdk.org > Subject: RE: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper > library >=20 > Hi Thomas, Jerin, >=20 > Is there any consensus on how we should proceed? Can this be taken up by > techboard? For me it make sense to move these helper functions to examples/.. and mak= e it as standalone(not as library) Suggested directory(In the order of my preference). No strong preference on= the directory name though 1) examples/helper or 2) examples/common or 3) examples/utils Thomas? Bruce? >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: dev On Behalf Of Anoob Joseph > > Sent: Friday, June 28, 2019 5:04 PM > > To: Thomas Monjalon ; Jerin Jacob Kollanukkaran > > > > Cc: dev@dpdk.org; Mattias R=F6nnblom ; > > Nikhil Rao ; Erik Gabriel Carrillo > > ; Abhinandan Gujjar > > ; Bruce Richardson > > ; Pablo de Lara > > ; Narayana Prasad Raju Athreya > > ; Lukas Bartosik ; Pavan > > Nikhilesh Bhagavatula ; Hemant Agrawal > > ; Nipun Gupta ; Harry > van > > Haaren ; Liang Ma ; > > techboard@dpdk.org > > Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode > > helper library > > > > Hi Thomas, Jerin, > > > > > -----Original Message----- > > > From: dev On Behalf Of Thomas Monjalon > > > Sent: Friday, June 28, 2019 2:10 PM > > > To: Jerin Jacob Kollanukkaran ; Anoob Joseph > > > > > > Cc: dev@dpdk.org; Mattias R=F6nnblom ; > > > Nikhil Rao ; Erik Gabriel Carrillo > > > ; Abhinandan Gujjar > > > ; Bruce Richardson > > > ; Pablo de Lara > > > ; Narayana Prasad Raju Athreya > > > ; Lukas Bartosik ; > > > Pavan Nikhilesh Bhagavatula ; Hemant > > > Agrawal ; Nipun Gupta > ; > > > Harry > > van > > > Haaren ; Liang Ma > > > ; techboard@dpdk.org > > > Subject: [EXT] Re: [dpdk-dev] [PATCH 00/39] adding eventmode helper > > > library > > > > > > External Email > > > > > > -------------------------------------------------------------------- > > > -- > > > 28/06/2019 05:37, Jerin Jacob Kollanukkaran: > > > > From: Anoob Joseph > > > > > From: Jerin Jacob Kollanukkaran > > > > > > From: Anoob Joseph > > > > > > > The helper library will be experimental while we add > > > > > > > event-mode support for other applications like l3fwd & > > > > > > > ipsec-secgw. I expect the helper library to be complete over > > > > > > > the course of those applications also using the helper librar= y. > > > > > > You are doing a copy of l2fwd example to add event mode. > > > It was the decision from the techboard to not complicate the original= l2fwd. > > > But it makes me nervous to see some code duplicated, especially if > > > you plan to do the same for l3fwd and ipsec-secgw. > > > We are not going to duplicate every examples. We should re-consider. > > > > > > > [Anoob] For l3fwd & ipsec-secgw, the plan is to add eventmode in the > > original application itself. If you have concerns about code > > duplication in l2fwd-event, the changes can be added to l2fwd itself. P= lease > advise on how to proceed. > > > > > > > > I have only concern about moving this as library inside > > > > > > eventdev that till we have mature version of helper library > > > > > > the eventdev library ABI will not stable(i.e .so file version > > > > > > needs to be incremented as when a change needed). Which align > > > > > > with Mattias thoughts for some other reason:. How about moving > > > > > > this code to > > > > > > 1) example/common or > > > > > > 2) to specific application itself, once at least two > > > > > > applications starts using it then move to Eventdev library. > > > > > > > > > > > > Thoughts? > > > > > > > > > > [Anoob] Either location is not a problem if there is a consensus. > > > > > Earlier the suggestion was to move it to library (when the patch > > > > > was submitted with changes added in app). > > > > > > If there is only one user, making it grow in the application looks > > > to be the best thing to do. > > > Should we use it in more applications before it is more mature? > > > If not, we could move the code in eventdev library when we will use > > > it in more examples. > > > > > > > [Anoob] The proposal with l2fwd-event was to present an easy enough > > example so that the APIs can be decided before moving onto complex > examples. > > Additions to l3fwd & ipsec-secgw is in the pipeline. > > > > > > If there NO objections then lets move to example/common. > > > > > > If we really want to have this library standalone in examples, I > > > suggest to give it a name and not use a "common" directory. > > > > > > > [Anoob] I would suggest to add the eventmode code in 'examples/utils'. > > > > What is being added here can be treated as a utility library. Almost > > all examples have duplicated code for the entire conf parsing, ethdev > > init etc. Anyone who would attempt a new application will have to > > duplicate lot of code. So a similar exercise with regular poll mode is = also > possible. > > > > As for build, we will have the following options, > > > > 1. From the examples//Makefile, build *helper*.o files ( > > '../utils/eventmode_helper.o') and prepare the binary. So each > > application will build its own version of *helper*.c > > +SRCS-y +=3D ../utils/eventmode_helper.c > > > > 2. Make 'examples/utils' a separate library. This way, all > > applications can directly link without having to build separately. > > > > Please do suggest on which would be a good way to execute. > > > > Thanks, > > Anoob