From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <prvs=203071177e=jerinj@marvell.com> Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 5676BA49; Tue, 7 May 2019 14:02:13 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x47Bswgi011467; Tue, 7 May 2019 05:02:07 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=D9pn1pW8vraT8N30LVwCMX/NCGFuOCvDMUOTSAAr7fk=; b=cUtWxivI58ZUBYi3HuQjLsgRstJvndRPcPc1+LCugl18+jJ3qZAJlWDvMxGCWglm/bwa rJU1t44z6SBbFzCI0hLKBKD6iOT+CsQCNzA7pthMYk50iko0NA0xgRCvTcudcyBGu4Dj 2kDU0iZCxJMLN82QHB6fkyikVi76BVuK7u0fuoCXT8t8jv18onwTJYbYWyuSFc7bFx+X NReBYt+d8cDErIGcfNOgCbrSWxu+i7kOI/D3pwzyJrHYM/QHV6O4jmSjnHiy/EOq82pN RG1TNUuSFRsXjvzfW2rATX9Ke5I1th8ZX7hGHI9p/A3hkhgrlHiXNzk8K6arZ58cOElR 5g== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2sb4aa1e2w-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 07 May 2019 05:02:07 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 7 May 2019 05:02:06 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (104.47.42.57) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 7 May 2019 05:02:06 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D9pn1pW8vraT8N30LVwCMX/NCGFuOCvDMUOTSAAr7fk=; b=ri0qbfSKwdDKSLTu76UfGkuQLf7HqcTBCKfZDeaPpdYd2G7WTdeMDsfEEIneVBZdZUaqEqDxHgVgFMaEfha/3IGRXQ0OxPUFE4P1UetQR394VQ3cfFC8EXqwuaS9mM1cLkVSNskGCvVdSzLivOsJANO5V+3Sxh7idfJNttNFigc= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2502.namprd18.prod.outlook.com (20.179.92.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.11; Tue, 7 May 2019 12:02:01 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5827:68d1:b66c:bd2d]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5827:68d1:b66c:bd2d%3]) with mapi id 15.20.1856.012; Tue, 7 May 2019 12:02:01 +0000 From: Jerin Jacob Kollanukkaran <jerinj@marvell.com> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, "yskoh@mellanox.com" <yskoh@mellanox.com> CC: "thomas@monjalon.net" <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>, Shahaf Shuler <shahafs@mellanox.com>, "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>, "stable@dpdk.org" <stable@dpdk.org>, Luca Boccassi <bluca@debian.org>, nd <nd@arm.com>, nd <nd@arm.com> Thread-Topic: [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension Thread-Index: AQHVAcE34j6F5Vu/0kWMIbwj+2gTIqZZkgaAgAAb7oCABPj1AIAAqO3ggAA1sYCAABABIA== Date: Tue, 7 May 2019 12:02:01 +0000 Message-ID: <BYAPR18MB242425E75D5B41BE619EEE3AC8310@BYAPR18MB2424.namprd18.prod.outlook.com> References: <20190502015806.41497-1-yskoh@mellanox.com> <20190503122813.8938-1-yskoh@mellanox.com> <VE1PR08MB514918D7F468D21B2050D50398350@VE1PR08MB5149.eurprd08.prod.outlook.com> <VE1PR08MB514991D9EAB7C1DD7D58768298350@VE1PR08MB5149.eurprd08.prod.outlook.com> <20190503175034.GD2510@mtidpdk.mti.labs.mlnx> <B85DB924-5B3D-419E-8A20-CD88BD47181A@mellanox.com> <BYAPR18MB2424305090CD8C3E65F85212C8310@BYAPR18MB2424.namprd18.prod.outlook.com> <VE1PR08MB5149588FD564F972C35D511E98310@VE1PR08MB5149.eurprd08.prod.outlook.com> In-Reply-To: <VE1PR08MB5149588FD564F972C35D511E98310@VE1PR08MB5149.eurprd08.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [171.61.83.180] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a481695e-d710-4d17-891b-08d6d2e3d090 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2502; x-ms-traffictypediagnostic: BYAPR18MB2502: x-microsoft-antispam-prvs: <BYAPR18MB25027797F9064F878DCB0FB6C8310@BYAPR18MB2502.namprd18.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0030839EEE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(136003)(39860400002)(366004)(396003)(376002)(346002)(189003)(199004)(13464003)(25786009)(6436002)(73956011)(66556008)(76176011)(486006)(446003)(11346002)(2906002)(53936002)(7416002)(305945005)(66066001)(186003)(9686003)(2501003)(74316002)(6246003)(102836004)(55016002)(53546011)(6506007)(229853002)(478600001)(6116002)(26005)(4326008)(476003)(66476007)(3846002)(7736002)(81156014)(66446008)(316002)(66946007)(81166006)(110136005)(54906003)(64756008)(71190400001)(7696005)(71200400001)(76116006)(5660300002)(86362001)(8936002)(68736007)(256004)(99286004)(8676002)(14454004)(33656002)(52536014)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2502; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: zGq9K5MCy8DkW5nM05ZmY+aMMBryN8RZp+bUJQuJW5/iIBs6guYTVgbMnbuNXm7tUNsg08umtkQvkYnvHmzjNZ3/pswzLPKz2AX/X502RR5w1/bM24WjqQZWxD4XMZX6WPeaSDSSBdtD/86mtvD8yL+hAXn/YNePUR3o7pCVg8tPfgwhWHj3/wtvsbFswLBVGHGFpEGyDvPk7d4adUZj9co475Ls9EEDYSlXJtIs+coeqPB1Rr4xF0l75grZGKr+HRo9SZ2iou3YjMmbKCFt3OKi32KgLG8duWv8LG2dBNCxd1xvZQIf1PP2OiezmH87aXA5F/zOBJ7q0vB6quK2mjBXKCuglTONimGp9gLE33i8qrF4YOL/lSiO1WPaBJTc0sALDR2g1v3+3IblZLE1NOCVasEWYsueDlvrnTBTloM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a481695e-d710-4d17-891b-08d6d2e3d090 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2019 12:02:01.5514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2502 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-07_06:, , signatures=0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 07 May 2019 12:02:13 -0000 > -----Original Message----- > From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> > Sent: Tuesday, May 7, 2019 4:34 PM > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; yskoh@mellanox.com > Cc: thomas@monjalon.net; dev@dpdk.org; bruce.richardson@intel.com; Pavan > Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Shahaf Shuler > <shahafs@mellanox.com>; Gavin Hu (Arm Technology China) > <Gavin.Hu@arm.com>; stable@dpdk.org; Luca Boccassi <bluca@debian.org>; > nd <nd@arm.com>; nd <nd@arm.com> > Subject: [EXT] RE: [dpdk-stable] [PATCH v2] build: disable armv8 crypto > extension >=20 > > > Subject: [EXT] Re: [dpdk-stable] [PATCH v2] build: disable armv8 > > > crypto extension > > > > > > > On May 3, 2019, at 10:50 AM, Yongseok Koh <yskoh@mellanox.com> > > > wrote: > > > > > > > >> I think this change might have an impact on the existing users. > > > >> Does this change need to be documented somewhere (at least in the > > > >> release > > > notes)? > > > > > > > > Practically, there would be no impact. Even if user's app makes > > > > use of crypto instructions, the build config of the app should have= the flag. > > > > > > On IRC, I could see you concerned about the case where user app > > > derives build flags from DPDK like apps under the examples directory. > > > Yes, that's a valid concern. > > > > Is there any DPDK example application would depend on the armv8 crypto > > flags? IMO, None of the applications are directly using armv8 crypto > It is not about DPDK's example application. We have control over that. >=20 > > instruction. Even such as comes for any external DPDK app which is not > > in dpdk.org tree then it can be added in APP makefile. > > IMO, app writes should be aware of the need for using +crypto if > > he/she using the crypto instruction. > Agree. But, it might be that the app writer might have depended on the +c= rypto > coming from DPDK build system, in which case, she/he needs to know the > change through release notes? >=20 > I do not think it needs to be documented anywhere else. Agree and no harm in updating the release notes. >=20 > > > > > > > > Thomas/Jerin, where could be the best spot to document it? Just > > > release note? > > > I think release note would be fine. > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0858BA0096 for <public@inbox.dpdk.org>; Tue, 7 May 2019 14:02:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C7C9C3977; Tue, 7 May 2019 14:02:14 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 5676BA49; Tue, 7 May 2019 14:02:13 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x47Bswgi011467; Tue, 7 May 2019 05:02:07 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=D9pn1pW8vraT8N30LVwCMX/NCGFuOCvDMUOTSAAr7fk=; b=cUtWxivI58ZUBYi3HuQjLsgRstJvndRPcPc1+LCugl18+jJ3qZAJlWDvMxGCWglm/bwa rJU1t44z6SBbFzCI0hLKBKD6iOT+CsQCNzA7pthMYk50iko0NA0xgRCvTcudcyBGu4Dj 2kDU0iZCxJMLN82QHB6fkyikVi76BVuK7u0fuoCXT8t8jv18onwTJYbYWyuSFc7bFx+X NReBYt+d8cDErIGcfNOgCbrSWxu+i7kOI/D3pwzyJrHYM/QHV6O4jmSjnHiy/EOq82pN RG1TNUuSFRsXjvzfW2rATX9Ke5I1th8ZX7hGHI9p/A3hkhgrlHiXNzk8K6arZ58cOElR 5g== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2sb4aa1e2w-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 07 May 2019 05:02:07 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 7 May 2019 05:02:06 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (104.47.42.57) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 7 May 2019 05:02:06 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D9pn1pW8vraT8N30LVwCMX/NCGFuOCvDMUOTSAAr7fk=; b=ri0qbfSKwdDKSLTu76UfGkuQLf7HqcTBCKfZDeaPpdYd2G7WTdeMDsfEEIneVBZdZUaqEqDxHgVgFMaEfha/3IGRXQ0OxPUFE4P1UetQR394VQ3cfFC8EXqwuaS9mM1cLkVSNskGCvVdSzLivOsJANO5V+3Sxh7idfJNttNFigc= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2502.namprd18.prod.outlook.com (20.179.92.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.11; Tue, 7 May 2019 12:02:01 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5827:68d1:b66c:bd2d]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5827:68d1:b66c:bd2d%3]) with mapi id 15.20.1856.012; Tue, 7 May 2019 12:02:01 +0000 From: Jerin Jacob Kollanukkaran <jerinj@marvell.com> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, "yskoh@mellanox.com" <yskoh@mellanox.com> CC: "thomas@monjalon.net" <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>, Shahaf Shuler <shahafs@mellanox.com>, "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>, "stable@dpdk.org" <stable@dpdk.org>, Luca Boccassi <bluca@debian.org>, nd <nd@arm.com>, nd <nd@arm.com> Thread-Topic: [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension Thread-Index: AQHVAcE34j6F5Vu/0kWMIbwj+2gTIqZZkgaAgAAb7oCABPj1AIAAqO3ggAA1sYCAABABIA== Date: Tue, 7 May 2019 12:02:01 +0000 Message-ID: <BYAPR18MB242425E75D5B41BE619EEE3AC8310@BYAPR18MB2424.namprd18.prod.outlook.com> References: <20190502015806.41497-1-yskoh@mellanox.com> <20190503122813.8938-1-yskoh@mellanox.com> <VE1PR08MB514918D7F468D21B2050D50398350@VE1PR08MB5149.eurprd08.prod.outlook.com> <VE1PR08MB514991D9EAB7C1DD7D58768298350@VE1PR08MB5149.eurprd08.prod.outlook.com> <20190503175034.GD2510@mtidpdk.mti.labs.mlnx> <B85DB924-5B3D-419E-8A20-CD88BD47181A@mellanox.com> <BYAPR18MB2424305090CD8C3E65F85212C8310@BYAPR18MB2424.namprd18.prod.outlook.com> <VE1PR08MB5149588FD564F972C35D511E98310@VE1PR08MB5149.eurprd08.prod.outlook.com> In-Reply-To: <VE1PR08MB5149588FD564F972C35D511E98310@VE1PR08MB5149.eurprd08.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [171.61.83.180] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a481695e-d710-4d17-891b-08d6d2e3d090 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2502; x-ms-traffictypediagnostic: BYAPR18MB2502: x-microsoft-antispam-prvs: <BYAPR18MB25027797F9064F878DCB0FB6C8310@BYAPR18MB2502.namprd18.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0030839EEE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(136003)(39860400002)(366004)(396003)(376002)(346002)(189003)(199004)(13464003)(25786009)(6436002)(73956011)(66556008)(76176011)(486006)(446003)(11346002)(2906002)(53936002)(7416002)(305945005)(66066001)(186003)(9686003)(2501003)(74316002)(6246003)(102836004)(55016002)(53546011)(6506007)(229853002)(478600001)(6116002)(26005)(4326008)(476003)(66476007)(3846002)(7736002)(81156014)(66446008)(316002)(66946007)(81166006)(110136005)(54906003)(64756008)(71190400001)(7696005)(71200400001)(76116006)(5660300002)(86362001)(8936002)(68736007)(256004)(99286004)(8676002)(14454004)(33656002)(52536014)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2502; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: zGq9K5MCy8DkW5nM05ZmY+aMMBryN8RZp+bUJQuJW5/iIBs6guYTVgbMnbuNXm7tUNsg08umtkQvkYnvHmzjNZ3/pswzLPKz2AX/X502RR5w1/bM24WjqQZWxD4XMZX6WPeaSDSSBdtD/86mtvD8yL+hAXn/YNePUR3o7pCVg8tPfgwhWHj3/wtvsbFswLBVGHGFpEGyDvPk7d4adUZj9co475Ls9EEDYSlXJtIs+coeqPB1Rr4xF0l75grZGKr+HRo9SZ2iou3YjMmbKCFt3OKi32KgLG8duWv8LG2dBNCxd1xvZQIf1PP2OiezmH87aXA5F/zOBJ7q0vB6quK2mjBXKCuglTONimGp9gLE33i8qrF4YOL/lSiO1WPaBJTc0sALDR2g1v3+3IblZLE1NOCVasEWYsueDlvrnTBTloM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a481695e-d710-4d17-891b-08d6d2e3d090 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2019 12:02:01.5514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2502 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-07_06:, , signatures=0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190507120201.ASD1zXGUzOniZljmylv5edA7b0117N9AnVYGB4S6fik@z> > -----Original Message----- > From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> > Sent: Tuesday, May 7, 2019 4:34 PM > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; yskoh@mellanox.com > Cc: thomas@monjalon.net; dev@dpdk.org; bruce.richardson@intel.com; Pavan > Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Shahaf Shuler > <shahafs@mellanox.com>; Gavin Hu (Arm Technology China) > <Gavin.Hu@arm.com>; stable@dpdk.org; Luca Boccassi <bluca@debian.org>; > nd <nd@arm.com>; nd <nd@arm.com> > Subject: [EXT] RE: [dpdk-stable] [PATCH v2] build: disable armv8 crypto > extension >=20 > > > Subject: [EXT] Re: [dpdk-stable] [PATCH v2] build: disable armv8 > > > crypto extension > > > > > > > On May 3, 2019, at 10:50 AM, Yongseok Koh <yskoh@mellanox.com> > > > wrote: > > > > > > > >> I think this change might have an impact on the existing users. > > > >> Does this change need to be documented somewhere (at least in the > > > >> release > > > notes)? > > > > > > > > Practically, there would be no impact. Even if user's app makes > > > > use of crypto instructions, the build config of the app should have= the flag. > > > > > > On IRC, I could see you concerned about the case where user app > > > derives build flags from DPDK like apps under the examples directory. > > > Yes, that's a valid concern. > > > > Is there any DPDK example application would depend on the armv8 crypto > > flags? IMO, None of the applications are directly using armv8 crypto > It is not about DPDK's example application. We have control over that. >=20 > > instruction. Even such as comes for any external DPDK app which is not > > in dpdk.org tree then it can be added in APP makefile. > > IMO, app writes should be aware of the need for using +crypto if > > he/she using the crypto instruction. > Agree. But, it might be that the app writer might have depended on the +c= rypto > coming from DPDK build system, in which case, she/he needs to know the > change through release notes? >=20 > I do not think it needs to be documented anywhere else. Agree and no harm in updating the release notes. >=20 > > > > > > > > Thomas/Jerin, where could be the best spot to document it? Just > > > release note? > > > I think release note would be fine. > >