From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67809A046B for ; Mon, 22 Jul 2019 16:39:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BC5541BE1D; Mon, 22 Jul 2019 16:39:52 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id DBE951BE1C for ; Mon, 22 Jul 2019 16:39:50 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6MEaRGx008152 for ; Mon, 22 Jul 2019 07:39:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=ri4txIFV8epa9HHpyjbZhCGuCdSdonxXr2hI7mt+2Ls=; b=Wx5uYg1dAm9xl8pHpMaaC8AwY7KQXeGITCqdunnCof6gEWRisdx29Tx0pBdjTZ8N/FtG dJHFUzx9GDEDsKm29YcY5K+JOX2W4ZADm4M0zalkJZ9zR1JSAyNqO6X76zzxpNnQmDNU lFE5W1QidrBUybTFOJWM+rQk0SGOZnjhWoxxkuhflqofWHoAUVcZDYLHVtyn2tAAInLd 7QdXnlv7BJXDQv0KUb1t+U9VqQmyDrP6hvAmz8ftf62LLCDw2RYxHEEkC5ivn7Me4L5M B45wz67u6ZlFNTBFZX8b5BE1YfdeheSjsqP5SuQ9YOuknqV09mmfN8V8DiI9WZdr7G+B mQ== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2tv2fj6sd9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Mon, 22 Jul 2019 07:39:49 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 22 Jul 2019 07:39:47 -0700 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (104.47.34.55) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 22 Jul 2019 07:39:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=feTNZrzovdiliSrhxQznjb4Ot2qEeY0XENzdlfB1B05KJTEiy/Ip5/EwTrKosVgK6EAvs34FClqWKWMVLjvNfOqz51LtZme7FMno77kcRrrRDcEM5QUZVc8wgjRoS1dse0LWyOU6aY0nBgrRYUj+D7qVg9wZ140pKI+N4mKnR0CZTa1qPVr2cC3Ex91C+/rmg5Ucm4z4WqcVqQcdV7HXLuORkDwtTpkGJHHbEJv1IQSljG6ENGHdTG7I05sfiBwByGL5NNz/oFHjyvzkQUCwj/ZKy9FBRaZeim6t0SjmHiDnBnyDLylc9xS1hr5sh14u7qspWdUT4H+I49nwMcIL4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ri4txIFV8epa9HHpyjbZhCGuCdSdonxXr2hI7mt+2Ls=; b=K8eheZxGzqDWwDF4NiplpoHva4zlCv/gLh9PJpwPxffCwzXOZk2hK5yhO7O5n4yLyhI9ZAaCBfHCr8dN22U/3S1h8q1EnOwY4jE152uG8XsF0wsadiHySXxkMuxPHCM4x5L2/55b0ppOmomYcobMlSI8OwfLGxuJyi6PGI8k4WhNB6Q6hovR0Mz/sWg0qYa9n9ym64RmZFI8UlaIYtPN3Xre5R9+pQbvf7+iDe0P++pOeGEdj8Od+GWoYgdQRxcpupkhAE7riZZAR7QmFUxI5GerpdVWuh/HrihXmstW+9uzRu5va5RgCGEThtcE0ePL7EZkvnYkOwb9CBzxA7oHAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ri4txIFV8epa9HHpyjbZhCGuCdSdonxXr2hI7mt+2Ls=; b=f6ANV/XOBPEL1IWuAOsgxYMoYCF/9QiOwRz8jvVpr6PeF3XMg9lM37/s/UsUHEPT02OvLVr8+Lng9Y6IG4uwNLIqW5miHkLPJG28zOHiKQVdGM7emIaeTuCzASQCoxY8sTr0O9cbubXIUGukBU3puOxTPPZnhPB4ygCRiKx1tuM= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2919.namprd18.prod.outlook.com (20.179.59.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.17; Mon, 22 Jul 2019 14:39:42 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2094.013; Mon, 22 Jul 2019 14:39:42 +0000 From: Jerin Jacob Kollanukkaran To: Krzysztof Kanas , "dev@dpdk.org" , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda CC: Krzysztof Kanas Thread-Topic: [dpdk-dev] [PATCH] net/octeontx2: fix driver reconfiguration Thread-Index: AQHVQI5B3n/wAIqph0iu794nQlbecabWtTag Date: Mon, 22 Jul 2019 14:39:42 +0000 Message-ID: References: <20190722130558.13063-1-kkanas@marvell.com> In-Reply-To: <20190722130558.13063-1-kkanas@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.200.248.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ab54ca46-9c22-40db-75ac-08d70eb26ef0 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2919; x-ms-traffictypediagnostic: BYAPR18MB2919: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 01068D0A20 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(376002)(396003)(366004)(346002)(189003)(199004)(13464003)(110136005)(14454004)(2906002)(6636002)(2501003)(316002)(71190400001)(71200400001)(68736007)(33656002)(8676002)(3846002)(6116002)(74316002)(7736002)(305945005)(99286004)(7696005)(66066001)(476003)(11346002)(446003)(6506007)(186003)(53546011)(26005)(76176011)(6436002)(55016002)(486006)(76116006)(52536014)(107886003)(66476007)(64756008)(66556008)(66446008)(25786009)(5660300002)(102836004)(6246003)(66946007)(9686003)(81156014)(53936002)(256004)(478600001)(8936002)(4326008)(229853002)(86362001)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2919; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: NB2fxNzDjaNrhKX5xsUF5iFSuhPIuHM2qsb6cDyADCiZ7+nWWwZLwH0+yyC4d/w215fJtl2aBYwbAvvxQmi6+eKAAtTqdc3mN9+PxGfWiGhbxo8OzTcNYW2lFV07PA6j+qEoZbLyu7s3whKUvtXU6zFQtK8cy1mLBktXpDtHeQr9/FZikAXXE/E/6ch7ypTVvID3lcLDa5+UyQ4SeiMkzEj2CMBYQNx4oNMU3ah082bLjxnMUlls2qz550hG6IlMOAdL3euSTVABDEVNtkW+6Az9fV1aF2aocOjdli8JQjcm87RTdSKSr/R79Ov45y/ghbTWDo7q7MQ3pVgC2X7L6Oz7R9ZSuOcCbFeDu0PiZwvtVUkUyZsHdxmhenBPMlWfnmplsmTpO0fNF1lAd1JY5cYqZRMShLn2nPvb/wh9eFk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ab54ca46-9c22-40db-75ac-08d70eb26ef0 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2019 14:39:42.3085 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2919 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-22_11:2019-07-22,2019-07-22 signatures=0 Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix driver reconfiguration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: kkanas@marvell.com > Sent: Monday, July 22, 2019 6:36 PM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Nithin > Kumar Dabilpuram ; Kiran Kumar Kokkilagadda > > Cc: Krzysztof Kanas > Subject: [dpdk-dev] [PATCH] net/octeontx2: fix driver reconfiguration >=20 > From: Krzysztof Kanas >=20 > When configure returns error, e.g. in case not supported offloads (outer = ip > and sctp) driver released Rx,Tx queues. Then in case of correct configura= tion > the driver could not start due to queues already released but the driver > thought it was configured correctly. >=20 > Secondly if driver returns error from configuration librte_ethdev will re= lease, > rx queues and tx queues, without chaining driver configured state. >=20 > Fix that by 'releasing' configuration and changing driver state when erro= r is > returned from otx2_nix_configure. >=20 > Fixes: 548b5839a32b ("net/octeontx2: add device configure operation") >=20 > Signed-off-by: Krzysztof Kanas > Reviewed-by: Jerin Jacob Kollanukkaran > Reviewed-by: Nithin Kumar Dabilpuram > --- > drivers/net/octeontx2/otx2_ethdev.c | 65 +++++++++++++++++------------ > 1 file changed, 38 insertions(+), 27 deletions(-) >=20 > + if (otx2_dev_is_A0(dev) && Please change to otx2_dev_is_Ax(). See below. > + (txmode->offloads & DEV_TX_OFFLOAD_SCTP_CKSUM) && > + ((txmode->offloads & DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) > || > + (txmode->offloads & DEV_TX_OFFLOAD_OUTER_UDP_CKSUM))) { > + otx2_err("Outer IP and SCTP checksum unsupported"); > + goto fail_configure; > } >=20 > /* Free the resources allocated from the previous configure */ @@ - > 1230,20 +1238,11 @@ otx2_nix_configure(struct rte_eth_dev *eth_dev) > nix_set_nop_rxtx_function(eth_dev); > rc =3D nix_store_queue_cfg_and_then_release(eth_dev); > if (rc) > - goto fail; > + goto fail_configure; > otx2_nix_tm_fini(eth_dev); > nix_lf_free(dev); > } >=20 > - if (otx2_dev_is_Ax(dev) && See above. > - (txmode->offloads & DEV_TX_OFFLOAD_SCTP_CKSUM) && > - ((txmode->offloads & DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) > || > - (txmode->offloads & DEV_TX_OFFLOAD_OUTER_UDP_CKSUM))) { > - otx2_err("Outer IP and SCTP checksum unsupported"); > - rc =3D -EINVAL; > - goto fail; > - }