From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
"yipeng1.wang@intel.com" <yipeng1.wang@intel.com>,
"sameh.gobriel@intel.com" <sameh.gobriel@intel.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>
Cc: "gavin.hu@arm.com" <gavin.hu@arm.com>,
"ruifeng.wang@arm.com" <ruifeng.wang@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>, "nd@arm.com" <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free
Date: Thu, 4 Jul 2019 11:13:52 +0000 [thread overview]
Message-ID: <BYAPR18MB242432645AB60C04AC5E541AC8FA0@BYAPR18MB2424.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20190702211634.37940-1-honnappa.nagarahalli@arm.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Honnappa Nagarahalli
> Sent: Wednesday, July 3, 2019 2:47 AM
> To: yipeng1.wang@intel.com; sameh.gobriel@intel.com;
> bruce.richardson@intel.com; pablo.de.lara.guarch@intel.com;
> honnappa.nagarahalli@arm.com
> Cc: gavin.hu@arm.com; ruifeng.wang@arm.com; dev@dpdk.org;
> nd@arm.com
> Subject: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-
> free
[Snip]
> The first patch in this series moves the signature comparison before the load-
> acquire of the key_index. This does not result in any issues because of the
> full key comparison which is done after the load-acquire of the key_index.
> Performance improvements:
> Lookup Hit: 6.16%
> Lookup Miss: 8.54%
>
> The second patch in this series, moves the store-release of pData before the
> store to any hash internal data structures. This is not necessary, but just
> helps to show the non-dependency between application data and hash table
> data. On the reader side, the pData is loaded only if the keys match, this
> provides performance benefits.
> Performance improvements (with patch 1):
> Lookup Hit: 6.25%
> Lookup Miss: 13.97%
Could you share the commands/data to test this specific performance measurement?
next prev parent reply other threads:[~2019-07-04 11:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 21:15 [dpdk-dev] [PATCH 0/3] " Honnappa Nagarahalli
2019-06-25 21:15 ` [dpdk-dev] [PATCH 1/3] lib/hash: use ordered loads only if signature matches Honnappa Nagarahalli
2019-06-28 18:04 ` Wang, Yipeng1
2019-06-25 21:15 ` [dpdk-dev] [PATCH 2/3] lib/hash: load pData after full key compare Honnappa Nagarahalli
2019-06-28 18:40 ` Wang, Yipeng1
2019-07-02 4:35 ` Honnappa Nagarahalli
2019-07-04 0:39 ` Wang, Yipeng1
2019-07-05 5:33 ` Honnappa Nagarahalli
2019-07-08 16:44 ` Wang, Yipeng1
2019-06-25 21:15 ` [dpdk-dev] [PATCH 3/3] lib/hash: adjust tbl_chng_cnt position Honnappa Nagarahalli
2019-06-28 18:50 ` Wang, Yipeng1
2019-07-02 17:23 ` Honnappa Nagarahalli
2019-07-04 0:52 ` Wang, Yipeng1
2019-07-02 21:16 ` [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free Honnappa Nagarahalli
2019-07-02 21:16 ` [dpdk-dev] [PATCH v2 1/2] lib/hash: use ordered loads only if signature matches Honnappa Nagarahalli
2019-07-02 21:16 ` [dpdk-dev] [PATCH v2 2/2] lib/hash: load pData after full key compare Honnappa Nagarahalli
2019-07-04 11:13 ` Jerin Jacob Kollanukkaran [this message]
2019-07-05 6:08 ` [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free Honnappa Nagarahalli
2019-07-04 16:09 ` Thomas Monjalon
2019-07-05 6:14 ` Honnappa Nagarahalli
2019-07-05 6:29 ` Thomas Monjalon
2019-07-08 16:51 ` Wang, Yipeng1
2019-07-08 18:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB242432645AB60C04AC5E541AC8FA0@BYAPR18MB2424.namprd18.prod.outlook.com \
--to=jerinj@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=sameh.gobriel@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).