From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34C14A0487 for ; Thu, 4 Jul 2019 13:14:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8A1B01BDFD; Thu, 4 Jul 2019 13:14:04 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 00FCE1BDFA for ; Thu, 4 Jul 2019 13:14:02 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x64BB769002844; Thu, 4 Jul 2019 04:13:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=2tCIvkUecG3raroV50oJEd17ac+f43/Y0c++gqOZ5kA=; b=U//H+ccbnzWWGbEtGhDkVTZgDC3gXwiyxRXwUIwMpAxSdUbBiCWnbG3CM91MBL3iavaY +3yCYrFvcuu1XyrRtzYB5eTTle5z5fNUBHPWBnL9uxe92augLAF8TvJ+juK86uIPLvfl hrfvYms8GQql+E8hkVFqadZwAVH5hjI7IfwstWRc53Xj6jW3j6aaXA76Ye9u0rScQKYT vEKJcJ0IIxXSuwc4fToJrYxeguoY2CB96t9CqYT1AfdzOOv7xmLT+OUxQqsfG/qG2HzD Hw68mrO2HlA/4RVVaOVASSScm3umLzBqY+Q89pqFr6z6SZlUlTOLvTFseuVxj7ERG2j9 3A== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2tgtf7551g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 04 Jul 2019 04:13:59 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 4 Jul 2019 04:13:57 -0700 Received: from NAM05-BY2-obe.outbound.protection.outlook.com (104.47.50.52) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 4 Jul 2019 04:13:57 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2tCIvkUecG3raroV50oJEd17ac+f43/Y0c++gqOZ5kA=; b=aBDJXqGOGcdP79e0CGWby4uaNKt+vphtmYmLW3I3GCeWLgrpcsSgyJ1aH82tW8Q2KNDMBuiYb5PZlO6FmxpALF/NaRGkf8E3AZJinhiK9iamZXdiq+LBT9/wJlvklgnNvR8A5EOBQP4bBLulkWGaL6R4p/k7OOpHY9uRmd5DRCU= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2677.namprd18.prod.outlook.com (20.179.94.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.18; Thu, 4 Jul 2019 11:13:53 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2032.019; Thu, 4 Jul 2019 11:13:53 +0000 From: Jerin Jacob Kollanukkaran To: Honnappa Nagarahalli , "yipeng1.wang@intel.com" , "sameh.gobriel@intel.com" , "bruce.richardson@intel.com" , "pablo.de.lara.guarch@intel.com" CC: "gavin.hu@arm.com" , "ruifeng.wang@arm.com" , "dev@dpdk.org" , "nd@arm.com" Thread-Topic: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free Thread-Index: AQHVMRt8hg04f5e7ekuYkLGavrEROaa6UIiA Date: Thu, 4 Jul 2019 11:13:52 +0000 Message-ID: References: <20190625211520.43181-1-honnappa.nagarahalli@arm.com> <20190702211634.37940-1-honnappa.nagarahalli@arm.com> In-Reply-To: <20190702211634.37940-1-honnappa.nagarahalli@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.200.248.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a76e2a82-101f-4e04-3cfa-08d70070b2b8 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2677; x-ms-traffictypediagnostic: BYAPR18MB2677: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 0088C92887 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(39860400002)(346002)(366004)(396003)(199004)(189003)(13464003)(8676002)(66946007)(81166006)(81156014)(6436002)(5660300002)(33656002)(8936002)(446003)(73956011)(71200400001)(71190400001)(64756008)(66446008)(478600001)(14444005)(476003)(66476007)(11346002)(7696005)(4326008)(9686003)(256004)(76116006)(316002)(53936002)(66556008)(54906003)(110136005)(486006)(74316002)(26005)(99286004)(76176011)(55016002)(68736007)(6506007)(25786009)(6116002)(3846002)(53546011)(14454004)(86362001)(6246003)(7736002)(305945005)(229853002)(102836004)(2201001)(2501003)(66066001)(52536014)(2906002)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2677; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 8PdsdY3gIIXS7PgwDWZnBO6/iQhqd/nvh3W/flRMwk55FA69SKG/D9ej3u6bj0gNtA5ED7NtXuXKqaK/bNq6Cj727ddZqz78jHLXm5I+kAvXelGtDCItb0eF11CM4EqV/ZG4PU4z9J/VR8EsFmna/64keQDfyOVS4V5ZUehaqpojp71e6Rg74ZsIDrRaTAl0SFCgUeRToZhj6chCATJVBnC6nYqLNXMsnhKdjVFdj0r0rZgO8uRno+yY2GYqehgW+tUl92yzKzzTgvQeFkI7jc7VXgCGb5jnO070rzCYvDpEXumrGA9IBEXBCwMFVWBZxbXP8CHwJWKUaAg6pwsJBreaj2vso7qX2578SSiW65E6lPmsELjXMHw4kubklmGVnToYpwav17UypZ4L2bN5MmJWAr5NzZELL/RNKmYZhR8= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a76e2a82-101f-4e04-3cfa-08d70070b2b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2019 11:13:52.9391 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2677 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-04_06:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Honnappa Nagarahalli > Sent: Wednesday, July 3, 2019 2:47 AM > To: yipeng1.wang@intel.com; sameh.gobriel@intel.com; > bruce.richardson@intel.com; pablo.de.lara.guarch@intel.com; > honnappa.nagarahalli@arm.com > Cc: gavin.hu@arm.com; ruifeng.wang@arm.com; dev@dpdk.org; > nd@arm.com > Subject: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock- > free [Snip] > The first patch in this series moves the signature comparison before the = load- > acquire of the key_index. This does not result in any issues because of t= he > full key comparison which is done after the load-acquire of the key_index= . > Performance improvements: > Lookup Hit: 6.16% > Lookup Miss: 8.54% >=20 > The second patch in this series, moves the store-release of pData before = the > store to any hash internal data structures. This is not necessary, but ju= st > helps to show the non-dependency between application data and hash table > data. On the reader side, the pData is loaded only if the keys match, thi= s > provides performance benefits. > Performance improvements (with patch 1): > Lookup Hit: 6.25% > Lookup Miss: 13.97% Could you share the commands/data to test this specific performance measure= ment?