From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F645A0487 for ; Fri, 5 Jul 2019 09:49:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E87DD1B95D; Fri, 5 Jul 2019 09:49:40 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 3792A1D7 for ; Fri, 5 Jul 2019 09:49:37 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x657loSM028577; Fri, 5 Jul 2019 00:49:37 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=DnhcCSh4W6maZGhULBUY7RuM8BSWlgjZ5rgLiXnBRw8=; b=TBseoOS3Ek/H5BrQNoqrHVYbEBjfoO89pjWgmDWxOwNuZHXLjQaUiDw4fHtsF6hRB73p Iw28jUGpwkuSnYWxEIa27AEUx85O2JIbgzmskMFUbSjqZphqs4UWii4MwHNC6tJ3oatJ 5YrXR80hFSYkZT49tf/LtZqOfAzTtPAaEQZ4OksQ1WuAi1ooi5foX2Bhk1drVp4svWIi SOMBmLs1+/2VU4K485VrVx7nyF2M5ooqRIt1ePIFNQ0Qgq86Z/kcOg8uYPjEoeCiJxrn dcI3GfmcCpaSl+dLIIpBehZ4ypW9hZH9BbKBjod+ix2PBsHHJ3Rb2XI/F4J999rASyQ8 fw== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2thjyraw77-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 05 Jul 2019 00:49:35 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 5 Jul 2019 00:49:33 -0700 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.57) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 5 Jul 2019 00:49:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DnhcCSh4W6maZGhULBUY7RuM8BSWlgjZ5rgLiXnBRw8=; b=SAOxL8ZsyCYYf9lRxPKmgOz7bHkO3SB6H6xtAuwbuBAqBEcpohzY0YJM2kBu/7yx8Hi9+IhvKqQOdTIixSaJwA6moPeOPIpD9YzIZ3xzzjNPFPAWSHYjjt0YmQZAoKnJjM0ALG3fxncjbadRw+gJX6U4c+uzhnuJJTiw2RlJ3kg= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2664.namprd18.prod.outlook.com (20.179.94.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.15; Fri, 5 Jul 2019 07:49:28 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2032.022; Fri, 5 Jul 2019 07:49:28 +0000 From: Jerin Jacob Kollanukkaran To: Neil Horman CC: "dev@dpdk.org" , Bruce Richardson , Thomas Monjalon Thread-Topic: [EXT] Re: [PATCH v2 09/10] octeonx: mark internal functions with __rte_internal Thread-Index: AdUlJwXZQTavX4ePSluHjIEvEq9NGgAGcBOAA3Dof5A= Date: Fri, 5 Jul 2019 07:49:27 +0000 Message-ID: References: <20190617191341.GC14238@hmswarspite.think-freely.org> In-Reply-To: <20190617191341.GC14238@hmswarspite.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.200.248.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1f03bca7-5eb3-4080-7a7b-08d7011d4eb4 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2664; x-ms-traffictypediagnostic: BYAPR18MB2664: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 008960E8EC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39850400004)(376002)(366004)(136003)(346002)(189003)(199004)(13464003)(26005)(68736007)(25786009)(86362001)(71200400001)(71190400001)(6246003)(5660300002)(66066001)(102836004)(478600001)(6916009)(186003)(3846002)(6116002)(53546011)(6506007)(256004)(99286004)(7696005)(76176011)(14454004)(66476007)(73956011)(66946007)(76116006)(52536014)(4326008)(66556008)(64756008)(66446008)(305945005)(9686003)(446003)(7736002)(53936002)(8936002)(81166006)(81156014)(8676002)(11346002)(476003)(33656002)(486006)(55016002)(2906002)(6436002)(54906003)(316002)(74316002)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2664; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: gVD6AFOeM4n8yhWuva1YYH/M+q9i62Qp2orO7cq7Op6fkH9Ci1Jos7MdOrK0UGuCWi5aBx83TTX3Ki+wQEAMFX+aeFGnUvfd4x7F0X9AzvrTT4b+WAk0xxB5t400IdqES1f15rQQJhXbKu7V1GxY/EJfnBCffiSL5DSrcsNzotkO11WKUqB1OCr5r+kpcGbm8RrwpDdrUff1CYKVdWn+uF9HSjtwhqoY42EWjfS76kLwk1VVko1Std22WIQqxw+y1zs77OOGt4zAJ+FDHT+92HHf3PidNkHy8vrkGDPGOWTs5d7ceMaFFshz+5A7hZ8ymiwQ71QhR5bJRR8gS7eRy06LFEWuQTxt/Dxp4Lbu8vNcuTVsfu5Y+NeRgHSEItIFrcvDQJprbmcUhM1WQY4UnfOBLskUUKr7EfRWUhH6q6Q= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 1f03bca7-5eb3-4080-7a7b-08d7011d4eb4 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2019 07:49:28.0395 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2664 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-05_02:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 09/10] octeonx: mark internal functions with __rte_internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Neil Horman > Sent: Tuesday, June 18, 2019 12:44 AM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Bruce Richardson ; > Thomas Monjalon > Subject: [EXT] Re: [PATCH v2 09/10] octeonx: mark internal functions with > __rte_internal >=20 > On Mon, Jun 17, 2019 at 04:09:26PM +0000, Jerin Jacob Kollanukkaran wrote= : > > > -----Original Message----- > > > From: Neil Horman > > > Sent: Thursday, June 13, 2019 7:54 PM > > > To: dev@dpdk.org > > > Cc: Neil Horman ; Jerin Jacob Kollanukkaran > > > ; Bruce Richardson ; > > > Thomas Monjalon > > > Subject: [EXT] [PATCH v2 09/10] octeonx: mark internal functions > > > with __rte_internal > > > > > > + > > > +DPDK_18.05 { > > > + global: > > > + octeontx_logtype_mbox; > > > > It should move to INTERNAL. Right? > > >=20 > So, thats an interesting symbol that we should probably discuss more. > octeontx_logtype_mbox is actually a global int variable, not a function, = and > __rte_internal only works on the latter type of symbol (i.e. the > __attribute__(error(...)) tag only applies to functions. I could create = an > __rte_internal_data data, that can do something simmilar for global > variables, but it occured to me that perhaps global variables should not = be a > method of communication between internal libraries like this (opting inst= ead > for getter and setter methods to protect it, and then exempting those > functions with __rte_internal). I believe David mentioned something alon= g > these lines as well previously, but I didn't want to go making changes li= ke that > without a more focused discussion, so I opted to leave global variables i= n > place for now. >=20 > Thoughts on how to address this case? The runtime log infrastructure currently depends on global variables in DPD= K. Either way is fine with me(Introducing getter/setter vs current scheme). Bu= t it has to be addressed for completeness. >=20 > Neil >=20 > > > + > > > + local: *; > > > +}; > > > -- > > > 2.20.1 > > > >