Re: [dpdk-dev] [PATCH 19/39] eventdev: add common initialize routine for eventmode devs

[Jerin Jacob Kollanukkaran <jerinj@marvell.com>]

> -----Original Message-----
> From: Anoob Joseph <anoobj@marvell.com>
> Sent: Monday, June 3, 2019 11:02 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nikhil Rao
> <nikhil.rao@intel.com>; Erik Gabriel Carrillo <erik.g.carrillo@intel.com>;
> Abhinandan Gujjar <abhinandan.gujjar@intel.com>; Bruce Richardson
> <bruce.richardson@intel.com>; Pablo de Lara
> <pablo.de.lara.guarch@intel.com>
> Cc: Anoob Joseph <anoobj@marvell.com>; Narayana Prasad Raju Athreya
> <pathreya@marvell.com>; dev@dpdk.org; Lukas Bartosik
> <lbartosik@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Nipun Gupta <nipun.gupta@nxp.com>; Harry
> van Haaren <harry.van.haaren@intel.com>; Mattias Rönnblom
> <mattias.ronnblom@ericsson.com>; Liang Ma <liang.j.ma@intel.com>
> Subject: [PATCH 19/39] eventdev: add common initialize routine for
> eventmode devs
> 
> Adding framework for common initialization routine for event mode.
> Event mode would involve initialization of multiple devices, like eventdev,
> ethdev etc and this routine would be the placeholder for all initialization to
> come in.
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> Signed-off-by: Lukasz Bartosik <lbartosik@marvell.com>
> ---
> 
> +/* Helper functions for initialization, & launching workers */
> +
> +/**
> + * Initialize event mode devices
> + *
> + * Application could call this function to get the event device, eth
> +device
> + * and eth rx adapter initialized according to the conf populated using
> +the
> + * command line args.
> + *
> + * Application is expected to initialize the eth device and then the
> +eventmode
> + * helper subsystem will stop & start eth device according to it's
> requirement.
> + * So call to this function should be done after the eth device is
> +successfully
> + * initialized.
> + *
> + * @param mode_conf
> + *   Configuration of the mode in which app is doing packet handling
> + * @return
> + *  - 0 on success.
> + *  - (<0) on failure.
> + */
> +int32_t __rte_experimental
> +rte_eventmode_helper_initialize_devs(
> +		struct rte_eventmode_helper_conf *mode_conf);
> +

# Prefer to change to rte_event_helper_init() and 
introduce the counter part for the same(rte_event_helper_uninit() or rte_event_helper_fini())
# introduce params structure taking another paraments input instead of new APIs.
# let library return rte_event_helper_conf* object for further operations.


>  #ifdef __cplusplus
>  }
>  #endif
> --
> 2.7.4