From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E59DA0471 for ; Wed, 14 Aug 2019 14:40:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E653375B; Wed, 14 Aug 2019 14:40:14 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 40993DE3 for ; Wed, 14 Aug 2019 14:40:13 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x7ECQqUv001530; Wed, 14 Aug 2019 05:40:08 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=INQbsfXPmKz6R4FnDeBOTCwm3BET6Df/YmyD63LIxsU=; b=eLM60m8YvtE8oSwHiAja+KkefYK003oE7ZrQWKSmcRhxWcQmBayrP4Ay2B/24hjR0+0r VFw1s1GBTvKdFG8Y0nSYmzFQEzz7sUScVQFiZa7pDEB0xkDQfOZ8IG+QK39Lojt1yoHQ e0ofsSKHuPYYDiTEp70qxgPJlbHIS3gYo6NwKiSjLqbcj9Wobav0cjfAprDI1rUVvugp PFyqfHdFDQaoBsk5YEj2JXoe1nk2jE7EQKY6BUrg7QanPvyb8WTLn2n6S3LB0NXxZAHm NdGMirenz/qV5tKXBGi15CL9y3k3zFdbZXg7qDIMzFWdhSCA9Z3wrRu8sU2jTtSO80Ua yw== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2ubfacygfs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 14 Aug 2019 05:40:08 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 14 Aug 2019 05:40:07 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.53) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 14 Aug 2019 05:40:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hX0EzPpumOPQlxrXroRZ7MJ+aQy7WOoE5uR///3WiUJWqrYTUKepKobiE5WozW1bK1J1FRGTiseDIfd/sth6EjNQZGCHlv88pBHQ9hBPgJIdYzli0FfXLNMWlGwcDuj4jPyTwP4keU62jweaKoru/MBexo2Yl8lYfOjszwKSurZwMPyZRv2gNCs1M/XLDYGXMEpxjh6CKW7g16bED/m4OVTWjHsUcN3XYCifY62KLVLcNOdIt1XajcFejvE5J2K6a7r2eHy6bMinowZN8v6w/CdfoYRON22LNqDP1q8WnwvaMuSl94QusuE2leQXCIrnAEzNenhbScIQm29LWKRVAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=INQbsfXPmKz6R4FnDeBOTCwm3BET6Df/YmyD63LIxsU=; b=Dkb9O0CBWK+7jWVBeaOLdREqG3Obmi3D1uOeIGQogdPp+QodYb3b4llF7aMGn0CoHHLmRItqtzYfefrm9DFazUwxTsvSQEV9K0WjiJO/PdI8+CI8rS7GURNCDcJztLfqMrxEm7s5K/17ZLG8CjT6f/n2XDzzL1DyxCsQZn9k5rHdKBndXF1NuoZlUh10qKZ3ifREfXglgdtwVQNT2ggQxXRqE8WYLvGH4spqcc/j7tfY0JobqSfDq1JAcGsdf7+0cYiK3ifpKiIEgsGrb8TIbiZSsYbXStSFhMNweIco9TArnPVlUZeuV4zUugRQvCcfuDYHYAa1K5UoDj8gHe4VJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=INQbsfXPmKz6R4FnDeBOTCwm3BET6Df/YmyD63LIxsU=; b=L45aiGUJWtj6ziPykkMc3ZUyki0fnIdREWBKWY3rNub/rD+R4m+QYWxNTgddys4hrSQY6tHebcloScRNNQ4Jdqb41oM35BBegAG7uhP76bvsmaWb3xIQKrO+TyR+2LoArYK/FOUb7urCuYOX+TSS0U4JegRvycoQW4vSdMlZmJA= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2533.namprd18.prod.outlook.com (20.179.93.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.23; Wed, 14 Aug 2019 12:40:02 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5877:72b7:40cf:2013]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5877:72b7:40cf:2013%3]) with mapi id 15.20.2157.022; Wed, 14 Aug 2019 12:40:02 +0000 From: Jerin Jacob Kollanukkaran To: "Phil Yang (Arm Technology China)" , "thomas@monjalon.net" , "gage.eads@intel.com" , "dev@dpdk.org" CC: "hemant.agrawal@nxp.com" , Honnappa Nagarahalli , "Gavin Hu (Arm Technology China)" , nd , nd Thread-Topic: [PATCH v9 1/3] eal/arm64: add 128-bit atomic compare exchange Thread-Index: AdVSe/GcDIRaPYMDT8KYTHZdN80AvwAC1UGAAAVxqVA= Date: Wed, 14 Aug 2019 12:40:02 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [223.226.105.92] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9ca289a9-4fca-43ed-3dab-08d720b48710 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2533; x-ms-traffictypediagnostic: BYAPR18MB2533: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 01294F875B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(346002)(366004)(39860400002)(376002)(199004)(189003)(13464003)(66476007)(71200400001)(9686003)(64756008)(86362001)(6436002)(8936002)(478600001)(33656002)(55016002)(14454004)(256004)(2201001)(81166006)(81156014)(25786009)(76116006)(66556008)(8676002)(66946007)(3846002)(66446008)(71190400001)(6116002)(305945005)(2906002)(74316002)(7736002)(6506007)(6246003)(316002)(53936002)(53546011)(486006)(4326008)(186003)(2501003)(102836004)(26005)(446003)(66066001)(11346002)(476003)(55236004)(110136005)(54906003)(99286004)(76176011)(5660300002)(229853002)(52536014)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2533; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: RnrE1hQZbXR6z4Fv+wE+hgqwmY98pecBVuXt7wvvC0x0Zb+rCRTY5LY3aH4RYiJn6CYWO+y3GBnbJmOQZO/xj3RfLw5rbCNoMb61fngqeV6vkEGdmPowachToHEnafaZEZ1MHjx/FRWN/orgm/DFoj8Y9GYV32MalmUIW2pOyF4caOZyKbCggD9WZO0bEe/qfqHGyRe/5ljZrt+Rx29GMdPd6/wY/ep5zHnCBawcxYeWGvFEWeuG9K27reQFY7OneeCG1sqFoms9Ufz40gQTCB6nMnCs5aud4/KQWkja6DbZo+fNQu2n9H1XlTuTx+2ZMcKDU4hBz1X97yaVy7iXtXbv1ZzTF5FnFXJpW7aaG9nCGv/X6MzXPzr0YdfzOG4wDyS9ufOF1olzasTyYi272DqDSXkjgQFZEVCZDcND2vU= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9ca289a9-4fca-43ed-3dab-08d720b48710 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2019 12:40:02.6726 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DqbxYCA5kRh0AKbVIyk+UpzjJag9QrjSe4FaQc2a4wLIH4mCcmgM0L7nX89sRzAc6kcAuLCGJITgY8pAy7XjMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2533 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-08-14_04:2019-08-14,2019-08-14 signatures=0 Subject: Re: [dpdk-dev] [PATCH v9 1/3] eal/arm64: add 128-bit atomic compare exchange X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Phil Yang (Arm Technology China) > Sent: Wednesday, August 14, 2019 3:55 PM > To: Jerin Jacob Kollanukkaran ; thomas@monjalon.net; > gage.eads@intel.com; dev@dpdk.org > Cc: hemant.agrawal@nxp.com; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; nd ; nd > Subject: [EXT] RE: [PATCH v9 1/3] eal/arm64: add 128-bit atomic compare > exchange >=20 > External Email >=20 > ---------------------------------------------------------------------- > > -----Original Message----- > > From: Jerin Jacob Kollanukkaran > > Sent: Wednesday, August 14, 2019 4:46 PM > > To: Phil Yang (Arm Technology China) ; > > thomas@monjalon.net; gage.eads@intel.com; dev@dpdk.org > > Cc: hemant.agrawal@nxp.com; Honnappa Nagarahalli > > ; Gavin Hu (Arm Technology China) > > ; nd > > Subject: RE: [PATCH v9 1/3] eal/arm64: add 128-bit atomic compare > > exchange > > > > > -----Original Message----- > > > From: Phil Yang > > > Sent: Wednesday, August 14, 2019 1:58 PM > > > To: thomas@monjalon.net; Jerin Jacob Kollanukkaran > > ; > > > gage.eads@intel.com; dev@dpdk.org > > > Cc: hemant.agrawal@nxp.com; Honnappa.Nagarahalli@arm.com; > > > gavin.hu@arm.com; nd@arm.com > > > Subject: [EXT] [PATCH v9 1/3] eal/arm64: add 128-bit atomic compare > > > exchange > > > +#define __HAS_ACQ(mo) ((mo) !=3D __ATOMIC_RELAXED && (mo) !=3D > > > +__ATOMIC_RELEASE) #define __HAS_RLS(mo) ((mo) =3D=3D > > > __ATOMIC_RELEASE || (mo) =3D=3D __ATOMIC_ACQ_REL || \ > > > + (mo) =3D=3D __ATOMIC_SEQ_CST) > > > + > > > +#define __MO_LOAD(mo) (__HAS_ACQ((mo)) ? __ATOMIC_ACQUIRE : > > > +__ATOMIC_RELAXED) #define __MO_STORE(mo) (__HAS_RLS((mo)) ? > > > +__ATOMIC_RELEASE : __ATOMIC_RELAXED) > > > + > > > +#if defined(__ARM_FEATURE_ATOMICS) || > > > defined(RTE_ARM_FEATURE_ATOMICS) > > > +#define __ATOMIC128_CAS_OP(cas_op_name, op_string) > \ > > > +static __rte_noinline rte_int128_t = \ > > > > > > Could you check the cost of making it as __rte_noinline? > > If it is costly, How about having two versions, one with > > __rte_noinline to make compliance with arm64 procedure call standard > > for old gcc and clang. > > Other one without explicit register hardcoding + inline for latest gcc >=20 > Hi Jerin, Hi Phil Yang, > According to the stack_lf_perf_autotest, making it as __rte_noinline has = no > overhead on ThunderX2 with GCC 8.3. > The 'Average cycles per object push/pop' numbers for __rte_noinline and > __rte_always_inline versions are nearly the same. I tested with octeontx2 as well. It is yielding similar result.=20 No change is expected in this patch then.