From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 227FBA0096 for ; Fri, 7 Jun 2019 11:41:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2946D1B994; Fri, 7 Jun 2019 11:41:14 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id DA8F31B953 for ; Fri, 7 Jun 2019 11:41:12 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x579f4tr031837; Fri, 7 Jun 2019 02:41:12 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=KLHYwbIxjXUslJOHmW/il7nKus88TfnZs4/yWzsFkcM=; b=XlNNWdz3VOzBX6L6SD+cMfx1c1EgSi+R6ZaTkLvEZZxS4pm+6BWrQswXVJpeYnPVzpjn 3RYaGrIMJHpd+D146o8TAKAH7VFHe0sTXYDIJnSsQKVN1DZ8ZhijiMFQ4g83rBpsCEWB 20fIVwxM0NbwWftTDjsUmt0z4SaztQP0AAvAuKwNtoJCOk5qCSyQHU15oFoZ9irGyp/t hl5jZrcK4VpyMhChbUZaplRz38SBCISAhEHPJWLH7VKceRMvPanMkM237I7/IhkwJ1G0 6fbAjqs7JYSfWZf8V6uZPtyBEUbSys3/0ymhjWMZFMNj/ezYc+08eajc+nxXd0AB5pj+ jw== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2sydhfsk0x-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 07 Jun 2019 02:41:12 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 7 Jun 2019 02:41:09 -0700 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (104.47.41.52) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 7 Jun 2019 02:41:09 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KLHYwbIxjXUslJOHmW/il7nKus88TfnZs4/yWzsFkcM=; b=U+8oyjoYB2QnJLan88RF/p721+RvBxPMqRjTqCe6OawG8OgxC/3wDuTPFknkDYql76tB/wXw6NXwLA2RCY6AJft46DeU5NpywAaxLzy1Tkkw1k8gkEFVehnAmBKDAk44+jMXhMcIVYLjt6FG2tOnwJ4r23z9GMCxIuYt4P2WQY4= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2680.namprd18.prod.outlook.com (20.179.94.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.14; Fri, 7 Jun 2019 09:41:07 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c%7]) with mapi id 15.20.1965.011; Fri, 7 Jun 2019 09:41:07 +0000 From: Jerin Jacob Kollanukkaran To: Neil Horman CC: Bruce Richardson , "dev@dpdk.org" , Thomas Monjalon Thread-Topic: [EXT] [RFC PATCH 0/2] introduce __rte_internal tag Thread-Index: AQHVEynnIvy0R3R0lkaWrQuIVgPnUKaNTWtQgAAIeYCAABfgAIABAvyAgAAgfgCAAAaRkIAAGyeAgAAFlPCAABM/AIAAAWqggAAE6wCAAAykAIAADEKAgAEYpBA= Date: Fri, 7 Jun 2019 09:41:07 +0000 Message-ID: References: <20190605181108.GC554@hmswarspite.think-freely.org> <20190606113422.GA29521@hmswarspite.think-freely.org> <20190606133503.GB29521@hmswarspite.think-freely.org> <20190606150354.GF29521@hmswarspite.think-freely.org> <20190606152634.GG29521@hmswarspite.think-freely.org> <20190606165541.GH29521@hmswarspite.think-freely.org> In-Reply-To: <20190606165541.GH29521@hmswarspite.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 724e7461-d134-40ce-8b7b-08d6eb2c445b x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2680; x-ms-traffictypediagnostic: BYAPR18MB2680: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0061C35778 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(39850400004)(136003)(396003)(13464003)(199004)(189003)(316002)(53936002)(54906003)(6246003)(966005)(74316002)(9686003)(6306002)(8936002)(68736007)(229853002)(55016002)(478600001)(6436002)(81156014)(14454004)(71190400001)(66066001)(33656002)(2906002)(81166006)(8676002)(71200400001)(4326008)(7736002)(305945005)(11346002)(66946007)(6506007)(53546011)(256004)(3846002)(66446008)(64756008)(66556008)(6116002)(76116006)(73956011)(5660300002)(52536014)(6916009)(86362001)(7696005)(99286004)(446003)(186003)(486006)(26005)(476003)(76176011)(55236004)(25786009)(102836004)(14444005)(66476007); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2680; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ywv1R02XX6tVTXil1OBkRxanW6rcBoUXz5h2p31tBKUm87yWgoK2E+dp8YkZp0e05WjtchBtV9D7NELbz31zk5vQI9Z+3NgdZVbdww/kYt7auphcjWgQA6NFXO+V4PkQNkaeMuBkUtPghLaMh1wtnlYgqYNZTDHShc/h4OS9cZq5fjzQQXkWz1xfM/7RqcHMa/GYovDpobr1050uffeTByqpc+lVALUvDtW1YyYhR3VRyAepJJ7njfy6dzhSgxQM2iUIjc1lecnJscj10Vk0BMSJQGtmtNsrgRnKZsIjCc+LmAxUOwpIzrARWjpOgkUVySe8yy+Z5P0LGhC0+yd4ISpC9qa8jxujDVvwwwSTOTmoJGaU/SplGiJMWZCVLM4AItqE9pJZZWI49fO3AlX40+RT/Ai8fC2R+tkVbSouN30= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 724e7461-d134-40ce-8b7b-08d6eb2c445b X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2019 09:41:07.5833 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2680 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-07_04:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Neil Horman > Sent: Thursday, June 6, 2019 10:26 PM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; dev@dpdk.org; > Thomas Monjalon > Subject: Re: [EXT] [RFC PATCH 0/2] introduce __rte_internal tag >=20 > On Thu, Jun 06, 2019 at 04:23:26PM +0000, Jerin Jacob Kollanukkaran wrote= : > > > -----Original Message----- > > > From: Neil Horman > > > Sent: Thursday, June 6, 2019 8:57 PM > > > To: Jerin Jacob Kollanukkaran > > > Cc: Bruce Richardson ; dev@dpdk.org; > > > Thomas Monjalon > > > Subject: Re: [EXT] [RFC PATCH 0/2] introduce __rte_internal tag > > > > > > On Thu, Jun 06, 2019 at 03:14:42PM +0000, Jerin Jacob Kollanukkaran > wrote: > > > > > > > > > > > > I don't have any strong opinion on name prefix vs marking as > > > __rte_internal. > > > > Or combination of both. I am fine any approach. > > > > > > > > I have only strong option on not to induce objdump dependency for > > > checkpatch. > > > > For the reason mentioned in > > > > http://mails.dpdk.org/archives/dev/2019- > > > June/134160.html. > > > > > > > > > > Sorry, in my haste I didn't fully adress this in your previous email > > > > > > I'm really uncertain what you mean by introducing a checkpatch > > > dependency on objdump here. Theres nothing preventing you from > > > running checkpatch before you build the library. The only thing > > > checkpatch does in dpdk is scan the patches for sytle violations, > > > and for changes in the map file for movement to and from the > EXPERIMENTAL section (i.e. no use of objdump). > > > > > > My patch modifies check-experimental-syms.sh (adding an objdump scan > > > for INTERNAL symbols, and renaming the script to > > > check-special-syms.sh to be more meaningful). That script however, > > > is not run by checkpatch, its run during compilation of the library > > > to ensure that any symbol in a map file is also tagged with > > > __rte_internal in the corresponding object). Theres no path from > > > checkpatches to check-experimental-syms.sh > > > > > > What I meant in my last comment was that any dependency on objdump > > > in check-[experimental|special]-syms.sh already existed prior to this > patch. > > > > I see. I thought your patches addressing issue related to > > http://patches.dpdk.org/patch/53590/ > > > It does, it just does it in a different way than you do it. >=20 > > Where checkpatch.sh complaints when we add new internal driver API > > with out rte_experimental? That's where all the discussion started. > > The reason why I was saying the API name prefix to mark as internal > > API is that checkpatch can detect that case. > > > Ah, thats a fair point, with my approach we need to add some code to chec= k- > symbol-change.sh such that any symbols listed in an INTERNAL section were > ignored. That would provide behavioral compatibility to what you were > doing in your patch. OK. > But regardless, there is no dependency on objdump that wasn't there > before, are we in agreement on that? Yes. >=20 > Neil >=20 > > Example: > > ERROR: symbol otx2_mbox_alloc_msg_rsp is added in the DPDK_19.05 > > section, but is expected to be added in the EXPERIMENTAL section of > > the version map > > > > > > > > > > So I'm unsure why you think checkpatches has a dependency. > > > > > > Neil > > > >