From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50A0FA0613 for ; Tue, 30 Jul 2019 13:04:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6ED7C1C037; Tue, 30 Jul 2019 13:04:03 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 3DF801C00D; Tue, 30 Jul 2019 13:04:02 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6UAxuPr000404; Tue, 30 Jul 2019 04:03:51 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=p3LWeZqH7pPdpAgEJBweyRkFDzA0JytbAeD/nDraSPQ=; b=VxXAO+yoJxxZnfnrzcIkwQwjIle35XZz3lPgqdp9vzHTf8+v+D13M6KSZ0xZZ7srjF1l 3IFjKAlcoiwPnL+wp+Zl9WuG/mbNIECi0mR4m5C5Df3EDXPGSJ1pkrV+408UAfvQfnrj gbTIoeUB7NR2M8e+tX9AfzRCNhs0PAIjjHZmnW4Gysb5S/5eHRuD8Bkba0dKb0eAL6De 1rtzNf/m5/aaInDXrju4CDifioe7d5DjY9GZ2LYbh4vZtroE9BjiLl5Odk1hgxZt+wXf EVyQWSVLs/dodZRnDtsU+l72zQlAUSJi7zPDHrE0nEhk8z/ruMXy/TVrLw12E3Ue+I09 Qw== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2u0kyq4fm3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 30 Jul 2019 04:03:51 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 30 Jul 2019 04:03:50 -0700 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (104.47.33.54) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 30 Jul 2019 04:03:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Seu7xDMjV8VtOL8bHScw4KNqHq2aTMqvPBIP02xFyq7jtQwg+qUXQc6eBsIPJknIE120q8dJgv86hjCGx+D4kOcwy/2iEL/FWBf5rXY6A9TwxBcRMLchcIFb3NI2vxd5yKX+5KzeRtX7hBF/DXT7YuCEO6VgwcU3FaehdSVuL/ASuxVqcwf/7N1qiAEPPyrJpovwUxhxMJyN7g77n2w9kj4kBJjSOKvkQ7qPq/pAjL1tDr4JX7jNYhqmnqpavpUaFYpckZRlzUerYXJ+TYlv9UsmFMJmA2lr+k+QE8Si+uNrTp8HdNxxTLtgYHNpWHatgnWmBk/GnaOKRd6qfzP97w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p3LWeZqH7pPdpAgEJBweyRkFDzA0JytbAeD/nDraSPQ=; b=H71eP+c1EpH1dHOtbyYMS0iF1GDTVR1ifNbNBvhGeKP2LHWtZP9BCM88eJpTEcZUEm8FMJZK6AjMJhfoC9fgoUsxRTWGqray7ZzP3haE5ueqQUVdE2aw0U792tycuYXtayIacUhLHp8p+p2wy5pFwei7u7UqqWEbu664EiMB1f5B1sSZs5hRwvMNv0+8TftFdrvvKx25BARxLsJSlRYmK6attTAHMEwB39VIGkaqX/rxhZW+gcffPniHdvWFNDVNbl1rNo/YlLes/Smh1oaz9fb+gwK8mrjahS6FbUvquPMOeZGeT2mHCe0MLrjWt9rLVKikSqrr2UYDQr42wZ4u5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p3LWeZqH7pPdpAgEJBweyRkFDzA0JytbAeD/nDraSPQ=; b=RT70l1cqKNohNW9WJOonTh+tveksxCOO4LtvMpCV1UApm+UG759rUNOojwHI8MHrVfSv0JGnbEIhydA5Q7w12L5aG+B2ZxVcwwBNSOa0abF0SX3pJW4dSDVm8+6/bPiUqKTwZVLBeAUJrui1q48dH4xS22LIhsN+JyN4p/3KeQI= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2582.namprd18.prod.outlook.com (20.179.93.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Tue, 30 Jul 2019 11:03:49 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2115.005; Tue, 30 Jul 2019 11:03:49 +0000 From: Jerin Jacob Kollanukkaran To: Bruce Richardson , Thomas Monjalon CC: "dev@dpdk.org" , "stable@dpdk.org" , hgovindh , Marko Kovacevic , Ori Kam , Pablo de Lara , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , "drc@linux.vnet.ibm.com" , "ruifeng.wang@arm.com" , "maciej.czekaj@caviumnetworks.com" Thread-Topic: [dpdk-dev] [dpdk-stable] [PATCH v4] examples/l3fwd: fix unaligned memory access Thread-Index: AQHVRrvVHn1tEFvd7UuXlF4L7P0Az6bi/zIg Date: Tue, 30 Jul 2019 11:03:49 +0000 Message-ID: References: <20190726132758.55217-1-hariprasad.govindharajan@intel.com> <20190726135858.55792-1-hariprasad.govindharajan@intel.com> <2414234.RRTHkAQoda@xps> <20190730094721.GB1641@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190730094721.GB1641@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.200.230.107] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9e60d613-60b3-462d-4dc7-08d714dd997f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2582; x-ms-traffictypediagnostic: BYAPR18MB2582: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1284; x-forefront-prvs: 0114FF88F6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(39860400002)(366004)(346002)(396003)(136003)(13464003)(199004)(189003)(66066001)(229853002)(81166006)(81156014)(6116002)(55016002)(102836004)(6436002)(2906002)(186003)(9686003)(5660300002)(76116006)(66946007)(64756008)(66476007)(3846002)(66446008)(66556008)(8676002)(478600001)(26005)(6246003)(53546011)(6506007)(14454004)(53936002)(486006)(54906003)(110136005)(76176011)(14444005)(256004)(8936002)(68736007)(99286004)(7416002)(446003)(316002)(305945005)(476003)(4326008)(7696005)(71200400001)(86362001)(71190400001)(52536014)(74316002)(33656002)(11346002)(25786009)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2582; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: /rgDZRQQQeRdE9oKPyoT1efBqIR9ZWz0oBDXUoYLOc1KFjSEc6+PLr6AnDLXjMVgZEnJKXxy9inOxwlhE351h4CCjTurHoP0sCr69N1SfHEWtlKS2iPp2cLVIGQHoVkn8Ec7+Rxmk4iLVTlH/cIC6SnV4BunjQ97UUp5f/QSD4HEyFzzonBI57voKtpptipnHAF31nu//c/oQf1jfturUKJKknKYgTvKXAqJfekMF6We6ExPyltEBJbycWltXovldYh92+E3b7YeZmUfzC6VCV6ZlSW+F5YSxyzQhvTcflz16DEbWJ4L//mp4uzGRcmiKqjr3KBEvom4IlMXUPqetb4eEj1nHk0mHffKG6SI0Rqnh383mgeRJrhGci0H6dLcxk8F+aeJ/SGPJGz7nhOyaZEbcT0aHVCgRgeQzsg2ZaQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9e60d613-60b3-462d-4dc7-08d714dd997f X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2019 11:03:49.0650 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2582 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-30_05:2019-07-29,2019-07-30 signatures=0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] examples/l3fwd: fix unaligned memory access X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Bruce Richardson > Sent: Tuesday, July 30, 2019 3:17 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; stable@dpdk.org; hgovindh > ; Marko Kovacevic > ; Ori Kam ; Pablo de Lara > ; Radu Nicolau ; > Akhil Goyal ; Tomasz Kantecki > ; drc@linux.vnet.ibm.com; > ruifeng.wang@arm.com; maciej.czekaj@caviumnetworks.com > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] examples/l3fwd: fix unal= igned > memory access >=20 > On Tue, Jul 30, 2019 at 10:50:14AM +0200, Thomas Monjalon wrote: > > Review please? > > > > 26/07/2019 15:58, hgovindh: > > > Fix unaligned memory access when reading IPv6 header which leads to > > > segmentation fault by changing aligned memory read to unaligned > > > memory read. > > > > > > Bugzilla ID: 279 > > > Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") > > > Cc: maciej.czekaj@caviumnetworks.com > > > Cc: stable@dpdk.org > > > Signed-off-by: hgovindh > > > --- a/examples/l3fwd/l3fwd_em.c > > > +++ b/examples/l3fwd/l3fwd_em.c > > > +#if defined RTE_ARCH_X86 > > > + key.xmm[1] =3D _mm_loadu_si128(data1); #else > > > key.xmm[1] =3D *(xmm_t *)data1; > > > - > > > +#endif > > >=20 > The blank line should be re-added below the #ifdef. Apart from that the f= ix looks > correct to me. >=20 > Reviewed-by: Bruce Richardson Reviewed-by: Jerin Jacob