Re: [dpdk-dev] [PATCH] net/octeontx2: drop Rx and L2 error packets

Re: [dpdk-dev] [PATCH] net/octeontx2: drop Rx and L2 error packets

[Pavan Nikhilesh Bhagavatula]

>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of jerinj@marvell.com
>Sent: Tuesday, July 30, 2019 7:57 PM
>To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin Kumar
>Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda
><kirankumark@marvell.com>
>Cc: dev@dpdk.org; thomas@monjalon.net; ferruh.yigit@intel.com
>Subject: [EXT] [dpdk-dev] [PATCH] net/octeontx2: drop Rx and L2 error
>packets
>From: Jerin Jacob <jerinj@marvell.com>
>
>From B0 HW revision onwards, HW can drop the Rx and L2 error
>packets.
>Enable this by default if the feature is available.
>Since this bit field is used as reserved in old HW revisions,
>No need to have additional HW version check.
>
>Signed-off-by: Jerin Jacob <jerinj@marvell.com>

Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

>---
> drivers/net/octeontx2/otx2_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>

Re: [dpdk-dev] [PATCH] net/octeontx2: drop Rx and L2 error packets

[Jerin Jacob Kollanukkaran]

> -----Original Message-----
> From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Sent: Sunday, August 4, 2019 8:52 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Jerin Jacob
> Kollanukkaran <jerinj@marvell.com>; Nithin Kumar Dabilpuram
> <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda
> <kirankumark@marvell.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; ferruh.yigit@intel.com
> Subject: RE: [dpdk-dev] [PATCH] net/octeontx2: drop Rx and L2 error packets
> 
> >-----Original Message-----
> >From: dev <dev-bounces@dpdk.org> On Behalf Of jerinj@marvell.com
> >Sent: Tuesday, July 30, 2019 7:57 PM
> >To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Nithin Kumar
> >Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda
> ><kirankumark@marvell.com>
> >Cc: dev@dpdk.org; thomas@monjalon.net; ferruh.yigit@intel.com
> >Subject: [EXT] [dpdk-dev] [PATCH] net/octeontx2: drop Rx and L2 error
> >packets
> >From: Jerin Jacob <jerinj@marvell.com>
> >
> >From B0 HW revision onwards, HW can drop the Rx and L2 error packets.
> >Enable this by default if the feature is available.
> >Since this bit field is used as reserved in old HW revisions, No need
> >to have additional HW version check.
> >
> >Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> 
> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Applied to dpdk-next-net-mrvl/master. Thanks

> 
> >---
> > drivers/net/octeontx2/otx2_ethdev.c | 1 +
> > 1 file changed, 1 insertion(+)
> >

[dpdk-dev] [PATCH] net/octeontx2: drop Rx and L2 error packets

[jerinj]

From: Jerin Jacob <jerinj@marvell.com>

From B0 HW revision onwards, HW can drop the Rx and L2 error packets.
Enable this by default if the feature is available.
Since this bit field is used as reserved in old HW revisions,
No need to have additional HW version check.

Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/net/octeontx2/otx2_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c
index 3fb7bd93f..4bd945257 100644
--- a/drivers/net/octeontx2/otx2_ethdev.c
+++ b/drivers/net/octeontx2/otx2_ethdev.c
@@ -62,6 +62,7 @@ nix_lf_alloc(struct otx2_eth_dev *dev, uint32_t nb_rxq, uint32_t nb_txq)
 		req->rx_cfg |= BIT_ULL(37 /* CSUM_OL4 */);
 		req->rx_cfg |= BIT_ULL(36 /* CSUM_IL4 */);
 	}
+	req->rx_cfg |= BIT_ULL(32 /* DROP_RE */);
 
 	rc = otx2_mbox_process_msg(mbox, (void *)&rsp);
 	if (rc)
-- 
2.21.0