From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: Vamsi Krishna Attunuru <vattunuru@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
Vamsi Krishna Attunuru <vattunuru@marvell.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>
Subject: Re: [dpdk-dev] [dpdk-devPATCH v2 1/1] common/octeontx2: fix unaligned mbox memory accesses
Date: Fri, 2 Aug 2019 05:57:14 +0000 [thread overview]
Message-ID: <BYAPR18MB2424C0A0242B9761CD8C50B1C8D90@BYAPR18MB2424.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20190802042006.14507-1-vattunuru@marvell.com>
> -----Original Message-----
> From: vattunuru@marvell.com <vattunuru@marvell.com>
> Sent: Friday, August 2, 2019 9:50 AM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> Vamsi Krishna Attunuru <vattunuru@marvell.com>; Nithin Kumar
> Dabilpuram <ndabilpuram@marvell.com>
> Subject: [dpdk-devPATCH v2 1/1] common/octeontx2: fix unaligned mbox
> memory accesses
>
> From: Vamsi Attunuru <vattunuru@marvell.com>
>
> Octeontx2 PMD's mailbox client uses device memory to send messages to
> mailbox server in the admin function Linux kernel driver.
> The device memory used for the mailbox communication needs to be
> qualified as volatile memory type to avoid unaligned device memory
> accesses because of compiler's memory access coalescing.
>
> This patch modifies the mailbox request and responses as volatile type which
> were non-volatile earlier and accessed from unaligned memory addresses.
Please mention this bus error reported with Fedora 30 with gcc 9.1.1
>
> Fixes: 2b71657c8660 ("common/octeontx2: add mbox request and response
> ")
Please fix below check-git-log.sh warnings
Wrong headline prefix:
common/octeontx2: fix unaligned mbox memory accesses
Wrong 'Fixes' reference:
Fixes: 2b71657c8660 ("common/octeontx2: add mbox request and response ")
>
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
With above change:
Acked-by: Jerin Jacob <jerinj@marvell.com>
next prev parent reply other threads:[~2019-08-02 5:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 18:29 [dpdk-dev] [PATCH v1 " vattunuru
2019-08-02 3:51 ` Jerin Jacob Kollanukkaran
2019-08-02 4:20 ` [dpdk-dev] [dpdk-devPATCH v2 " vattunuru
2019-08-02 5:57 ` Jerin Jacob Kollanukkaran [this message]
2019-08-02 6:57 ` [dpdk-dev] [PATCH v3 " vattunuru
2019-08-02 9:55 ` Jerin Jacob Kollanukkaran
2019-08-05 21:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR18MB2424C0A0242B9761CD8C50B1C8D90@BYAPR18MB2424.namprd18.prod.outlook.com \
--to=jerinj@marvell.com \
--cc=dev@dpdk.org \
--cc=ndabilpuram@marvell.com \
--cc=thomas@monjalon.net \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).