From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29163A10DA for ; Fri, 2 Aug 2019 07:57:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BE901C218; Fri, 2 Aug 2019 07:57:20 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id BD6CB1C20C for ; Fri, 2 Aug 2019 07:57:18 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x725tFhW022666; Thu, 1 Aug 2019 22:57:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=C6Se3CNip9PEX67UVwH6puwAjADVPtU6LJ3XnKUKu0Q=; b=lt7e1iDwCh2AOvrY+e3s4QtacZzGtwSkP0YSCJFtmJGGdyDyF14LRVj1RkeRnc59aW+L hMM1NdxYT/ix/6PWHSGDYAdeHLlYgkN6CbsYwwmhdIuhQjwasrQeXOtHcZvu5NYgc7/e DtYERxlkb62UjPg+ve+K5fN70f/aFhD9IE1ApE1FA4w8W9MuKo7FglbQHDNisW6/fHoF H5zg20YMqXrXwMXYgKiifO4R56hP2RFVz29HP+9B+Ia6IOUxcPSl8IzhvsDwD6MnXnpI Rj4iUONXRiLbDYHzIUhNdf3SdUo9S2+P4jipwTiYNS2z4h4hJ4UX+ft2vZUrmcM7s43/ Ow== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2u3jujpth9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 01 Aug 2019 22:57:17 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 1 Aug 2019 22:57:16 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.56) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 1 Aug 2019 22:57:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rt/CoQlWKIYIERIaQ24F2ULfHjmVtdKLuMhg7mIPzkWD1RExcFT/eiBuzw5n5rgldv6dsyfySn26wZZQLEf4zqSsDvpYE/iLl6748v03AYRWDsYB01bGxk+aPmSfkZ4iG6cHf4HfWVBILpqq0OfXmwWgJBkr9tf8zqf90a4izXjz4oSaad9uKHTjh0jObQaRhgVEHGqfVHqmaeZ71VX9Mue0ZeaJLGPa95TIlz1XwvsavM47GpVa41CHVQmbl5jb2IUPEaiBzCSItzyVC1QBz9RQ0jFUqxVGiEuPCsLgl5cOfYpC1Jvx7Gg3/JSFQ1lqfxWVeFm4dzvIoZd0Jlahsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C6Se3CNip9PEX67UVwH6puwAjADVPtU6LJ3XnKUKu0Q=; b=mQjgeMuue69hCNqc1vVIEv/VtHZJKhMkYGlC9MfMseBq8O/wNw8qTkFOglxqM+B1u6rEWsJpbovMtRoS9yQ6KSnpev/9IoNswAt4VvJzPI0Dh3N4ZnPZNODsyV6Ve5YdNrv25dv8oaCtabFtWP9Vx3oShPOZ+HmLQCdqmQWN26rCwsJ5Pfvy1/Ygt7EjkE+xOFNb0YSELqd4cSmso/AX5WX60WVupCmoIaC/jNN9FyNOfjyDxJUCu/nsB2ebbAyIUd8qH3eNnhEOJF6PZmw4bf/fYaLoNehiiWX9esNDQkFB940oMQ3GSyi3qc+SsZwGGgrtI3tn2r/3FireizRJwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C6Se3CNip9PEX67UVwH6puwAjADVPtU6LJ3XnKUKu0Q=; b=ZIw1gr24IU6M5wkhvKe5GfZbVNAY0ehcJUXzWViU5toiryeQLUbBSPRnDdig89neTlDbQLIaXxG13uZAe/iS7t2O/fdYfZfU3W1Al/ykyfXcuwIsce//gO69EAWhsFwYp/aqW2XwnvgR2l9LgDkLWS736fHKihLP9lIg32k4DlA= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2998.namprd18.prod.outlook.com (20.179.94.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.14; Fri, 2 Aug 2019 05:57:15 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2115.005; Fri, 2 Aug 2019 05:57:15 +0000 From: Jerin Jacob Kollanukkaran To: Vamsi Krishna Attunuru , "dev@dpdk.org" CC: "thomas@monjalon.net" , Vamsi Krishna Attunuru , Nithin Kumar Dabilpuram Thread-Topic: [dpdk-devPATCH v2 1/1] common/octeontx2: fix unaligned mbox memory accesses Thread-Index: AQHVSOmaKbMPI+tnAUCowICx3Nh0sKbnW+UA Date: Fri, 2 Aug 2019 05:57:14 +0000 Message-ID: References: <20190801182928.26216-1-vattunuru@marvell.com> <20190802042006.14507-1-vattunuru@marvell.com> In-Reply-To: <20190802042006.14507-1-vattunuru@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 32ac8cb0-b7b3-4314-5070-08d7170e450a x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2998; x-ms-traffictypediagnostic: BYAPR18MB2998: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 011787B9DD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(376002)(39860400002)(396003)(346002)(199004)(189003)(13464003)(316002)(7696005)(66066001)(55016002)(7736002)(8936002)(14444005)(68736007)(66476007)(6506007)(9686003)(53546011)(476003)(256004)(110136005)(446003)(14454004)(66446008)(229853002)(54906003)(55236004)(71190400001)(66556008)(102836004)(5660300002)(71200400001)(33656002)(86362001)(52536014)(76116006)(64756008)(486006)(26005)(74316002)(186003)(4326008)(66946007)(6436002)(25786009)(305945005)(99286004)(76176011)(81156014)(2906002)(6116002)(478600001)(11346002)(81166006)(53936002)(107886003)(6246003)(2501003)(8676002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2998; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 64sTalTgzU782HROBF+tszQ71mkaFGhFkajHsYSkPJ+Kvcia85ja3byPeUHjT6GjXFEOmbjcRkgOf4gQrrUs78kzId/tRgFK0YK7qJPrmNIgUcr9CMjzuHXMWuBf2ysc0lOJazM1W53HvOZbVGWrIIoJyJdPeD/Add8QosjHiIkTsn/bKQEDzJhLJGxpTySPznEUBEpwtbirEJU8bU1Bmqj50NesGJkjbrSlkzjqMwnVc/MfnPfeiBXRFEDuVOQ9XAnbTG0DVS+NG3GI4uD3ZsPTecC640DYTZw7vDKoG3a3LJhs+r/NR4HGTF6wx+QM3LvpXZoVbcr5mxvQ38fqO43oCZDcs3FP00vFzgbRDc7cVmsQe8c+emos96JE5wVfHCzFMRPB5Njw865KB65I5Sb6cQWU5T+CcOScK2NXJ4U= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 32ac8cb0-b7b3-4314-5070-08d7170e450a X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2019 05:57:14.9790 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2998 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-08-02_03:2019-07-31,2019-08-02 signatures=0 Subject: Re: [dpdk-dev] [dpdk-devPATCH v2 1/1] common/octeontx2: fix unaligned mbox memory accesses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: vattunuru@marvell.com > Sent: Friday, August 2, 2019 9:50 AM > To: dev@dpdk.org > Cc: thomas@monjalon.net; Jerin Jacob Kollanukkaran ; > Vamsi Krishna Attunuru ; Nithin Kumar > Dabilpuram > Subject: [dpdk-devPATCH v2 1/1] common/octeontx2: fix unaligned mbox > memory accesses >=20 > From: Vamsi Attunuru >=20 > Octeontx2 PMD's mailbox client uses device memory to send messages to > mailbox server in the admin function Linux kernel driver. > The device memory used for the mailbox communication needs to be > qualified as volatile memory type to avoid unaligned device memory > accesses because of compiler's memory access coalescing. >=20 > This patch modifies the mailbox request and responses as volatile type wh= ich > were non-volatile earlier and accessed from unaligned memory addresses. Please mention this bus error reported with Fedora 30 with gcc 9.1.1 >=20 > Fixes: 2b71657c8660 ("common/octeontx2: add mbox request and response > ") Please fix below check-git-log.sh warnings Wrong headline prefix: common/octeontx2: fix unaligned mbox memory accesses Wrong 'Fixes' reference: Fixes: 2b71657c8660 ("common/octeontx2: add mbox request and respon= se ") >=20 > Signed-off-by: Vamsi Attunuru > Signed-off-by: Nithin Dabilpuram With above change: Acked-by: Jerin Jacob