From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAB60A00E6 for ; Mon, 5 Aug 2019 18:23:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B6EB51BA5E; Mon, 5 Aug 2019 18:23:54 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 355B61B9A5 for ; Mon, 5 Aug 2019 18:23:53 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x75GL2xs022804; Mon, 5 Aug 2019 09:23:52 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=lTlVCebkdMsFldox206AGurWZLASy2rPmipaYSIi5Xs=; b=XiWAzX4jbY/D3qDnnv5U01halEY8pgkQOAhv64VedJ7GmkJwPEFniMLJCQq9svnPZwv3 oF8izY+75d8OU871ZxIOmFMDfTliQAsKXJbJ1aOJJvymm3ejrqZR0eLzAOUBav+5YNsr ZMoNZPPp+TfduUKOfWwqgFBxgqPSjvGQwU4AbU9q4Oa7629n1yFVRG/WQC5g78s5+zh8 u63qcEp6KzaSVS63sKbzovJ1jaxFQzaaEkdFHG4sqVMdtuSDYqI5+MG2J4kjrqklPqbt IJTbJnHtotVYYqgWxsIPcQTev2pMn+0iro/w4rr0BjoKr5+DltMTSzhVZndLAszA1puJ Fw== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2u57mqymcr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 05 Aug 2019 09:23:51 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 5 Aug 2019 09:23:51 -0700 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (104.47.34.59) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 5 Aug 2019 09:23:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T3b5cEtGY+awU8HiVI8YzVkEvVbHjIpyiabBkQe8DnFRs9sKyyGzh7ssaEQkEb7QN6M55TlGilrdrFhjnza82bEF9jxzMoESL/7duogcy2zE8iyOwFP04Z95qAbs6FSAyohC6w0w75z5UO4MFm/P/ABQ2PI7g7WRZeWY/YoNHn/AjVX25E0CdAnsYdAp33ZwY4ZXZT0oRDK1tGYXHrHWyJIJUAtx5YuoXXdNeml8wyGlky1NHlo9mkooJ4Dg2w4XvGrU3wr5Zf2yIuFk52nT6pSFOe2UTT5I4DDznNXMvH22AGVb8jqwg8qZFLz+ZBcjW/2R2/vkBurSFxRzQChdHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lTlVCebkdMsFldox206AGurWZLASy2rPmipaYSIi5Xs=; b=ifEestrYJficDuBpSL8mF7n42AjDTABbIBPwHzP8Pu3wvc4YOY2wIGMvlPbEE0YDrvx5Tb41x+3GTZYE86xgr7MlxBhOXLg8DbhwfMfkSuCMOAjb+d2zC9+sqI4hiRvVaVOxwauIBk8tFPO5YvT6ZCiCuFP+RJAiz4xrYfe3z60PqxTsZ5hTFFJF/Jxwo4uWkpX5aAFKpCIODan7/k9V6ti1+mjUir7aUecToqF1Wpb5YJOsuYmPv5IDoyfBRGB/r5dcazzDyQm8SGL+bmt1ldPm1IoeKS+lt+avw6mhhPqSsgZWd6zPlxcwqr37apiPLDQrSj2dVAOPmf5pMSa2Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lTlVCebkdMsFldox206AGurWZLASy2rPmipaYSIi5Xs=; b=i8UTNT5R6Pp8lh/eF5Vki9msv+BlGYvtAqqd07rKpqjx5l5PEikoSXmgW1VxWQiQgcdmXLCzdT4m+4EQstCIyJex2HW1xqrK6QYbf3lPvEYg0KRklAXeWa99NiBB6CkbWFnJMaBBYZyjmehOdTLq7GKBGmt0PGeLtHpoApctf7c= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2581.namprd18.prod.outlook.com (20.179.93.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.14; Mon, 5 Aug 2019 16:23:47 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5877:72b7:40cf:2013]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::5877:72b7:40cf:2013%3]) with mapi id 15.20.2136.018; Mon, 5 Aug 2019 16:23:47 +0000 From: Jerin Jacob Kollanukkaran To: Vamsi Krishna Attunuru , "dev@dpdk.org" CC: "thomas@monjalon.net" , Vamsi Krishna Attunuru Thread-Topic: [dpdk-dev] [PATCH v2 1/1] net/octeontx2: fix optimal default sqe buffer count Thread-Index: AQHVS6O9/40SXV00FEubAYJ3K0z5j6bsvOSw Date: Mon, 5 Aug 2019 16:23:46 +0000 Message-ID: References: <20190805132936.3904-1-vattunuru@marvell.com> <20190805153739.5657-1-vattunuru@marvell.com> In-Reply-To: <20190805153739.5657-1-vattunuru@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [171.61.87.186] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a4dd66f1-d639-477b-c915-08d719c14acb x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:BYAPR18MB2581; x-ms-traffictypediagnostic: BYAPR18MB2581: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1169; x-forefront-prvs: 01208B1E18 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(136003)(366004)(39860400002)(346002)(13464003)(189003)(199004)(86362001)(66556008)(66476007)(66946007)(229853002)(6116002)(2501003)(76116006)(64756008)(76176011)(66446008)(14454004)(74316002)(2906002)(6506007)(53546011)(81166006)(305945005)(7736002)(81156014)(8676002)(3846002)(33656002)(8936002)(107886003)(6436002)(99286004)(186003)(110136005)(54906003)(316002)(25786009)(55016002)(4326008)(486006)(476003)(53936002)(68736007)(9686003)(446003)(11346002)(6246003)(478600001)(26005)(5660300002)(102836004)(52536014)(66066001)(7696005)(71200400001)(14444005)(256004)(71190400001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2581; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: keHCw73qmf82mLFC7kxAdORb8OTza2GNK9cLV+1bOqKz3deF7QhAXdjXiZNAGy+hwiQtx8GaPuSGI3XO2Lz1eMPlJQobMyRFZIPDAlDccUEwqx4vDUUSmJCZ/hGLJAK7FQ5gYbTu/3vTlVl03fFdogAPqlj/+M8OnxPkA1RoYB+AOD77FDw/b8541xS+uXbZHx7nvlBeHHc1QWkW5QB2vqo14pH+QJShKis0n58AUcnL6qDiiKZin3VkogxdM8YvHYzShRTBmZQmBhOb8WG0X4c7YSDd//G4Qjt4Fdz9EuQDcTdXdZA4ELBwIPNoBgkR3DgMTJu7vYxJ1vlh/h0fNIkG86Naeymbm8uontvdHFg5LACYNWyIIWm4vrsCURPhRKaxr/Eu3wF/QXOS4Go3X5rpBxxyGwR2aJgDYB8tNoI= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a4dd66f1-d639-477b-c915-08d719c14acb X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2019 16:23:46.8977 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2581 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-08-05_08:2019-07-31,2019-08-05 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx2: fix optimal default sqe buffer count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: vattunuru@marvell.com > Sent: Monday, August 5, 2019 9:08 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; Jerin Jacob Kollanukkaran ; > Vamsi Krishna Attunuru > Subject: [dpdk-dev] [PATCH v2 1/1] net/octeontx2: fix optimal default sqe > buffer count >=20 > From: Vamsi Attunuru >=20 > Patch extends minimum supported max_sqb_count devarg value such that it > can limit the max sqb count to 8 buffers and also defines NIX_DEF_SQB and > uses it to compute the number of sqe buffers required for the egress traf= fic. >=20 > NIX_DEF_SQB is defined as 16 which is optimal across multiple > octeontx2 platforms to scale up the performance proportional to the > corresponding port/queue to lcore mappings. >=20 > Fixes: fb0198b7dc07 ("net/octeontx2: add devargs parsing functions") >=20 > Signed-off-by: Vamsi Attunuru Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > --- > V2 Changes: > * Minor correction in commit message. >=20 > drivers/net/octeontx2/otx2_ethdev.c | 2 +- > drivers/net/octeontx2/otx2_ethdev.h | 3 ++- > drivers/net/octeontx2/otx2_ethdev_devargs.c | 2 +- > 3 files changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/octeontx2/otx2_ethdev.c > b/drivers/net/octeontx2/otx2_ethdev.c > index 3fb7bd9..3615ed2 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.c > +++ b/drivers/net/octeontx2/otx2_ethdev.c > @@ -810,7 +810,7 @@ nix_alloc_sqb_pool(int port, struct otx2_eth_txq > *txq, uint16_t nb_desc) >=20 > nb_sqb_bufs =3D nb_desc / sqes_per_sqb; > /* Clamp up to devarg passed SQB count */ > - nb_sqb_bufs =3D RTE_MIN(dev->max_sqb_count, > RTE_MAX(NIX_MIN_SQB, > + nb_sqb_bufs =3D RTE_MIN(dev->max_sqb_count, > RTE_MAX(NIX_DEF_SQB, > nb_sqb_bufs + NIX_SQB_LIST_SPACE)); >=20 > txq->sqb_pool =3D rte_mempool_create_empty(name, > NIX_MAX_SQB, blk_sz, diff --git a/drivers/net/octeontx2/otx2_ethdev.h > b/drivers/net/octeontx2/otx2_ethdev.h > index 720386f..027b909 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.h > +++ b/drivers/net/octeontx2/otx2_ethdev.h > @@ -66,7 +66,8 @@ > (NIX_MAX_FRS - NIX_L2_OVERHEAD) >=20 > #define NIX_MAX_SQB 512 > -#define NIX_MIN_SQB 32 > +#define NIX_DEF_SQB 16 > +#define NIX_MIN_SQB 8 > #define NIX_SQB_LIST_SPACE 2 > #define NIX_RSS_RETA_SIZE_MAX 256 > /* Group 0 will be used for RSS, 1 -7 will be used for rte_flow RSS acti= on*/ > diff --git a/drivers/net/octeontx2/otx2_ethdev_devargs.c > b/drivers/net/octeontx2/otx2_ethdev_devargs.c > index 85e7e31..7dc6e92 100644 > --- a/drivers/net/octeontx2/otx2_ethdev_devargs.c > +++ b/drivers/net/octeontx2/otx2_ethdev_devargs.c > @@ -160,6 +160,6 @@ > RTE_PMD_REGISTER_PARAM_STRING(net_octeontx2, > OTX2_RSS_RETA_SIZE "=3D<64|128|256>" > OTX2_PTYPE_DISABLE "=3D1" > OTX2_SCL_ENABLE "=3D1" > - OTX2_MAX_SQB_COUNT "=3D<32-512>" > + OTX2_MAX_SQB_COUNT "=3D<8-512>" > OTX2_FLOW_PREALLOC_SIZE "=3D<1-32>" > OTX2_FLOW_MAX_PRIORITY "=3D<1-32>"); > -- > 2.8.4