From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D65C1A05D3 for ; Wed, 22 May 2019 18:22:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D6A314C93; Wed, 22 May 2019 18:22:58 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 5B3A74C80; Wed, 22 May 2019 18:22:57 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4MGM2uV017957; Wed, 22 May 2019 09:22:56 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=rAoquWnvslK45viv+glTq/1WlC8IE0oZgkQWcnDiHXo=; b=KhA/SQ+YuO9Ig9GS3sTedsGxyyF7VLtju3NPLWfNZpWIUbMPIo+1YxoxTPTKFjmt6DZf UixoDcWD3tnwO1diu7ObrvrQMNjGFFCXUncVbvaBhXel62TeNCSizwKwzUUYCkh/hGVI 8r0tGxImSVMC8rW32RbqQog7zgHi7xwpqvQNC8lHdC16uGOPP9pFtzhxMjDSj0k2R/1X fwAqiHJBbkpCuK2YkxENpj+GuJClizWCVVj/0E5vM0L1QEIWcIJkbr4QhIQ/SFoj0nMv /qM7ii4PhO52kxog9+nu0wnz3fNzXoT+1LjEClPN6wg1iTQnlYU1iyoSrsDmzvEz4rIh pQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2sn2cbt79y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 22 May 2019 09:22:56 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 22 May 2019 09:22:55 -0700 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (104.47.41.56) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 22 May 2019 09:22:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rAoquWnvslK45viv+glTq/1WlC8IE0oZgkQWcnDiHXo=; b=Sxxj7jjxuhxhXJAd4DoBN0KoML9cNVbuDvfYuaGjX0/oxjscSyBM/J/JQPK5rj6QTDPF/Rpx9Ln0a9AOiCPl+7N0ORYJzzzaxtG2Fq6BLHR2fL6IAm81wtBWohha91H4ibObb4FXuGKrnNWMRJEvpVM2k6UwfqxpuoX5SFAb+cQ= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2743.namprd18.prod.outlook.com (20.179.56.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.18; Wed, 22 May 2019 16:22:53 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c%7]) with mapi id 15.20.1900.020; Wed, 22 May 2019 16:22:53 +0000 From: Jerin Jacob Kollanukkaran To: Neil Horman CC: Bruce Richardson , "dev@dpdk.org" , "thomas@monjalon.net" , "stable@dpdk.org" Thread-Topic: [EXT] Re: [dpdk-dev] Re: [PATCH] devtools: skip the symbol check when map file under drivers Thread-Index: AdUQoxX6c+w8Qg2aQN+DesCxp18kDgABSIsAAABNFlAAAsDHgAABTgOA Date: Wed, 22 May 2019 16:22:53 +0000 Message-ID: References: <20190522141116.GD18629@hmswarspite.think-freely.org> <20190522153843.GF18629@hmswarspite.think-freely.org> In-Reply-To: <20190522153843.GF18629@hmswarspite.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.201.57.97] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 13c05269-a575-4af0-6f08-08d6ded1bdd2 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2743; x-ms-traffictypediagnostic: BYAPR18MB2743: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0045236D47 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(376002)(39860400002)(136003)(396003)(13464003)(189003)(199004)(71190400001)(71200400001)(7696005)(102836004)(2906002)(74316002)(6916009)(478600001)(305945005)(6246003)(86362001)(6506007)(486006)(54906003)(99286004)(3846002)(6116002)(52536014)(55236004)(76176011)(53546011)(5660300002)(316002)(81156014)(81166006)(9686003)(8676002)(446003)(11346002)(76116006)(55016002)(8936002)(476003)(66066001)(6436002)(14454004)(64756008)(4326008)(26005)(7736002)(229853002)(68736007)(53936002)(33656002)(66946007)(186003)(73956011)(25786009)(66476007)(66556008)(66446008)(14444005)(256004); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2743; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kljzpPTePN/Vxm5LCZ71xyASsGs7dB8r+itYL/4sJAwxTMtgWhfMT8lOBqcsm+LhjfVWYmv9yMtAmudbpv3Ml2atNdXQ+q2cHBIBbH0ytnf8X2MB//FDZvfmmuf2w6FzNHtxPdcVRVfSYiiCcDJkqTZDv5GuG2ym8aMu7Om1mGxV+TeRxk6CXpdLAkDvpmALRFsYcaD1PeyeFCNq/59F2RXD8n7p3IEr+T/oxztVXVYDGv7CoQcQqaN3pXFEDQIpVvPy5TpLeAuya+d0unMbSHqaFzusnfejhF53F75X0Vq8sCZqoQ2ZSrVPTD7xusVy+BZUzxiCkbWpzO+lLTcitpSyT7ms2//ZnaZ3bNc378sJW9wHw8Jkvz5f8UHQG6T8cmDo9OT5fkRqCL0nhWc3oDalxN5PiH2ZHYjEYSzKNCc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 13c05269-a575-4af0-6f08-08d6ded1bdd2 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2019 16:22:53.2010 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2743 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-22_09:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: Re: [PATCH] devtools: skip the symbol check when map file under drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Neil Horman > Sent: Wednesday, May 22, 2019 9:09 PM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; dev@dpdk.org; > thomas@monjalon.net; stable@dpdk.org > Subject: Re: [EXT] Re: [dpdk-dev] Re: [PATCH] devtools: skip the symbol > check when map file under drivers >=20 > On Wed, May 22, 2019 at 02:25:14PM +0000, Jerin Jacob Kollanukkaran wrote= : > > > -----Original Message----- > > > From: Neil Horman > > > Sent: Wednesday, May 22, 2019 7:41 PM > > > To: Jerin Jacob Kollanukkaran > > > Cc: Bruce Richardson ; dev@dpdk.org; > > > thomas@monjalon.net; stable@dpdk.org > > > Subject: [EXT] Re: [dpdk-dev] Re: [PATCH] devtools: skip the symbol > > > check when map file under drivers > > > > > > External Email > > > > > > -------------------------------------------------------------------- > > > -- On Wed, May 22, 2019 at 01:41:03PM +0000, Jerin Jacob > > > Kollanukkaran wrote: > > > > > -----Original Message----- > > > > > From: Neil Horman > > > > > Sent: Wednesday, May 22, 2019 6:43 PM > > > > > To: Jerin Jacob Kollanukkaran > > > > > Cc: Bruce Richardson ; dev@dpdk.org; > > > > > thomas@monjalon.net; stable@dpdk.org > > > > > Subject: [EXT] Re: [dpdk-dev] Re: [PATCH] devtools: skip the > > > > > symbol check when map file under drivers > > > > > > > > > > External Email > > > > > > > > > > ---------------------------------------------------------------- > > > > > ---- > > > > > -- On Wed, May 22, 2019 at 11:54:13AM +0000, Jerin Jacob > > > > > Kollanukkaran > > > > > wrote: > > > > > > > -----Original Message----- > > > > > > > From: Bruce Richardson > > > > > > > Sent: Wednesday, May 22, 2019 4:21 PM > > > > > > > To: Jerin Jacob Kollanukkaran > > > > > > > Cc: Neil Horman ; dev@dpdk.org; > > > > > > > thomas@monjalon.net; stable@dpdk.org > > > > > > > Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] devtools: skip the > > > > > > > symbol check when map file under drivers > > > > > > > > > > > > > > > > Sorry, but I'm not ok with this, because many of our > > > > > > > > > DPDK PMDs have functions that get exported which are > > > > > > > > > meant to be called by applications directly. The > > > > > > > > > > > > > > > > OK. Just to update my knowledge, Should those API needs to > > > > > > > > go through ABI/API depreciation process? > > > > > > > > > > > > > > > > Actually, I am concerned about the APIs, which is called > > > > > > > > between drviers not the application. For example, > > > > > > > > drivers/common/dpaax/rte_common_dpaax_version.map > > > > > > > > > > > > > > > > it is not interface to application rather it is for intra d= river case. > > > > > > > > I think, I can change my logic to Skip the symbols which > > > > > > > > NOT starting with > > > > > > > rte_. > > > > > > > > Agree? > > > > > > > > > > > > > > > > Context: > > > > > > > > I am adding a new driver/common/octeontx2 directory and it > > > > > > > > has some API which Needs to shared between drivers not to > > > > > > > > the application. For me, it does not make sense to go > > > > > > > > through any ABI > > > > > process in such case. > > > > > > > > > > > > > > > > > > > > > > > Maybe not, but other drivers will have APIs designed for > > > > > > > apps to call directly - some NIC drivers have them, and I > > > > > > > suspect that rawdev drivers will need them a lot. Therefore, > > > > > > > it's best to have the drivers directory scanned by our toolin= g. > > > > > > > > > > > > Agreed. But all of those API which called directly called > > > > > > from application is starts with rte_ symbol. How about > > > > > > skipping the symbols which is NOT start with rte_* > > > > > > example: > > > > > > drivers/common/octeontx/rte_common_octeontx_version.map > > > > > > drivers/common/dpaax/rte_common_dpaax_version.map > > > > > > > > > > > > > > > > No, that won't work. If you export a function, it doesn't > > > > > matter if its named > > > > > rte_* or not. Its accessible from any library/application that > > > > > cares to call it, > > > > > > > > IMO, The name prefix matters. The rte_* should denote it a DPDK > > > > API and application suppose to use it. > > > > > > > It doesn't, its just a convention. We have no documentation that > > > indicates what the meaning of an rte_* prefix is specficially, above > > > and beyond the fact thats how we name functions in the DPDK. If you > > > want to submit a patch to formalize the meaning of function > > > prefixes, you're welcome too (though I won't support it, perhaps > > > others will). But even if you do, it doesn't address the underlying > > > problem, which is that applications still have access to those symbol= s. > > > Maintaining an ABI by assertion of prefix is really a lousy way to > > > communicate what functions should be accessed by an application and > > > which shouldn't. If a function is exported, and included in the > > > header file, people will try to use > > > > The current scheme in the driver/common is that, the header files are > > NOT made It as public ie not installed make install. > > The consumer driver includes that using relative path wrt DPDK source > directory. > > > Well, thats a step in the right direction. I'd still like to see some en= forcement > to prevent the inadvertent use of those APIs though Yes header file is not exported. Not sure how a client can use those. Other than doing some hacking. >=20 > > Anyway I will add experimental section to make tool happy. > > > That really not the right solution. Marking them as experimental is just > papering over the problem, and suggests to users that they will one day b= e > stable.=20 That what my original concern. > What you want is to explicitly mark those symbols as internal only, so > that any inadvertent use gets flagged. What is your final thought? I can assume the following for my patch generat= ion # No need to mark as experimental # Add @internal to denote it is a internal function like followed some plac= es in EAL. >=20 > Neil > > > >