From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A512A0471 for ; Tue, 16 Jul 2019 07:42:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F57C2BF5; Tue, 16 Jul 2019 07:42:04 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id E90242BE1 for ; Tue, 16 Jul 2019 07:42:02 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6G5e4Id010972; Mon, 15 Jul 2019 22:42:02 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=2pNtaHywTML3FqbzXrJ9b3V2mpCEykYfqQ5Qno7XLLY=; b=rnlE6crMk5i5USOwuFz85bAHQ3xw5AFIqfKCdFBaHjLlBNO4K5Pe9PxJczQFhOs0ENdd AmbSERrgAbtUHp0+6H7LKoIo1AlWjkpqRWj4sU2lAIwbPO2CaJxfdWv1sxk/vdmu/Hy2 GiM2JMh12H8ngTTvvcWamh/6kTa1Gcj/KNBEvgRXhR1PzKIGdhMf3A9XRbabP0tKPA8W BFoU4DQDhjGcm7SX4vq4iW9xDof66N+nCeHFu6wmVln0XsrftLmt3m+BFruciM7EmXxX xWwXndYJ7rI/rQxec9pwg4zjweKWwOHpVFBnuu2m60jTJVH686i3lJPa3wgrGKpam6c0 XA== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2ts0a21p4c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 15 Jul 2019 22:42:02 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 15 Jul 2019 22:42:00 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.51) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 15 Jul 2019 22:42:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k2hLVfMJPwnYGTLNB+H3aSqkH4dnYFoF/gVgYZ0YOaf8ffbd43ecUO0lVwuN1Ra9fnJLsJnlAEnF2FY7eddVGp2/+Aepli0wM6RapcUPI8lEOxNsTx2cSttRHbzql/TdvG5Nb0aOt5JmtTH0Yr3kCzYUNHlMAyUJE7QidsaP1yljutA0w9YeHqZlhNLIxDQs8JlHKTftAv/giEy/0WUxXIr041V9zI38z2Sqvpmlh5ITE4E0ts8vsxSla+xwJUQ+BeykW6trvlR42xrvivqnW8rb313TqiwmH4Sw9TgTBG1iwXIITYqx+AWb1QaHCW1kwdT7YFkKnIoS7Z9iSmFZTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2pNtaHywTML3FqbzXrJ9b3V2mpCEykYfqQ5Qno7XLLY=; b=Rb+wXeHK63GxdtRewHZHvDlEkHv4g78JDGv0TKMVl4nSIgRM330wUWdVA0q7H1Nsx7KN6yZsDaNKS4lpKRU3YOjwarCqbFcA49zlacc2nEYf7Oyyv8o5RRerWUi1eADkr2V8g/+6v0eChVXO8Bfi8N/nLtGHSxWlxYgJRtLwMl6F35VHqA6LoRaiaFxqGtwJ0cbovrrXi53/l6CDxTTGDmjjj3TpWb6tZyZ741/yhcfkhgoceeXnXpDChd1bixgP75AQtsP99xFJPu73HJkrpDXlLFpctkslkZEbXPqhdC6KO/2sOADoNhurVoXmPuTKW7Qk4s7+0nHmOCWqb95uVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2pNtaHywTML3FqbzXrJ9b3V2mpCEykYfqQ5Qno7XLLY=; b=WDPjdEJ0JWq37o35oWoTXfYx2II6AMjFUHT95IJx+IG3Y2UQRwJeWvP362jUUYg39auLv0+vgUZt2ChZFzvBeAWag5O8Lb1oGW6LQVbldqNVPNW5G5aUAazKRICFZT0uvIg4YYIl7DCK2pAWj+RZJA/VZho8xaQcHPyD6l8MX1E= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB3048.namprd18.prod.outlook.com (20.179.60.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.10; Tue, 16 Jul 2019 05:41:55 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2073.012; Tue, 16 Jul 2019 05:41:55 +0000 From: Jerin Jacob Kollanukkaran To: Thomas Monjalon , Sunil Kumar Kori CC: "dev@dpdk.org" , Konstantin Ananyev Thread-Topic: [dpdk-dev] [PATCH] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags Thread-Index: AQHVO1l3tNVUA2YIyEm1ZHxopZZGbKbMuniA Date: Tue, 16 Jul 2019 05:41:55 +0000 Message-ID: References: <1563178677-16356-1-git-send-email-skori@marvell.com> <1710765.olV4FGjhGL@xps> In-Reply-To: <1710765.olV4FGjhGL@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.200.248.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 84f38f99-a6e5-48bd-b351-08d709b05010 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB3048; x-ms-traffictypediagnostic: BYAPR18MB3048: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:363; x-forefront-prvs: 0100732B76 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(376002)(346002)(396003)(136003)(366004)(189003)(199004)(13464003)(66066001)(86362001)(26005)(186003)(6636002)(2906002)(8936002)(11346002)(446003)(54906003)(110136005)(33656002)(476003)(486006)(68736007)(7736002)(14454004)(316002)(3846002)(6116002)(66476007)(305945005)(66946007)(66556008)(64756008)(9686003)(66446008)(74316002)(76116006)(6436002)(5660300002)(71190400001)(71200400001)(966005)(4326008)(229853002)(478600001)(52536014)(76176011)(6506007)(256004)(53936002)(102836004)(25786009)(6246003)(53546011)(81156014)(81166006)(99286004)(55016002)(8676002)(6306002)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB3048; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: PKGXG19Q0o0i0TBYqHMwb90pVMRk8ZZzrj8DbeQiqXelJvsMwHgOm9MkWsP0a+HZPWC6J2XUE7nQxgOVLe2JoeElZSJQ2je2NxUWiDo44Gby3QIUeSdfwH+iaXcumZ0HyaBzgosXXIYvCHPMw2VtGkt/kL8VReNunvxwE1OVdtWhWYkr1tTBNMIzj9MFKnr4fEwU8/wT34aXmSt5VNMC5Gn7nerHMPUdBsv5npf76wIhkY4wwMZu9I8Mubo9Pa6sSs63eQMJx2Apn6uv59P06IFGO94l5TuklyCTKx7somDpMK+HDAKhrxNv0eN0/o/+W9VmA5/1I5bIjdD5SQIijgtYVzenQdMU4f2TinLGVIBg+bf6jnTQABURO1hZdL7ErAd0tWojmqhdDI90dM5Y+tsBanJAoR1kbZCiZZ81PLs= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 84f38f99-a6e5-48bd-b351-08d709b05010 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2019 05:41:55.2303 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB3048 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-16_01:2019-07-16,2019-07-16 signatures=0 Subject: Re: [dpdk-dev] [PATCH] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, July 16, 2019 3:35 AM > To: Sunil Kumar Kori ; Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org; Konstantin Ananyev > Subject: Re: [dpdk-dev] [PATCH] lib/librte_ip_frag: Remove > PKT_TX_IP_CKSUM offload flags >=20 > 15/07/2019 10:17, Sunil Kumar Kori: > > Current patch is part of following patchset > > http://patches.dpdk.org/patch/53475/ > > which is missed to be merged into upstream because of accepted version > > of this patch does not contain this change. > > > > Accepted patchset is given below: > > http://patches.dpdk.org/patch/56202/ > > > > Patchset is already reviewed and acked on maillist. Also > > corrersponding release notes are updated. > [..] > > --- a/lib/librte_ip_frag/rte_ipv4_fragmentation.c > > +++ b/lib/librte_ip_frag/rte_ipv4_fragmentation.c > > - out_pkt->ol_flags |=3D PKT_TX_IP_CKSUM; > > out_pkt->l3_len =3D sizeof(struct rte_ipv4_hdr); >=20 > Jerin, what happened? A part of the patch was missing? Yes. It was my bad. On rebase to top of tree, due to rename of ipv4_hdr to = rte_ipv4_hdr and similar, Those patches need to be manually rebased. > Is this patch really required? Yes. > If this patch is required, the commit log must be changed. Yes. >=20