From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2722A00E6 for ; Tue, 9 Jul 2019 10:19:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE6AD4C90; Tue, 9 Jul 2019 10:19:38 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 20F9B4C8D for ; Tue, 9 Jul 2019 10:19:37 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x698ErLU016358; Tue, 9 Jul 2019 01:19:35 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=1Cemp/l3rVKSgbT0WCgf+dyJVfNGxUsjkkIYk1PNv9c=; b=YCKDJMQYGOj9Ile0OlYbe5qmNTuRhcjqxnY93x+gbnN3168fPBWVp1pOmzUIU7cBMfLC XRjkVHTF2jxEaz94c/F6v5t/6KyXJcIvjei0SG8dc13nE49AOaqxPLIPsxilbNExtbbT qySXcj0RY3u5WHVz6puvDZiBIQjf7LZinSRTduA5PkDk8eIrLW74rC83yNI4D44gOk1g TeODBYqFLxfghZTwASjY1ZgLZcpQrviGJJ5N+A8weH0K6DtT2CpMJIzk5U7DqvdZhD28 JlQ5TKA+H5yWlHqEZpbrW2XrN37M3MaPWOdmD5qcK7Z9jp1EnzlCyr4UJ1Yi/ZWEW+Ku lg== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2tmn10gewc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 09 Jul 2019 01:19:35 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 9 Jul 2019 01:19:33 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.53) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 9 Jul 2019 01:19:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Cemp/l3rVKSgbT0WCgf+dyJVfNGxUsjkkIYk1PNv9c=; b=SlgddzRmCVqI/ozgyk1xby3BWJCiGjO9fELpUa3kIOsKrV/yHLs7Hxt8mqRb4EwTMZ7hZvgorQRi45IQFmnmfk2TOcSAQgybLg8g61GysUM7TrxMnE3tG29uZTjI+cpI2D3qcXHAUGyZL+LpItnLGNsAa5A3QdetTwGWQCUbiVY= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2357.namprd18.prod.outlook.com (20.179.90.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.18; Tue, 9 Jul 2019 08:19:29 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2052.020; Tue, 9 Jul 2019 08:19:29 +0000 From: Jerin Jacob Kollanukkaran To: "Zhang, Qi Z" , Adrien Mazarguil CC: "Su, Simei" , "Wu, Jingjing" , "Xing, Beilei" , "Yang, Qiming" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC] ethdev: support input set change by RSS action Thread-Index: AQHVMil8GKgxkC8jcEuX2cqJ54ZnDqa6K3CAgABXVlaAB0rMAIAAKGvg Date: Tue, 9 Jul 2019 08:19:29 +0000 Message-ID: References: <1562215629-75520-1-git-send-email-simei.su@intel.com> <20190704090719.GK4512@6wind.com> <039ED4275CED7440929022BC67E7061153D5FFD8@SHSMSX105.ccr.corp.intel.com> <20190704140856.GO4512@6wind.com> <039ED4275CED7440929022BC67E7061153D61FCA@SHSMSX105.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153D61FCA@SHSMSX105.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.200.248.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2be95722-f7ef-4742-23cd-08d7044629e9 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2357; x-ms-traffictypediagnostic: BYAPR18MB2357: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0093C80C01 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(39850400004)(366004)(396003)(136003)(189003)(199004)(13464003)(5660300002)(256004)(110136005)(25786009)(71200400001)(33656002)(2906002)(6436002)(71190400001)(54906003)(229853002)(68736007)(11346002)(486006)(476003)(86362001)(4326008)(66066001)(478600001)(102836004)(316002)(446003)(6246003)(73956011)(66946007)(76116006)(14454004)(7736002)(81166006)(53936002)(8936002)(9686003)(55016002)(305945005)(74316002)(8676002)(186003)(66446008)(53546011)(6506007)(6116002)(99286004)(64756008)(76176011)(66476007)(66556008)(7696005)(81156014)(52536014)(3846002)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2357; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 5KM47siX+fXrKKbDc9KSQm8eDU4ISaKxcSi9Hs35g3pbayOYHbJIh0+fYxbI+QHZo77ySWYpjoHZjYMCgqZHZJYgK7h9+or7XkjaxfO8zh/SW+7NKccrdUiMFdB0aOtmFlTvYe5cngtpMB5C5oa6QvNZ8ghnefqbHX3vMYnSqLzuqeZ7+Hs+jMiliPNwGuyB+v85B5FZw1UeXaVO2nECb0FD82S1ePMWXWBK8Us1XstHGjpJxlw2d7z+gvzlBs58aPnM4g7Z3/3wUvH533hseiwBvb6xEq6S4zaJ2PgYZptm3lv1OodiuXyFxhshtUM7H4zrc2Fr4P0PyePRiq7r3ZXS+fgejV2ZVT+1nHsmdli+CD/HEDiqIsyrmxYGirEZUTS20OsjNBFbwlrBzX7apmIVyYdqkDoemYFoMj5u7xw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2be95722-f7ef-4742-23cd-08d7044629e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2019 08:19:29.2691 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2357 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-09_03:, , signatures=0 Subject: Re: [dpdk-dev] [RFC] ethdev: support input set change by RSS action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Zhang, Qi Z > Sent: Tuesday, July 9, 2019 11:11 AM > To: Adrien Mazarguil > Cc: Su, Simei ; Wu, Jingjing ; > Xing, Beilei ; Yang, Qiming ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC] ethdev: support input set change by RSS act= ion > > Right, I had symmetric Toeplitz in mind and wondered what would happen > > when users would not select the required fields. I guess the PMD would > > have to reject unsupported combinations. > > > > > anything I missed, would you share more insight? > > > > No, that answers the question, thanks. > > > > Now what about my suggestion below? In short: extending ETH_RSS_* > > assuming there's enough bits left in there, instead of adding a whole > > new framework and breaking ABI in the process. >=20 > Since the hardware can support any combination of input set (not just 5 > tuples), we'd like to make it more generic. > Those will be some pain due to ABI break, but we think its worth for long > term. # IMO, The decided method should be compatible with normal RSS(without rte_= flow) case=20 as well(Currently is struct rte_eth_conf.rx_adv_conf.rss_conf.rss_hf used=20 in the dev_configure()) as from HW perspective it will be same the HW bloc= k which does=20 both. # From Marvell HW point of view, We can support any combination of input se= t. But it is more of a micro code(i.e need to first provide the list protocol = supported to HW) and then use it latter. So, I think, extending the ETH_RSS_* would be more = portable approach __without loosing__ the functionality. Since there is around 40 bi= ts are left, I think more standard protocol can fit in the 40 bits.=20