From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EAC8A0487 for ; Thu, 4 Jul 2019 14:05:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6145B1BE07; Thu, 4 Jul 2019 14:05:26 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 513571BE04 for ; Thu, 4 Jul 2019 14:05:24 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x64BtQNr005254 for ; Thu, 4 Jul 2019 05:05:23 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=jPJLQg+bzOCQberUnh/wEz7CDqV0iRpz4Cz49bM8/hQ=; b=PePHTyEaC7yIUyP50RZmvXuZxgVOOWym1z2pEwxzqWB5uROAul7Pst/C8XbHKriukO00 ONC06Gd28R5SXRgGUynQxkZJztiZGJNLcvSnrDsbCdfMEn89OQ6LyqNXQVxACGbUcxDD aUHRplQGIOpicWs/zhykXP+5/6o+cmoq3C2Wqu2a4jVFqtXa1CVjEtDu8FLZUuisRg0d ngK+vhQKNzW+z0OcKvbLoAvma/2xHhGwvIobGR8g9hsXfH0SsVamUn/qj5zidE6orukC hvHFRWInUD/pdTrUwreEa8d9QgosADfdsem23OJ1dgsQa52WPdLj9Ju7Jui4mq/mIBuF Gw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2tgtf759xf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 04 Jul 2019 05:05:23 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 4 Jul 2019 05:05:21 -0700 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (104.47.41.55) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 4 Jul 2019 05:05:21 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jPJLQg+bzOCQberUnh/wEz7CDqV0iRpz4Cz49bM8/hQ=; b=u8StMUREIURpyBgyXi3rDzo9i7quGEoMmjOFYm0p81Hjgm281Pa0E68JCwQy39n2eNO0yvdulQuc7bILJoD0NSQ9mW3eBgoMrIWq7yJ2aEKJE8zhuDq50aR/xoPjIudA9QCyVMDzvpVhR75DCWyrHCPmBsM7RkcEEAfaxXPnSPI= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2757.namprd18.prod.outlook.com (20.179.56.223) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Thu, 4 Jul 2019 12:05:16 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2032.019; Thu, 4 Jul 2019 12:05:16 +0000 From: Jerin Jacob Kollanukkaran To: Pavan Nikhilesh Bhagavatula CC: "dev@dpdk.org" , Pavan Nikhilesh Bhagavatula Thread-Topic: [dpdk-dev][PATCH] mempool/octeontx2: fix clang build failure Thread-Index: AQHVMb+xB2W9SBFGhkSkjrV+gHwyU6a6W/DA Date: Thu, 4 Jul 2019 12:05:16 +0000 Message-ID: References: <20190703165220.1068-1-pbhagavatula@marvell.com> In-Reply-To: <20190703165220.1068-1-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.200.248.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 992f7bfc-698b-468a-334f-08d70077e08d x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2757; x-ms-traffictypediagnostic: BYAPR18MB2757: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 0088C92887 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(396003)(366004)(346002)(376002)(136003)(13464003)(199004)(189003)(81166006)(9686003)(81156014)(6306002)(53546011)(55016002)(86362001)(6506007)(33656002)(76176011)(256004)(7696005)(7736002)(14444005)(2906002)(66446008)(486006)(6436002)(6246003)(476003)(64756008)(66946007)(11346002)(66476007)(305945005)(52536014)(66556008)(229853002)(446003)(4326008)(316002)(107886003)(68736007)(3846002)(5660300002)(54906003)(14454004)(966005)(99286004)(25786009)(8676002)(71200400001)(71190400001)(102836004)(6862004)(53936002)(76116006)(73956011)(6116002)(26005)(66066001)(74316002)(478600001)(186003)(8936002)(6636002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2757; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: LC16SaHRxzFv0CjRE4tghJMZ8RXfDh/Gubzit4c06VC42qGr7rhN4fDi7ge0HD+gz18ju21rL2ttQRUq/OaeWEs7t0JSm7H8LCy6DWScwSOau3TIS+ZibyX0Q9KaquvS3IyMBXQ9FgtJvvIXGj/hL6facZQBMNuMtihjCwahXYDYR0pDaoQy1y4C8XuNRuyjmfVR1P32VrAzHm7/3pQhNW7Xj5QIhqe9xjxCWy3eVjeJFOhjDFRpR7JQZ/kTmhcLQFr7BJULGKpKLf5Y+2m8AL4z1rEssJHjEjk/wK8/vKORDhmtq2Fd5m3XTe79QqydozsEzzScJcWLhA0TLc/ab+Zp5t0/UW46sjlg2rXwAyo5ItrwtCoaFo8Al+YhGCKlIdi6OehsoGRNiIMd0oG6qIRTX+/olIghjZm3zVbHcqY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 992f7bfc-698b-468a-334f-08d70077e08d X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2019 12:05:16.3023 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2757 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-04_06:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix clang build failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: pbhagavatula@marvell.com > Sent: Wednesday, July 3, 2019 10:22 PM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [dpdk-dev][PATCH] mempool/octeontx2: fix clang build failure Subject could be: mempool/octeontx2: fix arm64 clang build failure >=20 > From: Pavan Nikhilesh >=20 > The ARMv8.1 CASP instruction works with even register pairs and since the= re > no register constraint in older versions of GCC/Clang, use explicit regis= ter > allocation to satisfy CASP requirements. >=20 > Fixs build issue with arm64-armv8a-linux-clang. Typo >=20 > Fixes: ee338015e7a9 ("mempool/octeontx2: add optimized dequeue > operation for arm64") >=20 > Reported-by: Gavin Hu > Signed-off-by: Pavan Nikhilesh > Signed-off-by: Jerin Jacob > --- >=20 > Upstreamed gcc fix: > https://github.com/gcc-mirror/gcc/commit/a1bdb8f296aac911 >=20 > drivers/mempool/octeontx2/otx2_mempool_ops.c | 278 +++++++++-------- > -- > 1 file changed, 127 insertions(+), 151 deletions(-) >=20 > diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c > b/drivers/mempool/octeontx2/otx2_mempool_ops.c > index 97146d1fe..e1764b030 100644 > --- a/drivers/mempool/octeontx2/otx2_mempool_ops.c > +++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c > @@ -54,233 +54,206 @@ npa_lf_aura_op_search_alloc(const int64_t wdata, > int64_t * const addr, > return 0; > } >=20 > -/* > - * Some versions of the compiler don't have support for __int128_t for > - * CASP inline-asm. i.e. if the optimization level is reduced to -O0 the > - * CASP restrictions aren't followed and the compiler might end up viola= tion > the > - * CASP rules. Fix it by explicitly providing ((optimize("-O3"))). > - * > - * Example: > - * ccSPMGzq.s:1648: Error: reg pair must start from even reg at > - * operand 1 - `casp x21,x22,x0,x1,[x19]' > - */ > -static __attribute__((optimize("-O3"))) __rte_noinline int __hot Better to mention optimize(-O3) removed due lack of clang support. > -#endif > + > +#else Let otx2_npa_deq build for all cases to catch any issue in early stage(i.e = avoid case where building on arm64 not on x86 case) With above fixes: Acked-by: Jerin Jacob