Re: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based on armv8-a

[Jerin Jacob Kollanukkaran <jerinj@marvell.com>]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of lironh@marvell.com
> Sent: Saturday, May 18, 2019 3:04 AM
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; Liron Himi <lironh@marvell.com>
> Subject: [dpdk-dev] [PATCH 1/2] mk: add Marvell ARMADA architecture based
> on armv8-a
> 
> From: Liron Himi <lironh@marvell.com>
> 
> This patch introduces armada target to address difference in number of cores,
> no numa support
> 
> Signed-off-by: Liron Himi <lironh@marvell.com>
> Reviewed-by: Alan Winkowski <walan@marvell.com>
> Tested-by: Liron Himi <lironh@marvell.com>
> ---
>  config/defconfig_arm64-armada-linux-gcc    | 24 ++++++++++++++++++++++++
>  config/defconfig_arm64-armada-linuxapp-gcc | 24 ++++++++++++++++++++++++

Don't create a new file for linuxapp-gcc, instead make sym link like other armv8 config.

>  2 files changed, 48 insertions(+)
>  create mode 100644 config/defconfig_arm64-armada-linux-gcc
>  create mode 100644 config/defconfig_arm64-armada-linuxapp-gcc
> 
> diff --git a/config/defconfig_arm64-armada-linux-gcc
> b/config/defconfig_arm64-armada-linux-gcc
> new file mode 100644
> index 0000000..573b278
> --- /dev/null
> +++ b/config/defconfig_arm64-armada-linux-gcc
> @@ -0,0 +1,24 @@
> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Marvell

s/2018/2019

> +International Ltd #
> +
> +#include "defconfig_arm64-armv8a-linux-gcc"
> +
> +CONFIG_RTE_LIBRTE_MVEP_COMMON=y
> +CONFIG_RTE_LIBRTE_MVPP2_PMD=y
> +CONFIG_RTE_LIBRTE_MVNETA_PMD=y
> +CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y
> +
> +#
> +# Compile Environment Abstraction Layer #
> +CONFIG_RTE_MAX_LCORE=16e 
> +CONFIG_RTE_MAX_NUMA_NODES=1
> +CONFIG_RTE_CACHE_LINE_SIZE=64

Please move this section first, to have symmetry  with other armv8 config file
i.e

# core changes
# PMD changes

With above changes:
Acked-by: Jerin Jacob <jerinj@marvell.com>