From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A47ADA04AC; Fri, 1 May 2020 13:14:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 367221DA1B; Fri, 1 May 2020 13:14:34 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 5E6C11DA18; Fri, 1 May 2020 13:14:33 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 041BBqqL026769; Fri, 1 May 2020 04:14:32 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=pCXj/SdjuSzLWvUmcM0Ei+vbXfGoMFXTbPyiT6AX8Bc=; b=Hq7WKKl3BXnr4ZMLNJJtFMToX1RPc/5DNSE8/kdZ9aWyZbTHUzLi1GIbGiGuIBgFeBJc FVzoVH2McGQtiRw55F5yjWEe7hiVvzMHqFgIszea1WzlmcpeWdsFRJoZL/8SHGngOsQ3 BPpAlsrueMDUxlzwFY/FrpyICvV/dr3BMTBx28Gkm4bwyNEX6xniAtuTKKdaz5RL6flT Cg/DSrlt7tZCHcSEkLwf6G6BUUE0ck4lL9jNAqbi1NswZbgiqkqxjcFz53kqR1/hGM99 1e26kFUPULg1BNG0G/Mx6IkU+diuIxoW6P+wakfAtTb4/P/Z5sJKt0v4pYzTnU1nF3Vh aQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 30r7em28p2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 01 May 2020 04:14:32 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 1 May 2020 04:14:30 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 1 May 2020 04:14:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tf/quTqEBuf3XtwG6ujbeTKAvrO+Y4MeQD3fzkp2knKBM/6ij9/Ubv7AdJVPxOnfKS2tu7bafFH73PZC2qOBk2x2gVg/pfMFr6XNRF78IS7UF0rq7HzWepCqaBzttbq+/EDvddgeqtQTAbtkhYlI3qTYO/DfKny5Ytyyrh4butLEyBIRK8q2rb620SqRlwW/C+cze3wNzvOG1uyRCdB9WTlBFFFoQl7rzyVS2RhNVYSCExMyqsAXExzZRwhAJpatCRxBPKWqgOUNk0traglmaN+0xMFNIR60j3JiQUNVZUCM1DF3kw+w0erJSCyFXn2Xf2N8N+I6JMtL1qwtf4S6SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pCXj/SdjuSzLWvUmcM0Ei+vbXfGoMFXTbPyiT6AX8Bc=; b=eGcFP9w3IyQl14Cy/uGkn1BKkZngPtqnDaz4UhfOaW+K0k2mM0ndXr0HaGbFiQajKTwkyCpGaRQnddX6ZQN/dY2+zeSRU6/BNwH7UM2i98RCqOq6/zQanMKzlsx+0TCNkeOTO5MIjSG5kt5zgDbPgBlJLCUiHM+KEftzrmLyIDj1xxPsB/0kmUyFkITU1Mf8CL6sfkYIuazXq9u3yidVCb2s4UpeLyn9nqIt7sUThUdEGliFzxDyOWOCciUfsMz2QQT7O0+OjsVZjwshNNDiP0g2aKNheVJpiO4K3Y2bqyph0l4GhQ42F2CYm6X8Yy2JMxVQVkXq3s968L3/56bkhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pCXj/SdjuSzLWvUmcM0Ei+vbXfGoMFXTbPyiT6AX8Bc=; b=docaK976nPIgK6n3TLkSeqvAPFnjioF5gooGLJq01Fwbl6mszBN65y7MNxxYgTpnuixX+we3J2pnRdMadakO3UYcEGoBKDLvUYrBWUB8UdNdKPyxzrHo8/pkph8rK3tUlOQo+lKnY7Au5v+mmmU4DV4z4tD/taiNaS5s2v/VuVA= Received: from BYAPR18MB2518.namprd18.prod.outlook.com (2603:10b6:a03:13b::18) by BYAPR18MB2439.namprd18.prod.outlook.com (2603:10b6:a03:138::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19; Fri, 1 May 2020 11:14:29 +0000 Received: from BYAPR18MB2518.namprd18.prod.outlook.com ([fe80::fca4:5e00:46d9:a289]) by BYAPR18MB2518.namprd18.prod.outlook.com ([fe80::fca4:5e00:46d9:a289%3]) with mapi id 15.20.2937.028; Fri, 1 May 2020 11:14:29 +0000 From: Pavan Nikhilesh Bhagavatula To: "Lukas Bartosik [C]" , Jerin Jacob Kollanukkaran CC: Anoob Joseph , Narayana Prasad Raju Athreya , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] event/octeontx2: fix queue removal from Rx adapter Thread-Index: AQHWFAZoexzqNFjS9U24dWenoKRAXqiTKziw Date: Fri, 1 May 2020 11:14:29 +0000 Message-ID: References: <1587043415-10955-1-git-send-email-lbartosik@marvell.com> <1587052060-22042-1-git-send-email-lbartosik@marvell.com> In-Reply-To: <1587052060-22042-1-git-send-email-lbartosik@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [223.226.86.58] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d70c24a3-93fc-482b-d8b4-08d7edc0d133 x-ms-traffictypediagnostic: BYAPR18MB2439: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2276; x-forefront-prvs: 0390DB4BDA x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gIGu1AXGJsp+EUNJCYpJktwywYCEVG7SEelDZ0GhjNg5EUZ3I97hxPgpusjcUdZ1/kCc/mCYFiwXHc/mF9y4S58JBk4qV9r2X++uhsBkqinlH35OGeq/IWE8XLl1Jcje31DWQ6XiiWpCmgTiaGn1cVDtkQWusSPAca/JLijhwFaaw0pMNptII1L1gWL0vCIXfmjdVd6XtQNBYGsiUNusDrm0AuEW1K/7F5BC+fIFSzXy3gA16v7CgpAeoSTsposQPDSK7B3i0wogzonamywg89b+MVOmlQO3irCnD5+0QE44TbeYOarEBjbonLDP4nX9gdgO6sfStaKb6jlU703ClJA7FnMUtwUUdFu1i00U8wTL2dM7b1BM8ruMnlR9UeIMSKDYrhKTuXWEsYS2WGRRbKldHmO3CoetYSVOGjR/LejRQXhPkCKnW1+pPA/GRjNR x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2518.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(396003)(366004)(136003)(346002)(376002)(33656002)(86362001)(5660300002)(8936002)(450100002)(55016002)(9686003)(54906003)(110136005)(478600001)(4326008)(26005)(55236004)(186003)(7696005)(6506007)(2906002)(71200400001)(66476007)(66556008)(64756008)(66946007)(66446008)(6636002)(76116006)(316002)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: g+lvy+CsyYG5x3DWbruof/nTnDH1fj1MMmUTvNb5U7DZLKsIUP5Rsd05wLJIGeMApqDj4V8YA5uarq0UJbdmqHEv3NA3iXZCWg3A7nOZWFntwZK8IHyyvDfg1IkhgjpweI2Wui9X+XfV3iVaXEtkdSHi9mKKmvAHeyrWn1ew1f1RKET2MzN3tKyTWpf9E4MqPQR0R01x7grE8HPDnIqBdUHJseLJ56i1TLlf2xrpzAx9ID4QAN35CYmL3QC2FO7b47RiH2nl8FApJ88ILE9b6OaZPoHLBNLrDPXfKGYqo7GdvUORd5ca0ckFgYabbaFX9wOYCW/YR9UToBi6MEksUMnG8RpUmfQy1hRHbWk0Gj5BB4b8kTdcaNBV4++YqZ5YstvP7JX3zH5OGteEoFZuq31BKuoWzkK1ZJ44KvDJyNWyouqOLuoLasCq/nKFGIDJewrGohADnKV0QmByv4DcMGwHsO5cVP6d6aCtCJN4b3xdx2hHnf8IHSR6uCpNkjuvx90mLCV64uzsz0ceLa+2FC4KLYfWhUNl0Fiz8D+WcqUakvQVEGuQ+JuFGg5xToqk6RkV0F+7P+7atlyme5BFJ63Rk3U94YVsQiysDoIgiryf0pL7M+tQvcPQHJ/l3rd/MuiHi9vQT4dLYQBvQlSQ2impHs6/9NRDjQlZCP6NTPd9bthtHpOa2AX5ySP315ZEi8F27g8F++QfAT52R4FUkvhxi2jWYH+SBcUzmgGVP6FSmzPytIFegLcYVO7iKDJt/HrQfX4YaVWxLA3m/zmUrwNlGk39iS5yvOqqhYzASpo= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d70c24a3-93fc-482b-d8b4-08d7edc0d133 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2020 11:14:29.4215 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cg0p8yNqsXEHPiOR6M+F2p+15IdBf8OxNB+5k2KcdV36tLfBo3FfpS1FSJLNMUyOjvmRRo0wwiEcHAgxgPt+AnDSYaJ1uppCqp10lgWmfTE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2439 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-05-01_04:2020-04-30, 2020-05-01 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2] event/octeontx2: fix queue removal from Rx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >When eth port queue is removed from Rx adapter using >rte_event_eth_rx_adapter_queue_del() it incorrectly >initializes CQ context instead of modifying it. This >might lead to a crash when CQ context is modified >as a part of rte_eth_dev_stop() sequence as CQ will >hold invalid entries. This is responsibility of an >application to call rte_event_eth_rx_adapter_queue_del() >to remove eth port queue from Rx adapter in tear down >sequence. > >Fixes: 37720fc1fba8 ("event/octeontx2: add Rx adapter") >Cc: stable@dpdk.org > >Signed-off-by: Lukasz Bartosik Acked-by: Pavan Nikhilesh >--- > drivers/event/octeontx2/otx2_evdev_adptr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/event/octeontx2/otx2_evdev_adptr.c >b/drivers/event/octeontx2/otx2_evdev_adptr.c >index 233cba2..8bdcfa3 100644 >--- a/drivers/event/octeontx2/otx2_evdev_adptr.c >+++ b/drivers/event/octeontx2/otx2_evdev_adptr.c >@@ -133,7 +133,7 @@ sso_rxq_disable(struct otx2_eth_dev *dev, >uint16_t qid) > aq =3D otx2_mbox_alloc_msg_nix_aq_enq(mbox); > aq->qidx =3D qid; > aq->ctype =3D NIX_AQ_CTYPE_CQ; >- aq->op =3D NIX_AQ_INSTOP_INIT; >+ aq->op =3D NIX_AQ_INSTOP_WRITE; > > aq->cq.ena =3D 1; > aq->cq.caching =3D 1; >@@ -144,7 +144,7 @@ sso_rxq_disable(struct otx2_eth_dev *dev, >uint16_t qid) > > rc =3D otx2_mbox_process(mbox); > if (rc < 0) { >- otx2_err("Failed to init cq context"); >+ otx2_err("Failed to enable cq context"); > goto fail; > } > >-- >2.7.4