From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6AA3A2E1B for ; Wed, 4 Sep 2019 19:52:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE2941E935; Wed, 4 Sep 2019 19:52:19 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id B45141E8F4; Wed, 4 Sep 2019 19:52:17 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x84HoN8f005518; Wed, 4 Sep 2019 10:52:16 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=ZaV+ckyTeHSkJ9z+0wvPXfoc14GcUs3dbxj2o4ZJvRg=; b=DFe7Je5aLfT7s/hdZUebPIDxl7ewaWfq+nToFshV9/0bGVGuzrkn/+NSROViLKktftj1 KgkUsLG2FLGQnklI25HPPZTQencAwCvL8h/xghuIBRLloxntzd9H3U0O90UFfKp341ue wUQKRnDTxDWn0eyC2NWSVsRn2+JQUytjO0Y+ZtcXZXEWMMd0LIqER0zZvV2ma8ezqx8g O5snQGORZljvN0m8MY6QuSYydU956pMF7BYZJNZB2QrphSFlEr91XMw5MYPbmaYboJ+j n0Fqe3bMvH5OKiM4VRcRJtdJvSLIrHl3eHp9FrEvWasUgrTecNIPEEY/jwVe8Od89mV/ xw== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2uqp8pfuh9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 04 Sep 2019 10:52:16 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 4 Sep 2019 10:52:14 -0700 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.54) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 4 Sep 2019 10:52:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GEWtZxZ3fTJtuPeCcMPNxWfBb0eBFMHFrO2aGuUOFG52yZGfqHk+5emF0fQY7AFieeVzb2kRERHJC9wZ5efCK49kiGEO7o7vaUbHub0VjiTKKfnHH6YA905nWJncisxKhGIbrq4u+xIqWMRZQ91guW5OIbFjdEaxgGbiSISPlHYIl3AufCP5flUz+8zFEgvrMqu0gd8tHl44GMl9RqoDTGHMuWA+H65WZbJOuy2nxB/J8vYYR2kxoMD30kS8x9KERoipflpUX7F6ipEXgo/pvEhGQ0h1esz8YAUySw6jHDyhSdse333ytohrTgKMk09/mlcI1kcIXglvUe9j/JK+WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZaV+ckyTeHSkJ9z+0wvPXfoc14GcUs3dbxj2o4ZJvRg=; b=GA3HTVAl78Y66w6h7liZPCOAct2f9RkYZ3RsQM2B85g/VEGYXbvYEqH373Ruoi2xuCSbsfopipu2PMw6ozVb5iP0aKXenPGIXbPD2NsA2Jgi3Q9Yckb98IiBKJl7qe0/mpyBdGlm5/EwkC16eZQ/qsqlGdpxV2qqBh46xfGtryLLI1TYDBfbpa4ax+3mXTjJ0gAcjHi4nGQN4xicwgqnIBt+oaA360L6y6LG8EubPxi9PIQ0rbB/KrR0Ub0naOn5MdCJGmreNh2oM9aQNck1ZzTmFzPrnz/EMMJxCyl0QLXMCyzrHWQrEs6ceTO+JYE+dbHEUdKHau5H3XIdjGdp+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZaV+ckyTeHSkJ9z+0wvPXfoc14GcUs3dbxj2o4ZJvRg=; b=dclqqsn48TJH9ot4/mTe0+O4oMJKZ1aiyfQiFRuLP3XcuXJl6S92mFiSNsi4Fnau+HinsaTdpn199vstmzk1tU9SyWzhaaCaYdZbK1vs1Z9S6F7AASEePBgyYFo7p3CSN70e+0gqHftJ2HHs0m2O9dHeMVmHxxhujavGQBYfBJA= Received: from BYAPR18MB2696.namprd18.prod.outlook.com (20.178.207.225) by BYAPR18MB2518.namprd18.prod.outlook.com (20.179.93.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.22; Wed, 4 Sep 2019 17:52:12 +0000 Received: from BYAPR18MB2696.namprd18.prod.outlook.com ([fe80::3c4e:37bf:66b4:e0f9]) by BYAPR18MB2696.namprd18.prod.outlook.com ([fe80::3c4e:37bf:66b4:e0f9%3]) with mapi id 15.20.2241.014; Wed, 4 Sep 2019 17:52:12 +0000 From: Shahed Shaikh To: Jerin Jacob Kollanukkaran , "dev@dpdk.org" CC: Rasesh Mody , "ferruh.yigit@intel.com" , GR-Everest-DPDK-Dev , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when using odd number of queues on 100Gb mode Thread-Index: AQHVYxT5k7mj4FNqKUWKzhPkrPPfNacbg7qAgABHExA= Date: Wed, 4 Sep 2019 17:52:11 +0000 Message-ID: References: <20190904113046.2213-1-shshaikh@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [123.201.100.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0521be99-087d-45ca-b3e2-08d731609d4b x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2518; x-ms-traffictypediagnostic: BYAPR18MB2518: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0150F3F97D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(366004)(376002)(39850400004)(396003)(13464003)(189003)(199004)(66066001)(99286004)(110136005)(54906003)(76116006)(3846002)(8936002)(81156014)(6436002)(316002)(229853002)(476003)(11346002)(5660300002)(486006)(52536014)(81166006)(66476007)(25786009)(66446008)(64756008)(66556008)(66946007)(446003)(4326008)(478600001)(14454004)(6246003)(76176011)(7696005)(6506007)(74316002)(55016002)(7736002)(305945005)(53546011)(2501003)(33656002)(86362001)(9686003)(14444005)(71190400001)(26005)(53936002)(102836004)(6116002)(2906002)(256004)(71200400001)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2518; H:BYAPR18MB2696.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: xJjVS5iAQxOumLUKKYGXcSTIwqisRQ8WGoPfE+gtaDJjfoBjBQv1GgMVMXTjKcJKNACLgxNSnUch2PjrihqSQL87uxXg80NOekVOXNwBWM0sLZmBmrkojfl5MDI2Cnu7PqGWBhTSzyJWQsrsYmMCnNIBRdRi8R4N62lMJmxmWAtC7wUYNFzEUTWDEt6fLYxguuOScAe7Lp+6zcTG+ZM4Z9+Q3px56S5jpuS7X8TQ5piE1PSBg2ocF6eUukE3haEnDifXMKWgzexKztiAl8bao/hyWKaIGHTwOQo+spMeSxqFSr691gZAwNmbFTro3TmPF6zYqHKn7+KCA/i29P8Gp2W+IDLRRtc/PIpuCc982pzpae9humtXlrs0IV77N4CPAPJhk+hsFdDTiwWc05Alte2s20Vtr2YLWHYyitUlqn4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0521be99-087d-45ca-b3e2-08d731609d4b X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2019 17:52:12.0510 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1k3I0KCl4FsnDHmN4p2mTXY9cMglq+FHqNfTu6injjCeW9E+DTn0hJF9ah8AZ3O6lDrpxYFxKbYTPQ8mVFBg5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2518 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-04_05:2019-09-04,2019-09-04 signatures=0 Subject: Re: [dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when using odd number of queues on 100Gb mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Jerin Jacob Kollanukkaran > Sent: Wednesday, September 4, 2019 7:01 PM > To: Shahed Shaikh ; dev@dpdk.org > Cc: Rasesh Mody ; ferruh.yigit@intel.com; GR-Everest- > DPDK-Dev ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when u= sing > odd number of queues on 100Gb mode >=20 > > -----Original Message----- > > From: dev On Behalf Of Shahed Shaikh > > Sent: Wednesday, September 4, 2019 5:01 PM > > To: dev@dpdk.org > > Cc: Rasesh Mody ; ferruh.yigit@intel.com; GR- > > Everest-DPDK-Dev ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when > > using odd number of queues on 100Gb mode > > > > As per HW design of 100Gb mode, device internally uses 2 engines > > (eng0 and eng1), and both engines need to be configured symmetrically. > > Based on this requirement, driver design chose an approach to allow > > user to allocate only even number of queues and split those queues on > > both engines equally. > > > > This approach puts a limitation on number of queues to be allocated - i= .e. > > user can't configure odd number of queues on 100Gb mode. > > OVS configures DPDK port with 1 rxq and 1 txq, which causes > > initialization of qede port to fail. > > > > This patch changes the implementation of queue allocation method for > > 100Gb devices by removing above mentioned limitation and allowing user > > to configure odd number of queues. > > > > Key changes in this patch - > > - Allocate requested queue count on both engines, so that > > actual hardware queue count will be double of what user requested. > > - Create a pair of queues from both engines and provide it to > > rte_ethdev queue structure. So ethdev will see only one queue for > > underlying queue pair created for hw engine pair. > > - Rx and Tx methods from ethdev will provide that queue pair > > object and PMD will internally split Rx and Tx packet processing acr= oss > > both engines in separately installed Rx and Tx handlers. > > - Consolidate statistics of both HW queues while reporting to applicat= ion. > > - Report engine wise queue statistics in xstats flow. > > e.g. - rx_q._xxxxxxx >=20 >=20 > Multiple logical changes in one patch. Please split the patch to more log= ical ones > for easy review. Hi Jerin, Sure, let me split this patch into logical patches. >=20 >=20 > > > > Fixes: 2af14ca79c0a ("net/qede: support 100G") > > Cc: stable@dpdk.org > > > > Signed-off-by: Shahed Shaikh