From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4D2ADA046B for ; Wed, 26 Jun 2019 00:50:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 16343CFA6; Wed, 26 Jun 2019 00:50:39 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 46C3B4C8B; Wed, 26 Jun 2019 00:50:37 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5PMlKgL007158; Tue, 25 Jun 2019 15:50:36 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=5j7IjBmxJBMc6KWxlwPwkk8YBjt/nO3I8SKdWzZ4qIM=; b=QUKBQ1fE/V0C/gPNPLTRN6JjRTcEpgN1BXrwymZZvtvSJTwFzd2egRQwemCJ+yQq9qVb FpTBVJxvtNIIEdqknAlMnNXeG6YcizYR2malcZaqx1ChPfzWJEsI+rWnpgPv2rCYa3or iKrlR2weMkJJ5aEHUAz3r4KASye+uoTa3A2Lb2AolbUYMM62BhuRU4OtA3XwygdsHZNu 1MDdMuYM0uSjFaAa+Bm0iHFb3lcP5X03e9v5O2hypQUddKkhjJN/goD69k/m729di4Pi HhoNmaDqY/Rfj1BXUr7vAGlQkPqN4csF2CfSfUhhZzYzKIiwBu6yfBa9kjMjmhe4L8mX nQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2tbrte10qb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 25 Jun 2019 15:50:36 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 25 Jun 2019 15:50:35 -0700 Received: from NAM05-BY2-obe.outbound.protection.outlook.com (104.47.50.55) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 25 Jun 2019 15:50:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=testarcselector01; d=microsoft.com; cv=none; b=Fcs8qDlJxuOPkT+AeXZB/y6Q00SP31TEuLiBcJlrCAJ5icMD2vb39kMwa8PdHCXf+tnfLfApg8ItpZQYO1pkby1g/KSS1lB6fxVN7MPcSeYZmkl2YCwU9dhii2zIPT9UxraIs0u5s/kZlw9x5uRRVCOSb8sNg22vNpGJpQz7ygA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=testarcselector01; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5j7IjBmxJBMc6KWxlwPwkk8YBjt/nO3I8SKdWzZ4qIM=; b=UNARk+9ovhMtVoaJK574ghE1qDf5de20JH7lOXYjoWvHUdcubRLfsqclC9KOKHalLBeQAUdrh3Qd1AVCy1LOfLyxlzxW6sgiLST0hxEfPkKs+E2SjShClOve8J6UlAfCU3jqTJ6ifGe1xUK1F1S4GUvFUzy1q7V3mzKHVTLF350= ARC-Authentication-Results: i=1; test.office365.com 1;spf=none;dmarc=none;dkim=none;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5j7IjBmxJBMc6KWxlwPwkk8YBjt/nO3I8SKdWzZ4qIM=; b=Bz5ksZGLEc042RLxmNHChZ9ZdO2E1OgrTKM6WNVkCCND3A5TVagP6bgSlVigsOOpmcDaL7bPeFFKwFXBBcUsv3pCXFhq6GlO7YX34KbDizcSQ5RCDz/Q9NxoVaLnUwPWuhbrteos/HXVwZtR9DqpDmCTY4AJ0Ngcs96A9sRpMsM= Received: from BYAPR18MB2838.namprd18.prod.outlook.com (20.179.58.18) by BYAPR18MB2582.namprd18.prod.outlook.com (20.179.93.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.16; Tue, 25 Jun 2019 22:50:30 +0000 Received: from BYAPR18MB2838.namprd18.prod.outlook.com ([fe80::d423:d286:1e1:16f5]) by BYAPR18MB2838.namprd18.prod.outlook.com ([fe80::d423:d286:1e1:16f5%6]) with mapi id 15.20.2008.007; Tue, 25 Jun 2019 22:50:30 +0000 From: Rasesh Mody To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , Shahed Shaikh Thread-Topic: [EXT] [PATCH] net/qede: remove interrupt reconfigure in handler Thread-Index: AQHVK1tn7hSnqaC720S9w8Nfw1MJg6as9v6A Date: Tue, 25 Jun 2019 22:50:29 +0000 Message-ID: References: <1561469937-16077-1-git-send-email-david.marchand@redhat.com> In-Reply-To: <1561469937-16077-1-git-send-email-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [199.233.58.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 05cb6099-3277-4df3-dc3a-08d6f9bf860d x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2582; x-ms-traffictypediagnostic: BYAPR18MB2582: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1107; x-forefront-prvs: 0079056367 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(346002)(376002)(39860400002)(136003)(189003)(199004)(86362001)(54906003)(8676002)(107886003)(25786009)(14454004)(99286004)(71200400001)(966005)(6436002)(7696005)(71190400001)(9686003)(6116002)(3846002)(53936002)(6506007)(4326008)(6306002)(478600001)(229853002)(102836004)(26005)(11346002)(446003)(256004)(305945005)(66066001)(2501003)(74316002)(33656002)(55016002)(66946007)(486006)(76176011)(6246003)(73956011)(186003)(7736002)(8936002)(81166006)(76116006)(316002)(81156014)(2906002)(5660300002)(64756008)(66476007)(66556008)(66446008)(110136005)(476003)(68736007)(52536014); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2582; H:BYAPR18MB2838.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ZzUxyvJxXwDOyHuUByD9EKvAbRT4izhgkRcGQKIyUBjGiNLDjJCAUzl8Bo64lq0xFQIhSrU4G+Oss66EtAUl53aWidcw+uktYQwbbpEusdkYlb0CuZidA6MbyX2U+gKbjcabkLT0iX945RjuAKc0alEdx9nRqoISp3kmcP+pJvh7PAuY04CuVyhbpwAF9WC1zkfjsubJhSBetx5OB1kyZNsr4zPn5jLa3HkJc8Q8UqRnJAkOQ6en9MY/bEDgTYfViglpOkAr9GhTf1aT4YqNoCDFz0T7mxo/ca8ojf4qyrtAYngybr3JO2nzSP1eCCr3nJISU0cjo31kUrkyUX9o1e08LC8zy81IjhBm/rCLLVzISPDCjxSDAFcR8sKEFAswRPKQpOiDO7UfxhVhiMqYghUc2aWj72lSQlNeQkvCvhw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 05cb6099-3277-4df3-dc3a-08d6f9bf860d X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jun 2019 22:50:30.0130 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rmody@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2582 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-25_14:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH] net/qede: remove interrupt reconfigure in handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >From: David Marchand >Sent: Tuesday, June 25, 2019 6:39 AM > >---------------------------------------------------------------------- >rte_intr_enable/rte_intr_disable configure the interrupt context on the >kernel side (either uio or vfio). >In VFIO case, calling it from the interrupt handlers triggers an unneeded >interrupt handlers reconfiguration. >During this reconfiguration window, the device can trigger interrupts whic= h >are left unserviced. > >Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=3D1654824 >Fixes: 245aec289338 ("net/qede: fix legacy interrupt mode") >Fixes: 2ea6f76aff40 ("qede: add core driver") >Cc: stable@dpdk.org > >Signed-off-by: David Marchand >--- Change looks good, thanks. Acked-by: Rasesh Mody > drivers/net/qede/qede_ethdev.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > >diff --git a/drivers/net/qede/qede_ethdev.c >b/drivers/net/qede/qede_ethdev.c index 82363e6..807016a 100644 >--- a/drivers/net/qede/qede_ethdev.c >+++ b/drivers/net/qede/qede_ethdev.c >@@ -245,12 +245,8 @@ static void qede_interrupt_action(struct ecore_hwfn >*p_hwfn) > > /* Check if our device actually raised an interrupt */ > status =3D >ecore_int_igu_read_sisr_reg(ECORE_LEADING_HWFN(edev)); >- if (status & 0x1) { >+ if (status & 0x1) > qede_interrupt_action(ECORE_LEADING_HWFN(edev)); >- >- if (rte_intr_enable(eth_dev->intr_handle)) >- DP_ERR(edev, "rte_intr_enable failed\n"); >- } > } > > static void >@@ -261,8 +257,6 @@ static void qede_interrupt_action(struct ecore_hwfn >*p_hwfn) > struct ecore_dev *edev =3D &qdev->edev; > > qede_interrupt_action(ECORE_LEADING_HWFN(edev)); >- if (rte_intr_enable(eth_dev->intr_handle)) >- DP_ERR(edev, "rte_intr_enable failed\n"); > } > > static void >-- >1.8.3.1