Re: [dpdk-dev] [PATCH v2 8/9] net/qede/base: update the FW to 8.40.25.0

[Rasesh Mody <rmody@marvell.com>]

>From: Ferruh Yigit <ferruh.yigit@intel.com>
>Sent: Friday, October 11, 2019 9:14 AM
>
>On 10/6/2019 9:14 PM, Rasesh Mody wrote:
>> This patch updates the FW to 8.40.25.0 and corresponding base driver
>> changes. It also updates the PMD version to 2.11.0.1. The FW updates
>> consists of enhancements and fixes as described below.
>>
>>  - VF RX queue start ramrod can get stuck due to completion error.
>>    Return EQ completion with error, when fail to load VF data. Use VF
>>    FID in RX queue start ramrod
>>  - Fix big receive buffer initialization for 100G to address failure
>>    leading to BRB hardware assertion
>>  - GRE tunnel traffic doesn't run when non-L2 ethernet protocol is enabled,
>>    fix FW to not forward tunneled SYN packets to LL2.
>>  - Fix the FW assert that is caused during vport_update when
>>    tx-switching is enabled
>>  - Add initial FW support for VF Representors
>>  - Add ecore_get_hsi_def_val() API to get default HSI values
>>  - Move following from .c to .h files:
>>    TSTORM_QZONE_START and MSTORM_QZONE_START
>>    enum ilt_clients
>>    renamed struct ecore_dma_mem to phys_mem_desc and moved
>>  - Add ecore_cxt_set_cli() and ecore_cxt_set_blk() APIs to set client
>>    config and block details
>>  - Use SET_FIELD() macro where appropriate
>>  - Address spell check and code alignment issues
>>
>> Signed-off-by: Rasesh Mody <rmody@marvell.com>
>
><...>
>
>> -void ecore_calc_session_ctx_validation(void *p_ctx_mem, u16 ctx_size,
>> +void ecore_calc_session_ctx_validation(struct ecore_hwfn *p_hwfn,
>> +				       void *p_ctx_mem, u16 ctx_size,
>>  				       u8 ctx_type, u32 cid)
>>  {
>>  	u8 *x_val_ptr, *t_val_ptr, *u_val_ptr, *p_ctx;
>>
>> -	p_ctx = (u8 *)p_ctx_mem;
>> +	p_ctx = (u8 * const)p_ctx_mem;
>
>This is causing build error with icc [1], I will remove 'const' while merging.

Sure thanks.

>[1]
>error #191: type qualifier is meaningless on cast type
>
><...>
>
>> -void ecore_memset_session_ctx(void *p_ctx_mem, u32 ctx_size, u8
>> ctx_type)
>> +void ecore_memset_session_ctx(struct ecore_hwfn *p_hwfn, void
>*p_ctx_mem,
>> +			      u32 ctx_size, u8 ctx_type)
>>  {
>>  	u8 *x_val_ptr, *t_val_ptr, *u_val_ptr, *p_ctx;
>>  	u8 x_val, t_val, u_val;
>>
>> -	p_ctx = (u8 *)p_ctx_mem;
>> +	p_ctx = (u8 * const)p_ctx_mem;
>
>Ditto