From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AEA6CA0548; Fri, 23 Apr 2021 05:52:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AC4F41D41; Fri, 23 Apr 2021 05:52:45 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id A9F604014F for ; Fri, 23 Apr 2021 05:52:43 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13N3p12o005605; Thu, 22 Apr 2021 20:52:42 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by mx0a-0016f401.pphosted.com with ESMTP id 3831504bjn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Apr 2021 20:52:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UgB3KNParMiYtjTFiJUs+t6X273T8gMeyrnZyIuH3qwwvy8M4g+kY0RevHnseIk0sXB92+pTGxQHelSVOhNU+CO6tk1FFyCs6jqMZ9e6wZNnzGDa56w/mW6twb+TDFNpSsW9XZnwKtDuAKs/VYbP2lpDh7tj+WM0W8g75MMIYTuT6qpaEy4WNrHdDmU+vWPZarqnLWaVUgqs/4xi7vW6q+ONK752x8YrcnlLYH+uwqWHhpaoLVtsLf6pihyaEOHdbLU8CbrGnFrE/mF2HaVB/xYFjbFyW60p1p6ATC6lxsCbWYbGEkWfxzWbkxZhrhrxSZqD2WReS9ZsAe884IdKkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jBJLf/eEUGa5VBbcR5HUFnT0VfXipxH7t4TrOQmagK0=; b=CZV5TRPa58jBF2Nd+OXqlxHqgkma1VeO9s7PPaQhG4Ay/UIur9wP4SmRFa+SOizwXl11hMmprYikGKvcOk5QR1eEvzkU25uR67CCblHo5ZIri6lZvAyqrBvxIeifOxnZ3eTgRzc8CZpvY6Z6SYvPv1kIA2IDBxVL05fNobnfBtqTr9py67W6iC7eH7v1TPRWgPRQq+goOtg6FrdejbjMjiNXHGr0Wwo0NoXbGGinsmEC3piQpEh6mXQbEEeg3lH5slhhxaK6tBETOiFNzs1p/qc4k7MmopWm/nEDhsHIddC8yoYH+RgT05hvemtVr5XjcVekXs7VubkQp5FU9THCdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jBJLf/eEUGa5VBbcR5HUFnT0VfXipxH7t4TrOQmagK0=; b=aafUFPyn+AzMN//g9X6vvhyNHz8HXl1glv3HfXKk5OMSz//fycCHss+XJD1MpsSlICrzMJ+1jrbMA5eT/wjcP3adtKJ0rMwkuyNVTESvreYm3yeiBspIBHRmGUWMKZvVhh/GJmvc6zDaJJ5gYfDXENN/Bdc3P2RBJJMip3RJ0d0= Received: from BYAPR18MB2965.namprd18.prod.outlook.com (2603:10b6:a03:10c::30) by BYAPR18MB3061.namprd18.prod.outlook.com (2603:10b6:a03:10e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Fri, 23 Apr 2021 03:52:41 +0000 Received: from BYAPR18MB2965.namprd18.prod.outlook.com ([fe80::b9a8:fa93:c772:f785]) by BYAPR18MB2965.namprd18.prod.outlook.com ([fe80::b9a8:fa93:c772:f785%6]) with mapi id 15.20.4065.020; Fri, 23 Apr 2021 03:52:41 +0000 From: Kiran Kumar Kokkilagadda To: "Min Hu (Connor)" , "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , Jerin Jacob Kollanukkaran Thread-Topic: [EXT] [PATCH 2/2] graph: fix dereferencing null pointer Thread-Index: AQHXN230ZAdZi7j/UUS6SJMFQ4R2x6rBeUdQ Date: Fri, 23 Apr 2021 03:52:41 +0000 Message-ID: References: <1619092340-4047-1-git-send-email-humin29@huawei.com> <1619092340-4047-3-git-send-email-humin29@huawei.com> In-Reply-To: <1619092340-4047-3-git-send-email-humin29@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [202.65.154.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 998d2578-641e-48cd-abc9-08d9060b3e6a x-ms-traffictypediagnostic: BYAPR18MB3061: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:773; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cSwtvZv71cR4JUgz2lrz3yAg0vdEfeM0gZI0Tao652kfCSZ9rpbTzGIPmQ4fE3xTCRIc8mwN+SX53AGj8d7Qunk73QYA79Tb2+YyFgknT5XuOksBCp05dLUDKkVcQBZBWOYcY3YSl6lY7buaE4cPUMcAqboR1wL2l9ofhcg++wqjsmZSpowPWOmfuhD4wji1DZDP0EQTtXbhjBIwdFoPdpZO1d3lmoCG0Jt93NUbAKh3oN9EYuP6+8hPIcti/i6sYwnOi2+qut9Sp6dAeOsXVNo/kdLPjoEOSe01sKXb/8kRe1j/CucBZiCtIatk0JegRRlpyej1aVyObuIK3h9gJxZYCFnePAngNR3y9DcjAvp/wMkYIdh3xS+jPjEfb1BIP8OUHGaWxkZvdMGfBRIJxyoKL+uXl2cTalza3i+BnEZ4tWztcS+B7HVrZAAa1bGYYqRS8GMp4dX8VixKjoET40y9oGJuvaqly1B6govSjhTlAcKhAHVjkWo9AruATogbSBHFwVaBwu/01lPw3ozFoYhEhXUuQFQRsCJoncT2yv9oY1PBSyRiAGJaIuF85jUCApJLMZNdH7wg4M28gQulAGds+C2M6PTIOzh8alSF9nw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2965.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(136003)(376002)(366004)(39860400002)(66946007)(66556008)(186003)(8676002)(107886003)(122000001)(8936002)(2906002)(4326008)(478600001)(110136005)(6506007)(38100700002)(53546011)(54906003)(71200400001)(83380400001)(7696005)(66476007)(52536014)(5660300002)(26005)(86362001)(33656002)(316002)(55016002)(76116006)(9686003)(66446008)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?8DB2Vso1rC9hNpDG9PVUvsCmLUSvRMVSYV3OGCU3jmAqopP9ptd8rg2pWBIK?= =?us-ascii?Q?dLD92LVYzGmXlJSYfJsLJqIKVMueBmq+0Nl1Y7Zq+Fqqf5f/VMRkHB6BHwIm?= =?us-ascii?Q?QojmwJFYCXitx4vBjnyLQ87caAXHiU+QFyZ3FYWjHshYtilGxhEo/FdLJhw1?= =?us-ascii?Q?O8u9CAqOcESaLEtvra+ZloZ0VaY2Phr8IWKiKD4zeyG6jWlbV/NaytO7Wrm4?= =?us-ascii?Q?S7JSknRWea1nu0yKTq3VdkI0tWsUQztoDn0iuK7CsmSHGObKQ9H8OD1T78S8?= =?us-ascii?Q?DFtEGMWj+UetMRKgd2ZZPaezQlaVuRtGBx24GK+1WGCnn+4RoLo0dKN1xrnx?= =?us-ascii?Q?YtZhZcwgr5JIwz0oAXsFF9A/U5VmGZkpIDcm4ZnZ1lfHNeP7TcJMsQS+mTmu?= =?us-ascii?Q?9z3wktsnAuYpleZCxwAx4Mdw6NmNROKgVHxElIpP1/xXH/RiHkrKh82+rrs5?= =?us-ascii?Q?BN7iopxmn+1F3WsOjOdKcT1sqztSyacZsk0ZQDrPm/m28XjicfWQHIkh8fNH?= =?us-ascii?Q?pz2QQVYI1a5OJAvA8JbEHI4qXs2zk/f53Vc+EfTojpt9RqW5MQM5DHdvAeC6?= =?us-ascii?Q?zIorYcF2YgY9X6Gxp0gPu2SviIs6gtud44WsspWDjX3sNbdKasPpiuhY4xMF?= =?us-ascii?Q?5JlF/jRlM0PkyUE0NN2U7GTyTLUSly7NU+FQ26C+pNQLOVZ8plWyZpsP6OwC?= =?us-ascii?Q?MUN2md+jK675xdk6ejluTrCpYOBZwkojBnylYpGZLtAMDqimhEuwXHArhcC/?= =?us-ascii?Q?Wao/kqAeR3a71EGD/gV6+hJ7Id0K7PteaM8qgB5X9fyc+8H9/UNm9njHPbfX?= =?us-ascii?Q?tkGhriZrFlIiGyAJ0SuN6o7Zm9mzJogz6IGPEwyLZ2V5aVLdl8j9AMpwnPo4?= =?us-ascii?Q?HD2XL4UBW2toNH1ObVxFX/WYRflmP8ao2X5HNk/0i1WtvUZmOSU0YQ2VfOPJ?= =?us-ascii?Q?neEXNhQHYtXGkfm1+2r6iZNxL0UqUjMnglkJcvUFI2EgI2LVMA+FM2S+tyxv?= =?us-ascii?Q?1lJ8RILteojR6lt67p54D/b5dhcJrGzZZwSNMlHjn+UnJU9sR+XgG8QYrad4?= =?us-ascii?Q?P+Ih1zSHH/Pb1p+EGZPowU6IUUrWxI9F3GnZsKZwvDFwQ0205upmVFZ6/7tG?= =?us-ascii?Q?HGmh+pGSCt3oofQW7FURm82DmbUhjF19zdqvU4IV/APMcX8ay9HE9e+vA5Mg?= =?us-ascii?Q?FKSJx7hT3B4fFtnabPonuKIkdmB1bgxGX0my90uhBOcuBxQhqTO8jQjaLQXZ?= =?us-ascii?Q?RgRMDqgWWCr/SbB2kj9RCTe7pK1WRoJ0aGyWdIiWZ6AfKLHBOrXo3Y6GsPVz?= =?us-ascii?Q?oUucHp5TX0c4ZbntuNMmpAHa?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR18MB2965.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 998d2578-641e-48cd-abc9-08d9060b3e6a X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2021 03:52:41.0721 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qcfKyz0p7LBBc1PzLt+P8UL2/q66YL108qUJGnagok13VMTI3nwUfOD+7bkMHheJY5pCvU++ayk/qBglfiHehQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB3061 X-Proofpoint-ORIG-GUID: q2CRehGDjQ6HVex-W06gY_BqikOx5EMP X-Proofpoint-GUID: q2CRehGDjQ6HVex-W06gY_BqikOx5EMP X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-22_15:2021-04-22, 2021-04-22 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH 2/2] graph: fix dereferencing null pointer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Min Hu (Connor) > Sent: Thursday, April 22, 2021 5:22 PM > To: dev@dpdk.org > Cc: ferruh.yigit@intel.com; Jerin Jacob Kollanukkaran ; > Kiran Kumar Kokkilagadda > Subject: [EXT] [PATCH 2/2] graph: fix dereferencing null pointer >=20 > External Email >=20 > ---------------------------------------------------------------------- > From: HongBo Zheng >=20 > In function 'stats_mem_init', pointer 'stats' should be confirmed not nul= l before > memset it. >=20 > Fixes: af1ae8b6a32c ("graph: implement stats") > Cc: stable@dpdk.org >=20 > Signed-off-by: HongBo Zheng > Signed-off-by: Min Hu (Connor) > --- > lib/librte_graph/graph_stats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_graph/graph_stats.c b/lib/librte_graph/graph_stat= s.c index > f698bb3..bdc8652 100644 > --- a/lib/librte_graph/graph_stats.c > +++ b/lib/librte_graph/graph_stats.c > @@ -119,8 +119,8 @@ stats_mem_init(struct cluster *cluster, > cluster_node_size =3D RTE_ALIGN(cluster_node_size, > RTE_CACHE_LINE_SIZE); >=20 > stats =3D realloc(NULL, sz); > - memset(stats, 0, sz); > if (stats) { > + memset(stats, 0, sz); > stats->fn =3D fn; > stats->cluster_node_size =3D cluster_node_size; > stats->max_nodes =3D 0; > -- > 2.7.4 Reviewed-by: Kiran Kumar K