From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FC4FA0548; Fri, 23 Apr 2021 05:52:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83D9F41220; Fri, 23 Apr 2021 05:52:13 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id C18DB4014F for ; Fri, 23 Apr 2021 05:52:11 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13N3psg6022409; Thu, 22 Apr 2021 20:52:11 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2175.outbound.protection.outlook.com [104.47.57.175]) by mx0b-0016f401.pphosted.com with ESMTP id 383ds8hn1q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Apr 2021 20:52:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eeq+Mex4LYDJ78sM5hjVwtn6bfof3YNuW3SFuZKxkalzGz3fcxlKwBWrDk551+rkT8q+p981NhYrfZn1L2dDEuj1mMPARC1CrK5hB3CzQbhFlvXX9gwSY24Qu3LTyj1cCiJNGCrdhUj7HToa3/Q16FjIoIbyP/vpeVABIVfz7Lb+P/91qgbzVsh+E26DKTAHo/6E62QY66lqd4laSIyqxHgRghvAyxgaYCzcrxp43zzo3I7E2tqhWn2oskHxd4FPtca7RVGVZoJsCxnjMfmVEyhkOqXYlONYE8IF1GJmOMJQUQUZKgPDNJ98LCSRM8csSFby8Gp7Z1R7Lfsn0usjtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1tltCKCu+bon2twon20hwS/P901vSuhgx4IfY9y3LFQ=; b=J6JWCcJwGYBmzuAnRTThhzIEccxxWfARDxDs2biLEZPfTb8pGHHadXEk+J5gszLuShrjpenuI67W+gg+rdOdUk1p1bZQre0kYK079rN3Je3DWX+mIBgemwpUsO8AXsWElspH1+XzWq9LYHaluHMx1HqGH5+gPZ1dGs0nMmKtt+aSMHWJY3pBYP0r+v+20LxvKnRadRw7Udqoz8QMMoexmzDI9cTA+TOZFTljOA10vpZU2zFgjxyoXDI/9tp9E/AqV5OvIHLRp93iM+j9JyRbMbV7XBuxBFH/txDXrmVSeIh0F7gAFz8PveNwzUIjJWMmXWXy+zY5eBDy2eRbZovHaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1tltCKCu+bon2twon20hwS/P901vSuhgx4IfY9y3LFQ=; b=qZBocwlTXscZHtPTgKk+q0yzVZ3tQXvBck3zTojd31xj26AGIuStVp/ejg2zCAfZE6JVjxYQbpepsIw4YDfjv6xsDseV3Kimy5Dfi5KU4IiU3SvzldeCQKcvuIF9J8kgnPx0favTYb7q0q8qFDWPeqDinVICmSXOoLFeJMUV7fA= Received: from BYAPR18MB2965.namprd18.prod.outlook.com (2603:10b6:a03:10c::30) by BYAPR18MB3061.namprd18.prod.outlook.com (2603:10b6:a03:10e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Fri, 23 Apr 2021 03:52:08 +0000 Received: from BYAPR18MB2965.namprd18.prod.outlook.com ([fe80::b9a8:fa93:c772:f785]) by BYAPR18MB2965.namprd18.prod.outlook.com ([fe80::b9a8:fa93:c772:f785%6]) with mapi id 15.20.4065.020; Fri, 23 Apr 2021 03:52:08 +0000 From: Kiran Kumar Kokkilagadda To: "Min Hu (Connor)" , "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , Jerin Jacob Kollanukkaran Thread-Topic: [EXT] [PATCH 1/2] graph: fix memory leak Thread-Index: AQHXN230L+4k+QUOZk6id+Z4tK+hj6rBeIjA Date: Fri, 23 Apr 2021 03:52:08 +0000 Message-ID: References: <1619092340-4047-1-git-send-email-humin29@huawei.com> <1619092340-4047-2-git-send-email-humin29@huawei.com> In-Reply-To: <1619092340-4047-2-git-send-email-humin29@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [202.65.154.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 404b0dd3-9f52-4858-cd88-08d9060b2b3b x-ms-traffictypediagnostic: BYAPR18MB3061: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EuYRrQ3eTNOrkIUKEAqq2ikShzmMtz05Cm0waAWAoJqG7nfMZSi/AV1lWGrrKl3IC695WA14DjRpoj+rNZS/TXYvMqpTU8N4I2snYzjU4xO3kzXffPW0FjeaGhgtDmg+bmPvDyr6Yefz7tzT5SFPf8XUnYd42bANdJ0bCDSCHwt4GN4t/KbTx4DcjjuCgs+Vao/5fZgOaRCw7YozDycrIiUnXkjFyQwIqupkaDw/Hw1qq98GGn08K3r6L3ox7kE/2w5fXMxP9jo9/1uI6HMH2KE9PDaWjv2btls0cBXf3aaB+kA43XNmAYbe+VA/+Ka7C3eTND+B2/bLVmnQ85iqF9CNJPikJRT+mxtyV4p4TcDvTgpGh7CoZgjsXjq4X5BvbeQF3dQS2ztBOzh8/DR7v+Y/GxTQO5SeSauXDGaN1kriddjeh+9hy8KP2WmKNUSrDtIByEH0IHydpKxoRdFTnblBZ7NwGj7vTzCpJacP4VJ184atihCfEsdZufk1PVHyLGsl27AYIfIt8eDBGHoy/pc6fxfjIooOT4i3lRs7wUoNjLkkui1iz+lLCnAbeSDfiebhoA3vMqjJHZLFLLwwf7zh7RfuTLER96v+wmrarqo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR18MB2965.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(136003)(376002)(366004)(39860400002)(66946007)(66556008)(186003)(8676002)(107886003)(122000001)(8936002)(2906002)(4326008)(478600001)(110136005)(6506007)(38100700002)(53546011)(54906003)(71200400001)(83380400001)(7696005)(66476007)(52536014)(5660300002)(26005)(86362001)(33656002)(316002)(55016002)(76116006)(9686003)(66446008)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Egf1j/RUxpu9a1mBjGjzBacY3tg3Q4QuEQkMeR1poGM8XTRDS7WpGzxAcxP3?= =?us-ascii?Q?Z1iHw/vYaszbwbtTXBIL7ZGzPkWPnNjsKuBVoo9xvTeJT4nr6ccxrZF7edS4?= =?us-ascii?Q?dJaTCkmwl+pM+KwTWGZ3wc3nCb3p3BrEo/xUCca7ppQ02THxa7rePTysfmTt?= =?us-ascii?Q?UoCvozD4v9Cs32RjG0sUSJPGatsbTfsOQQMC3W9HlPgM1ma7+tGIb2iLtmvR?= =?us-ascii?Q?vYDHl9GMWc6BDElwO9tGL+njJRtp/Zl4tZV4GxcU9Jou85eYVkYgxgHpNwj6?= =?us-ascii?Q?pTFnrXLmLdYFgFoQERs4FCJOQxJgeltAYpK2K4xwzldlBZ0OuqMGaldFEXlT?= =?us-ascii?Q?qtzH6N3/rO5JdgL91njGhCB6yXTLppMEs/C+NrfGBPgzrZildUgEZMAA3Zpb?= =?us-ascii?Q?yhz4aEi5pZqA4hAyy4EO6ldTMml1nE/2667RPU1f6FJ2V9zT9m/6FlA7mqjw?= =?us-ascii?Q?sGNBsIG3sjVavV+QdBj3Efxn2H/DQOA73eVKdAdZNzCS7m93c5vPEwQMo/pa?= =?us-ascii?Q?jMCI6zcs8PJZKJ7vev1uUhddZjzML6mISfk40DjhDK/ARKX8oAy9TIBLTlO8?= =?us-ascii?Q?fwxbqmo7uyrKPmDQ6zd0OESU8MaYT2JV1y9fDnROv0VyiYWRw52BPXwYpdUx?= =?us-ascii?Q?y+MTicQLjMX8r4u2fbdrJfr+rdNvza2GQ9Qb487cNa3jVYZr8WXBzR4S/GTg?= =?us-ascii?Q?YQmiE+cdW6ycAcOAkldZRE9ULf5iRCErQwto9GMs4IMLRkB8SEAAY5z/2wM3?= =?us-ascii?Q?2so1FKGrPpVcGp+z31K+7Aqiw8j58czp7iZVfPQcJyvGqsg8Sn5MMYIt4zrI?= =?us-ascii?Q?xZ/aWzE48wrETVhvmWw368NWAsqzCHTtMFEraCZLp2lohaHOenrxbUTShJ0y?= =?us-ascii?Q?+0ZcWlAnvp+Ql5+m5CBmUkweRffQj2XcTB9PPC2kxN2IdQyacIlvoHmiia/O?= =?us-ascii?Q?s4nVfzSN+0G2cIrrfOqK5QZUhrO1PvgFF5Jw3f+3VEAyGisQ/sLIDggV5+TK?= =?us-ascii?Q?z0zlQs0Qkdw8YhBvTEtNN5DNtfAm5kEEFNbN88gMM+n7FI3vIoPZiyjrghT9?= =?us-ascii?Q?wzncNJE8RyYTha8BKac5PsszCtR4XuIznVy5MCFuM1GgUtZOxbk0mG/wglPN?= =?us-ascii?Q?355VkzuZR+CPFCZdHqw/MZ3HQhyCzvRsklYrr26a8yDXDO4D4OzwNm/KIJRD?= =?us-ascii?Q?HUDphkQDVAbOy7fBrPcB4oyPdnpLspctgpX2gouEnhf62YLKtg9Vds3uPPak?= =?us-ascii?Q?NT7waTKgNNcE1lbdeARc5jTrbc5GrXGBto0pnrmTvE3toCcn6Cgfo7E3yL9H?= =?us-ascii?Q?u9t6pLObM2sYzvM3V2SNELwC?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR18MB2965.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 404b0dd3-9f52-4858-cd88-08d9060b2b3b X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2021 03:52:08.8792 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AuVlrI3I1GISIdkzU1RV3sy+b7vJOiB+GSGKIWpZzXNiRIyOfv8XF3FQtppim9A01kgXyM7s+HqPdYBb/K3vdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB3061 X-Proofpoint-GUID: _8fAGAujVSZF3xMQK_uGpBve-ND7LEoD X-Proofpoint-ORIG-GUID: _8fAGAujVSZF3xMQK_uGpBve-ND7LEoD X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-22_15:2021-04-22, 2021-04-22 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH 1/2] graph: fix memory leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Min Hu (Connor) > Sent: Thursday, April 22, 2021 5:22 PM > To: dev@dpdk.org > Cc: ferruh.yigit@intel.com; Jerin Jacob Kollanukkaran ; > Kiran Kumar Kokkilagadda > Subject: [EXT] [PATCH 1/2] graph: fix memory leak >=20 > External Email >=20 > ---------------------------------------------------------------------- > From: HongBo Zheng >=20 > Fix function 'stats_mem_populate' return without free dynamic memory > referenced by 'stats'. >=20 > Fixes: af1ae8b6a32c ("graph: implement stats") > Cc: stable@dpdk.org >=20 > Signed-off-by: HongBo Zheng > Signed-off-by: Min Hu (Connor) > --- > lib/librte_graph/graph_stats.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/librte_graph/graph_stats.c b/lib/librte_graph/graph_stat= s.c index > 125e08d..f698bb3 100644 > --- a/lib/librte_graph/graph_stats.c > +++ b/lib/librte_graph/graph_stats.c > @@ -174,7 +174,7 @@ stats_mem_populate(struct rte_graph_cluster_stats > **stats_in, > cluster->stat.hz =3D rte_get_timer_hz(); > node =3D graph_node_id_to_ptr(graph, id); > if (node =3D=3D NULL) > - SET_ERR_JMP(ENOENT, err, "Failed to find node %s in graph > %s", > + SET_ERR_JMP(ENOENT, free, "Failed to find node %s in graph > %s", > graph_node->node->name, graph->name); > cluster->nodes[cluster->nb_nodes++] =3D node; >=20 > @@ -183,6 +183,8 @@ stats_mem_populate(struct rte_graph_cluster_stats > **stats_in, > *stats_in =3D stats; >=20 > return 0; > +free: > + free(stats); > err: > return -rte_errno; > } > -- > 2.7.4 Reviewed-by: Kiran Kumar K